Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-39173

Allow assignment submission comments when using blind-marking

    Details

    • Testing Instructions:
      Hide
      1. Create and assignment with blind marking and submission comments enabled
      2. Login as a student and comment
      3. Login as a teacher and reply
      4. All comments should show as from "Participant X"
      5. Reveal identities
      6. The comments should now show who posted what
      1. Create and assignment with blind marking disabled and submission comments enabled
      2. Login as a student and comment
      3. Login as a teacher and reply
      4. All comments should show the identity of the poster
      Show
      Create and assignment with blind marking and submission comments enabled Login as a student and comment Login as a teacher and reply All comments should show as from "Participant X" Reveal identities The comments should now show who posted what Create and assignment with blind marking disabled and submission comments enabled Login as a student and comment Login as a teacher and reply All comments should show the identity of the poster
    • Affected Branches:
      MOODLE_24_STABLE
    • Fixed Branches:
      MOODLE_25_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-39173-master

      Description

      Currently in Assignment in MOODLE_24_STABLE, when "Blind marking" is set to yes assignment submission comments ("Submission comments") can not be used. I am attaching a patch that makes a one line change to the comment class in comment/lib.php and defines the assignsubmission_comments_comment_display() call-back that is used by comment::add() and comment::display() so that submission comments can be used when blind-marking is used.

        Gliffy Diagrams

          Issue Links

            Activity

            Hide
            dougiamas Martin Dougiamas added a comment -

            This looks pretty easy Damyon?

            Show
            dougiamas Martin Dougiamas added a comment - This looks pretty easy Damyon?
            Hide
            damyon Damyon Wiese added a comment -

            This is a good solution for this - thanks. I added a commit to the branch to remove the permissions check in the display function (Even users with grade capability should not see identities) and change the usage of $OUTPUT to $assignment->get_renderer() (preferred over $OUTPUT in assignment).

            Martin - can you comment if you think this should sneak into 2.5?

            Show
            damyon Damyon Wiese added a comment - This is a good solution for this - thanks. I added a commit to the branch to remove the permissions check in the display function (Even users with grade capability should not see identities) and change the usage of $OUTPUT to $assignment->get_renderer() (preferred over $OUTPUT in assignment). Martin - can you comment if you think this should sneak into 2.5?
            Hide
            dougiamas Martin Dougiamas added a comment -

            Would you regard this as a bug fix? If so I would say yes for sure.

            Also what about 2.4?

            Show
            dougiamas Martin Dougiamas added a comment - Would you regard this as a bug fix? If so I would say yes for sure. Also what about 2.4?
            Hide
            damyon Damyon Wiese added a comment -

            2.4 has a workaround - which is to disable the comments when blind marking is enabled (so you can't use both together - but at least you don't get an error).

            Show
            damyon Damyon Wiese added a comment - 2.4 has a workaround - which is to disable the comments when blind marking is enabled (so you can't use both together - but at least you don't get an error).
            Hide
            damyon Damyon Wiese added a comment -

            I am thinking this is an improvement - just so the behaviour of the stable branch doesn't change.

            Show
            damyon Damyon Wiese added a comment - I am thinking this is an improvement - just so the behaviour of the stable branch doesn't change.
            Hide
            dougiamas Martin Dougiamas added a comment -

            The original description of this bug is that both can't be used together in 2.4.

            Show
            dougiamas Martin Dougiamas added a comment - The original description of this bug is that both can't be used together in 2.4.
            Hide
            poltawski Dan Poltawski added a comment -

            Integrated to master - thanks guys

            Show
            poltawski Dan Poltawski added a comment - Integrated to master - thanks guys
            Hide
            sbc24 Sam Chaffee added a comment - - edited

            This is a good solution for this - thanks. I added a commit to the branch to remove the permissions check in the display function (Even users with grade capability should not see identities) and change the usage of $OUTPUT to $assignment->get_renderer() (preferred over $OUTPUT in assignment).
            Martin - can you comment if you think this should sneak into 2.5?

            Hi Damyon, I just saw this comment, so I hope I'm not too late. First, thanks for taking a look at this ticket and patch. Second, the intent of the permissions check was not to allow users with grade capability to see identities, but rather to allow students to see their teacher's (commenter with grade capability) comments and know that it is the teacher by seeing the identifying information. If you'll remember from the original patch, when this snippet of code is true then that comment is anonymized:

            if (($USER->id != $comment->userid) && !has_capability('mod/assign:grade', $assignment->get_context(), $comment->userid)) {
            

            If the first check is false it allows the person viewing the comments to see their own name on their own comments. If the second check is false allows the student to see their teacher's information (name, picture, etc) next to the teacher's comment.

            Thanks again.

            Show
            sbc24 Sam Chaffee added a comment - - edited This is a good solution for this - thanks. I added a commit to the branch to remove the permissions check in the display function (Even users with grade capability should not see identities) and change the usage of $OUTPUT to $assignment->get_renderer() (preferred over $OUTPUT in assignment). Martin - can you comment if you think this should sneak into 2.5? Hi Damyon, I just saw this comment, so I hope I'm not too late. First, thanks for taking a look at this ticket and patch. Second, the intent of the permissions check was not to allow users with grade capability to see identities, but rather to allow students to see their teacher's (commenter with grade capability) comments and know that it is the teacher by seeing the identifying information. If you'll remember from the original patch, when this snippet of code is true then that comment is anonymized: if (($USER->id != $comment->userid) && !has_capability('mod/assign:grade', $assignment->get_context(), $comment->userid)) { If the first check is false it allows the person viewing the comments to see their own name on their own comments. If the second check is false allows the student to see their teacher's information (name, picture, etc) next to the teacher's comment. Thanks again.
            Hide
            markn Mark Nelson added a comment -

            Works as expected, passing.

            Just a thought, it would be nice if the student could add a comment on the same page they upload their assignment, as it is not clear to the student that they will be able to leave comments after they submit. This might help when a student wants to leave a message to the teacher (ie. "This submission is slightly late as discussed in class") and can be sure it is an option available.

            Show
            markn Mark Nelson added a comment - Works as expected, passing. Just a thought, it would be nice if the student could add a comment on the same page they upload their assignment, as it is not clear to the student that they will be able to leave comments after they submit. This might help when a student wants to leave a message to the teacher (ie. "This submission is slightly late as discussed in class") and can be sure it is an option available.
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            I feel myself really alone tonight! So was time to push your fixes upstream!

            "Lest we forget. We will remember them."

            Thanks and ciao!

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - I feel myself really alone tonight! So was time to push your fixes upstream! "Lest we forget. We will remember them." Thanks and ciao!
            Hide
            marycooch Mary Cooch added a comment -

            Removing docs_required label as I have added a brief mention of this in http://docs.moodle.org/25/en/Assignment_settings

            Show
            marycooch Mary Cooch added a comment - Removing docs_required label as I have added a brief mention of this in http://docs.moodle.org/25/en/Assignment_settings

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                6 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  14/May/13