Moodle
  1. Moodle
  2. MDL-39185

Strict standards warning displayed when viewing a forum with a posting threshold.

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Critical Critical
    • Resolution: Fixed
    • Affects Version/s: 2.3.6, 2.4
    • Fix Version/s: 2.3.7, 2.4.4
    • Component/s: Forum
    • Labels:
    • Testing Instructions:
      Hide
      1. Login as a teacher and create a forum with a time period for blocking set.
      2. Set a post threshold for blocking and for warning.
      3. Ensure the student role does not have capability "mod/forum:postwithoutthrottling" within the forum.
      4. Login as a student and click to view the forum.
      5. Ensure the following strict standards does not display.

      Strict Standards: Creating default object from empty value in /var/www/mstorage/sm/moodle/mod/forum/view.php on line 159

      Show
      Login as a teacher and create a forum with a time period for blocking set. Set a post threshold for blocking and for warning. Ensure the student role does not have capability "mod/forum:postwithoutthrottling" within the forum. Login as a student and click to view the forum. Ensure the following strict standards does not display. Strict Standards: Creating default object from empty value in /var/www/mstorage/sm/moodle/mod/forum/view.php on line 159
    • Affected Branches:
      MOODLE_23_STABLE, MOODLE_24_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE, MOODLE_24_STABLE
    • Pull Master Branch:
      MDL-39185_master

      Description

      A strict standards warning is displayed when debugging is turned on.

        Gliffy Diagrams

          Issue Links

            Activity

            Hide
            Ankit Agarwal added a comment -

            Hi Mark,
            I spaces around . are optional, there is no need to change that. Also if you are fixing spaces there is one missing after , before 'forum'.
            Anyways you can simply leave those codestyle things as they were if you want.
            Thanks

            Show
            Ankit Agarwal added a comment - Hi Mark, I spaces around . are optional, there is no need to change that. Also if you are fixing spaces there is one missing after , before 'forum'. Anyways you can simply leave those codestyle things as they were if you want. Thanks
            Hide
            Mark Nelson added a comment -

            Thanks Ankit, submitted to integration.

            Show
            Mark Nelson added a comment - Thanks Ankit, submitted to integration.
            Hide
            Dan Poltawski added a comment -

            The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

            TIA and ciao

            Show
            Dan Poltawski added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
            Hide
            Sam Hemelryk added a comment -

            Thanks Mark, spot on and has been integrated now.

            Show
            Sam Hemelryk added a comment - Thanks Mark, spot on and has been integrated now.
            Hide
            Sam Hemelryk added a comment -

            This issue is linked to an MDLQA however that QA test has several blockers so I am leaving this open for testing here.

            Show
            Sam Hemelryk added a comment - This issue is linked to an MDLQA however that QA test has several blockers so I am leaving this open for testing here.
            Hide
            Frédéric Massart added a comment -

            No notice displayed, thanks!

            Show
            Frédéric Massart added a comment - No notice displayed, thanks!
            Hide
            Eloy Lafuente (stronk7) added a comment -

            I feel myself really alone tonight! So was time to push your fixes upstream!

            "Lest we forget. We will remember them."

            Thanks and ciao!

            Show
            Eloy Lafuente (stronk7) added a comment - I feel myself really alone tonight! So was time to push your fixes upstream! "Lest we forget. We will remember them." Thanks and ciao!

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: