Details

    • Type: Sub-task
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.5
    • Fix Version/s: 2.5
    • Component/s: Quiz
    • Labels:
    • Testing Instructions:
      Hide

      You must have developer debugging turned on for this test. (Well you should always have that set for testing.)

      1. Create a quiz with Require password set to something.

      2. Start an attempt. Ensure there are no "Did you remember to call setType()" debug notices.

      Show
      You must have developer debugging turned on for this test. (Well you should always have that set for testing.) 1. Create a quiz with Require password set to something. 2. Start an attempt. Ensure there are no "Did you remember to call setType()" debug notices.
    • Difficulty:
      Easy
    • Affected Branches:
      MOODLE_25_STABLE
    • Fixed Branches:
      MOODLE_25_STABLE
    • Pull from Repository:
    • Pull Master Branch:

      Description

      Following warning is visible on mod/quiz/startattempt.php

      Did you remember to call setType() for 'cmid'? Defaulting to PARAM_RAW cleaning.•line 1289 of /lib/formslib.php: call to debugging()
      •line 281 of /lib/formslib.php: call to moodleform->detectMissingSetType()
      •line 202 of /lib/formslib.php: call to moodleform->_process_submission()
      •line 338 of /mod/quiz/accessmanager.php: call to moodleform->moodleform()
      •line 134 of /mod/quiz/startattempt.php: call to quiz_access_manager->get_preflight_check_form()
      

      Steps to reproduce:

      1. Log in as teacher and create a quiz having password.
      2. Log in as student and access the quiz.
      3. Click "Attempt quiz" and it will show you above warning.

        Gliffy Diagrams

          Issue Links

            Activity

            Hide
            timhunt Tim Hunt added a comment -

            Submitting for integration.

            I am not back-porting this. There is no security risk. These hidden fields are actually read by optional/required_param with the right param type. We don't rely on the data returned by the form.

            Show
            timhunt Tim Hunt added a comment - Submitting for integration. I am not back-porting this. There is no security risk. These hidden fields are actually read by optional/required_param with the right param type. We don't rely on the data returned by the form.
            Hide
            poltawski Dan Poltawski added a comment -

            Integrated to master - thanks Tim

            Show
            poltawski Dan Poltawski added a comment - Integrated to master - thanks Tim
            Hide
            tsala Helen Foster added a comment -

            I'm guessing when this issue is fixed, the setType() errors will disappear for MDLQA-5440. If not, I can create another setType() issue.

            Show
            tsala Helen Foster added a comment - I'm guessing when this issue is fixed, the setType() errors will disappear for MDLQA-5440 . If not, I can create another setType() issue.
            Hide
            andyjdavis Andrew Davis added a comment -

            Works as described. Passing.

            Show
            andyjdavis Andrew Davis added a comment - Works as described. Passing.
            Hide
            poltawski Dan Poltawski added a comment -

            Sorry, forgot to reset the QA tests here.

            Show
            poltawski Dan Poltawski added a comment - Sorry, forgot to reset the QA tests here.
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            I feel myself really alone tonight! So was time to push your fixes upstream!

            "Lest we forget. We will remember them."

            Thanks and ciao!

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - I feel myself really alone tonight! So was time to push your fixes upstream! "Lest we forget. We will remember them." Thanks and ciao!

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  14/May/13