Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-39187

Date picker formslib element popup doesn't work when dateselector (a group of elements) is added within another group.

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.5
    • Fix Version/s: 2.5
    • Component/s: Forms Library
    • Labels:
    • Testing Instructions:
      Hide

      Test 1
      Note: Unselecting the checkbox will not disable the calendar image in this situation, as it is not using the optional setting for the date selector element - will be addressed by MDL-39463

      1. Go to Site administration ► Users ► Accounts ► Browse list of users
      2. Click "Show more"
      3. Click on Calender icon and ensure it pops up.
      4. Select a date in the calendar and ensure the pop-up closes and the select boxes update to this date.
      5. Choose a new date in the select boxes and then click on the calendar icon and ensure the pop-up shows this date.
      6. Ensure you can filter by these dates and they work as expected.

      Test 2
      Note: Unselecting the checkbox will not disable the calendar image in this situation, as it is not using the optional setting for the date selector element - will be addressed by MDL-39463

      1. Create a feedback module.
      2. Ensure the date_selectors are working on this page (the date_time_selectors here are in a form group) and that they save appropriately.

      Test 3

      1. Repeat the steps in MDL-26649.
      Show
      Test 1 Note: Unselecting the checkbox will not disable the calendar image in this situation, as it is not using the optional setting for the date selector element - will be addressed by MDL-39463 Go to Site administration ► Users ► Accounts ► Browse list of users Click "Show more" Click on Calender icon and ensure it pops up. Select a date in the calendar and ensure the pop-up closes and the select boxes update to this date. Choose a new date in the select boxes and then click on the calendar icon and ensure the pop-up shows this date. Ensure you can filter by these dates and they work as expected. Test 2 Note: Unselecting the checkbox will not disable the calendar image in this situation, as it is not using the optional setting for the date selector element - will be addressed by MDL-39463 Create a feedback module. Ensure the date_selectors are working on this page (the date_time_selectors here are in a form group) and that they save appropriately. Test 3 Repeat the steps in MDL-26649 .
    • Affected Branches:
      MOODLE_25_STABLE
    • Fixed Branches:
      MOODLE_25_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-39187_master
    • Pull Master Diff URL:

      Description

      The pop-up for the date picker does not occur when the date_selector (or date_time_selector) is in a form group. This happens on all Moodle 2.x versions, it is only noticeable now because there is now a calendar icon next to the element that does not behave as it should.

        Attachments

          Issue Links

          blocks

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-39463 Some usages of the date_selector do not use the optional parameter but use another checkbox meaning the calendar image is never disabled by the JS.

          • Major - Major loss of function, incorrect output
          • Closed
          has been marked as being related by

          Sub-task - Issues are sometimes broken into multiple sub-tasks. MDL-39265 Reformat Feedback module settings form

          • Minor - Minor loss of function where workaround is possible
          • Closed

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-26649 Date picker formslib element usability improvements

          • Critical - Crashes server, loss of data, severe memory leak
          • Closed

            Activity

              People

              Assignee:
              markn Mark Nelson
              Reporter:
              rajeshtaneja Rajesh Taneja
              Peer reviewer:
              Rajesh Taneja
              Integrator:
              Damyon Wiese
              Tester:
              Frédéric Massart
              Participants:
              Component watchers:
              Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Sujith Haridasan
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                14/May/13