Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-39192

Can not edit a recently created forum post if you have reached the threshold.

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.3.6, 2.4
    • Fix Version/s: 2.3.7, 2.4.4
    • Component/s: Forum
    • Labels:
    • Testing Instructions:
      Hide

      Test on 2.3, 2.4 and master. The patch is different for master, so this is important.

      1. Login as a teacher and create a forum with a time period for blocking set.
      2. Set a post threshold for blocking at 2 and for warning at 1.
      3. Login as a student and post 2 replies to a discussion.
      4. After the 2nd response you will have been given a message saying you have a certain amount of time allowed to edit, try and edit the post and ensure you can.
      5. Try and post again and ensure an error is thrown.
      Show
      Test on 2.3, 2.4 and master. The patch is different for master, so this is important. Login as a teacher and create a forum with a time period for blocking set. Set a post threshold for blocking at 2 and for warning at 1. Login as a student and post 2 replies to a discussion. After the 2nd response you will have been given a message saying you have a certain amount of time allowed to edit, try and edit the post and ensure you can. Try and post again and ensure an error is thrown.
    • Affected Branches:
      MOODLE_23_STABLE, MOODLE_24_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE, MOODLE_24_STABLE
    • Pull Master Branch:
      MDL-39192_master

      Description

      See title.

        Gliffy Diagrams

          Issue Links

            Activity

            Hide
            markn Mark Nelson added a comment -

            The patch for 2.3 and 2.4 have been done, however the master branch will require more work due to MDL-39182.

            Show
            markn Mark Nelson added a comment - The patch for 2.3 and 2.4 have been done, however the master branch will require more work due to MDL-39182 .
            Hide
            markn Mark Nelson added a comment -

            I am going to wait until MDL-39182 is integrated and tested before working on the master branch for this.

            Show
            markn Mark Nelson added a comment - I am going to wait until MDL-39182 is integrated and tested before working on the master branch for this.
            Hide
            fred Frédéric Massart added a comment -

            Thanks Mark, this looks good to me. Please feel free to push forward.

            Show
            fred Frédéric Massart added a comment - Thanks Mark, this looks good to me. Please feel free to push forward.
            Hide
            poltawski Dan Poltawski added a comment -

            The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

            TIA and ciao

            Show
            poltawski Dan Poltawski added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
            Hide
            samhemelryk Sam Hemelryk added a comment -

            Thanks Mark - this has been integrated now.

            Show
            samhemelryk Sam Hemelryk added a comment - Thanks Mark - this has been integrated now.
            Hide
            rajeshtaneja Rajesh Taneja added a comment -

            Thanks Mark,

            I can see edit and delete links and was able to update/delete forum post.

            Works well in 2.3, 2.4 and master.

            Show
            rajeshtaneja Rajesh Taneja added a comment - Thanks Mark, I can see edit and delete links and was able to update/delete forum post. Works well in 2.3, 2.4 and master.
            Hide
            poltawski Dan Poltawski added a comment -

            Thanks! You're changes are now spread to the world through this git and our source control repositories.

            No time to rest though, we've got days to make 2.5 the best yet!

            ciao

            Show
            poltawski Dan Poltawski added a comment - Thanks! You're changes are now spread to the world through this git and our source control repositories. No time to rest though, we've got days to make 2.5 the best yet! ciao

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  13/May/13