Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-38856 META: Issues around Bootstrapbase and Clean theme
  3. MDL-39196

Error message on login should be a span, not a block

    XMLWordPrintable

    Details

    • Type: Sub-task
    • Status: Closed
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: 2.5
    • Fix Version/s: 2.5
    • Component/s: HTML and CSS
    • Labels:
    • Testing Instructions:
      Hide

      Go to login page while using Simple theme.

      Attemp to log in with an incorrect password.

      The error message should appear in the standard error shade of red, but it should not be in a red/pink alert box.

      Show
      Go to login page while using Simple theme. Attemp to log in with an incorrect password. The error message should appear in the standard error shade of red, but it should not be in a red/pink alert box.
    • Affected Branches:
      MOODLE_25_STABLE
    • Fixed Branches:
      MOODLE_25_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      wip-MDL-39196-master

      Description

      The error messages on login are styled as an alert (a colored box), but is currently wrapped in a span, which is display: inline by default. This causes visual problems when the text gets long enough (or the screen narrow enough) to cause line wrapping.

      One option is to set display: block on the span but then you need to constrain it's width.

      The other option is to remove the alert styling and just have red text.

      For the short term I'd probably favour the latter.

        Attachments

          Activity

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Fix Release Date:
                14/May/13