Moodle
  1. Moodle
  2. MDL-39198

The "Add..." drop down menu of the "Add a block" pseudo-block is not well placed in formal_white.

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.3.6, 2.4.3
    • Fix Version/s: 2.3.8, 2.4.5, 2.5.1
    • Component/s: Themes
    • Labels:
    • Testing Instructions:
      Hide

      1. Turn editing on.
      Look at the "Add a block" pseudo-block.
      Look at the attachments to verify the patch really works.

      2. Change the formal_white setting [[blockcolumnwidth]] and redo from start.
      Look at the attachments to verify the patch really works.

      Show
      1. Turn editing on. Look at the "Add a block" pseudo-block. Look at the attachments to verify the patch really works. 2. Change the formal_white setting [ [blockcolumnwidth] ] and redo from start. Look at the attachments to verify the patch really works.
    • Affected Branches:
      MOODLE_23_STABLE, MOODLE_24_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE, MOODLE_24_STABLE, MOODLE_25_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-39198_master

      Description

      The width of the "Add..." drop down menu of the "Add a block" pseudo-block is bigger than the block width with some value for the FW setting blockcolumnwidth. Further more, the drop down menu browses in the block content as a ship in the ocean.

      Attached are two set of screen shots of the problem and of the expected solution with two different [[blockcolumnwidth]].

        Gliffy Diagrams

        1. example1_expected.png
          10 kB
        2. example1_problem.png
          10 kB
        3. example2_expected.png
          11 kB
        4. example2_problem.png
          11 kB

          Activity

          Hide
          Michael de Raadt added a comment -

          Again, something like this would be nice in the Bootstrap theme.

          Show
          Michael de Raadt added a comment - Again, something like this would be nice in the Bootstrap theme.
          Hide
          Dan Poltawski added a comment -

          Hi Daniele,

          This appears to be conflicting on master. Plese could you resolve the conflicts and resubmit? Thanks!

          Show
          Dan Poltawski added a comment - Hi Daniele, This appears to be conflicting on master. Plese could you resolve the conflicts and resubmit? Thanks!
          Hide
          CiBoT added a comment -

          Moving this reopened issue out from current integration. Please, re-submit it for integration once ready.

          Show
          CiBoT added a comment - Moving this reopened issue out from current integration. Please, re-submit it for integration once ready.
          Hide
          CiBoT added a comment -

          Moving this reopened issue out from current integration. Please, re-submit it for integration once ready.

          Show
          CiBoT added a comment - Moving this reopened issue out from current integration. Please, re-submit it for integration once ready.
          Hide
          Daniele Cordella added a comment -

          Submitting for peer review as the patch has been modified to remove conflicts found by Dan.

          Show
          Daniele Cordella added a comment - Submitting for peer review as the patch has been modified to remove conflicts found by Dan.
          Hide
          Dan Poltawski added a comment -

          Integrated to master, 25, 24 and 23. Thanks Daniele

          Show
          Dan Poltawski added a comment - Integrated to master, 25, 24 and 23. Thanks Daniele
          Hide
          Mark Nelson added a comment -

          Works as expected, passing.

          Show
          Mark Nelson added a comment - Works as expected, passing.
          Hide
          Mark Nelson added a comment -

          Hi Daniele, thanks for contributing to Moodle.

          Show
          Mark Nelson added a comment - Hi Daniele, thanks for contributing to Moodle.
          Hide
          Daniele Cordella added a comment -

          It is a pleasure!
          Thank you all.

          Show
          Daniele Cordella added a comment - It is a pleasure! Thank you all.
          Hide
          Damyon Wiese added a comment -

          Thanks for your contribution! This issue has been reviewed, integrated, tested and now released to everyone.

          Closing as Fixed!

          Show
          Damyon Wiese added a comment - Thanks for your contribution! This issue has been reviewed, integrated, tested and now released to everyone. Closing as Fixed!

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: