Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.5
    • Fix Version/s: 2.5
    • Component/s: Themes
    • Labels:
    • Testing Instructions:
      Hide
      1. Enable Theme Designer Mode in Appearance > Themes > Theme settings
      2. Navigate to Theme selector as though you were changing a theme, then scroll to find Bootstrap theme, and TEST to see that the image is the same width as other theme screenshots.
      3. Run the linux command `identify theme//pix/screenshot. | grep -v 500x` to verify that only the mymobile theme has a screenshot thats not 500px wide.
      Show
      Enable Theme Designer Mode in Appearance > Themes > Theme settings Navigate to Theme selector as though you were changing a theme, then scroll to find Bootstrap theme, and TEST to see that the image is the same width as other theme screenshots. Run the linux command `identify theme/ /pix/screenshot. | grep -v 500x` to verify that only the mymobile theme has a screenshot thats not 500px wide.
    • Affected Branches:
      MOODLE_25_STABLE
    • Fixed Branches:
      MOODLE_25_STABLE
    • Pull Master Branch:
      MDL-39206_master

      Description

      The size of the current screenshot is too wide (600px), the required size is 500px.

      Also the fact that Bootstrap is a hidden theme, only visible when Theme designer Mode is enabled, the aim is to add a faded version of the original screenshot.

        Gliffy Diagrams

          Activity

          Hide
          Dan Poltawski added a comment -

          The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

          TIA and ciao

          Show
          Dan Poltawski added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
          Hide
          Mary Evans added a comment -

          REBASED

          Show
          Mary Evans added a comment - REBASED
          Hide
          Sam Hemelryk added a comment -

          Thanks Mary - this has been integrated now.

          Show
          Sam Hemelryk added a comment - Thanks Mary - this has been integrated now.
          Hide
          Sam Hemelryk added a comment -

          Tested and passed

          Show
          Sam Hemelryk added a comment - Tested and passed
          Hide
          Eloy Lafuente (stronk7) added a comment -

          I feel myself really alone tonight! So was time to push your fixes upstream!

          "Lest we forget. We will remember them."

          Thanks and ciao!

          Show
          Eloy Lafuente (stronk7) added a comment - I feel myself really alone tonight! So was time to push your fixes upstream! "Lest we forget. We will remember them." Thanks and ciao!

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: