Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-39212

Improve the way we split CSS for IE.

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.5
    • Fix Version/s: 2.6
    • Component/s: HTML and CSS
    • Labels:
    • Affected Branches:
      MOODLE_25_STABLE
    • Fixed Branches:
      MOODLE_26_STABLE
    • Pull Master Branch:
      wip-MDL-39212-m26
    • Testing Instructions:
      Hide
      1. Log in as an admin.
      2. Turn on allowthemechangeofurl if you've not already got it on.
      3. Turn off theme designer mode if you've got it on.
      4. Purge your changes.
      5. Test the front page and course page in all core themes using at least the following browsers checking the CSS as described:
      6. IE8: The page should request CSS with chunk0 in the URL.
      7. IE9: The page should request CSS with chunk0 in the URL.
      8. IE10: The page should request CSS without any chunk in the URL.
      9. FF: The page should request CSS without any chunk in the URL.
      10. Chrome: The page should request CSS without any chunk in the URL.
      11. Opera: The page should request CSS without any chunk in the URL.
      Show
      Log in as an admin. Turn on allowthemechangeofurl if you've not already got it on. Turn off theme designer mode if you've got it on. Purge your changes. Test the front page and course page in all core themes using at least the following browsers checking the CSS as described: IE8: The page should request CSS with chunk0 in the URL. IE9: The page should request CSS with chunk0 in the URL. IE10: The page should request CSS without any chunk in the URL. FF: The page should request CSS without any chunk in the URL. Chrome: The page should request CSS without any chunk in the URL. Opera: The page should request CSS without any chunk in the URL.

      Description

      This is an improvement that really needs to be made as soon as 2.5 has been released and we're out of the sync period.

      The code responsible for splitting + chunking the CSS needs to be cleaned up.
      Probably we should only be doing one or the other and as we were hitting the 4095 selector limit IE imposes with splitting alone chunking is probably the way to go.
      There are parts in the code that arn't ever called presently as well that can be cleaned up.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              samhemelryk Sam Hemelryk
              Reporter:
              samhemelryk Sam Hemelryk
              Integrator:
              Dan Poltawski Dan Poltawski
              Tester:
              Rossiani Wijaya Rossiani Wijaya
              Participants:
              Component watchers:
              Amy Groshek, David Scotson, Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Sara Arjona (@sarjona)
              Votes:
              1 Vote for this issue
              Watchers:
              10 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                18/Nov/13