Moodle
  1. Moodle
  2. MDL-39249

Moodle upgrade wizard starts from the first page after installing a plugin update

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.4.3
    • Fix Version/s: 2.5
    • Component/s: Administration
    • Labels:
    • Testing Instructions:
      Hide

      Testing difficulty: hard (requires simulated upgrade and installed add-on)

      1. Install some add-on to the site. There must be an update available for it (in other words, install some older version of the add-on).
      2. Make sure the automatic update deployment is allowed at your site and the web server has write access to the add-on folder.
      3. Downgrade the main Moodle version in the database (one day into the past is enough) and purge caches.
      4. Visit /admin/index.php. Moodle upgrade should be invoked.
      5. At Plugins check screen, press the Check for updates button. The available update for your add-on should be reported.
      6. TEST: Press Install this update button and at the next confirmation screen, press the cancel button. Make sure you are sent back to the Plugins check screen.
      7. TEST: Press Install this update button again and at the next screen, confirm the installation. Make sure you are redirected back to the Plugins check screen (and not to the start of Moodle upgrade wizard) and the add-on is reported as "To be upgraded".
      8. Finish the Moodle upgrade. Degrade the add-on back again (did you know that the previous version of the updated plugin is stored in $CFG->dataroot/mdeploy/archive/... folder?).
      9. At the Site administration > Plugins > Plugins overview screen, check for available updates. The update for the add-on should be reported again.
      10. TEST: Press Install this update button and at the next confirmation screen, press Cancel. Make sure you are redirected back to the Plugins overview screen.
      11. TEST: Press Install this update button again and at the next screen, confirm the installation. Make sure you are redirected to the /admin/index.php and the plugin is about to be upgraded.

      Thanks!

      Show
      Testing difficulty: hard (requires simulated upgrade and installed add-on) Install some add-on to the site. There must be an update available for it (in other words, install some older version of the add-on). Make sure the automatic update deployment is allowed at your site and the web server has write access to the add-on folder. Downgrade the main Moodle version in the database (one day into the past is enough) and purge caches. Visit /admin/index.php. Moodle upgrade should be invoked. At Plugins check screen, press the Check for updates button. The available update for your add-on should be reported. TEST: Press Install this update button and at the next confirmation screen, press the cancel button. Make sure you are sent back to the Plugins check screen. TEST: Press Install this update button again and at the next screen, confirm the installation. Make sure you are redirected back to the Plugins check screen (and not to the start of Moodle upgrade wizard) and the add-on is reported as "To be upgraded". Finish the Moodle upgrade. Degrade the add-on back again (did you know that the previous version of the updated plugin is stored in $CFG->dataroot/mdeploy/archive/... folder?). At the Site administration > Plugins > Plugins overview screen, check for available updates. The update for the add-on should be reported again. TEST: Press Install this update button and at the next confirmation screen, press Cancel. Make sure you are redirected back to the Plugins overview screen. TEST: Press Install this update button again and at the next screen, confirm the installation. Make sure you are redirected to the /admin/index.php and the plugin is about to be upgraded. Thanks!
    • Affected Branches:
      MOODLE_24_STABLE
    • Fixed Branches:
      MOODLE_25_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-39249-upgrade-wizard
    • Rank:
      49860

      Description

      During the Moodle upgrade, available updates can be deployed. If the update is successfully installed, the browser redirects back to the very first page of the Moodle upgrade wizard and the administrator has to confirm the first two pages again. This is wrong - the browser should be redirected directly to the plugins check screen after the update is deployed.

        Issue Links

          Activity

          Hide
          David Mudrak added a comment -

          This can be effectively tested together with MDL-39248.

          Show
          David Mudrak added a comment - This can be effectively tested together with MDL-39248 .
          Hide
          David Mudrak added a comment -

          Submitting for integration.

          Even if the patch extends the signature of a public method, I do not consider it as a change of API that other developers would be interested in. Thence there is no need to mention this in upgrade.txt IMHO.

          Show
          David Mudrak added a comment - Submitting for integration. Even if the patch extends the signature of a public method, I do not consider it as a change of API that other developers would be interested in. Thence there is no need to mention this in upgrade.txt IMHO.
          Hide
          Dan Poltawski added a comment -

          > Even if the patch extends the signature of a public method, I do not consider it as a change of API that other developers would be interested in.

          More than that, its an optional additional argument too. We have to limit ourselves to things that people would be really interested in, else it'll become useless

          Integrated to master - thanks

          Show
          Dan Poltawski added a comment - > Even if the patch extends the signature of a public method, I do not consider it as a change of API that other developers would be interested in. More than that, its an optional additional argument too. We have to limit ourselves to things that people would be really interested in, else it'll become useless Integrated to master - thanks
          Hide
          Frédéric Massart added a comment -

          Test passed. The process of upgrading the plugins from upstream worked really well. I just noticed that there has to be a version available for the current 2.5 in order for the plugin to be updated to any later version. Good work!

          Show
          Frédéric Massart added a comment - Test passed. The process of upgrading the plugins from upstream worked really well. I just noticed that there has to be a version available for the current 2.5 in order for the plugin to be updated to any later version. Good work!
          Hide
          Eloy Lafuente (stronk7) added a comment -

          I feel myself really alone tonight! So was time to push your fixes upstream!

          "Lest we forget. We will remember them."

          Thanks and ciao!

          Show
          Eloy Lafuente (stronk7) added a comment - I feel myself really alone tonight! So was time to push your fixes upstream! "Lest we forget. We will remember them." Thanks and ciao!

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: