Hmm - oops. I didn't see this in the queue when integrating MDL-38898 and I fixed it there.

I'll close this as a duplicate (my fault sorry).

Damyon, looks like you left 2 region-pre ids in the aside tags in the fix you added when you closed this issue without using the original patch when Integration MDL-38898.

I've just pushed the fix to clean up the general.php.

Cheers

Reopening this to fix regression

Hi Mary,

I've looked at this but can't find a way to reproduce the problem? From my reading of the code it seems this only happens when there are no blocks at all? Am I misreading? How can I reproduce this problem?

There isn't a problem as such it is just that Damyon did not remove the id="region-pre" from the aside tag. Look at Bootstrap theme layout/general.php to compare.

It makes me mad to think this would have been a smooth transition had Damyon not messed up the integration. Read MDL-38898 discussion for the story.

You can see the commit for bootstrap here...
https://github.com/lazydaisy/moodle/commit/c9ff4d0e0fa679ed7cfddf14456fc91c64131301

Thanks Mary, sorry for the original mess up.

This has been integrated to master now. I tested it in integration, so I'll pass the test for this.

Works as described.

Thanks Mary!

Great stuff! Thanks you're a star!

Thanks! You're changes are now spread to the world through this git and our source control repositories.

No time to rest though, we've got days to make 2.5 the best yet!

ciao