Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-39261

Add file support for Lesson Essay

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.3.6, 2.4, 2.5, 3.4, 3.7
    • Fix Version/s: 3.7
    • Component/s: Lesson
    • Testing Instructions:
      Hide

      Test on boost.

      Prerequisites:

      1. Requires mailcatcher
        1. Set-up mailcatcher (https://mailcatcher.me/).
        2. Log in as an admin.
        3. Visit ‘Site administration’ > ‘Server’ > ‘Outgoing mail configuration’.
        4. Set the 'SMTP hosts' field to '127.0.0.1:1025'.
        5. Save.
        6. Alternatively in moodle's config.php set

          $CFG->smtphosts = 'localhost:1025';

        7. Visit 'http://127.0.0.1:1080/' to view outgoing emails and stay on this page for the remainder of this test. When any of the below instructions mention check your email it means refer to this page.
      2. A course with the following:
        1. A lesson with the following options:
          1. Allow student review - Y
          2. Provide option to try a question again - Y
          3. Max attempts - 3
        2. In the lesson, create a essay question and a content page with the latter having an EOL 'Jump to' navigation.
      3. A teacher and student enrolled into the same course
      4. Set up mailcatcher

      Testing:

      1. Login as a student
      2. Go to the course and attempt lesson
      3. When on the essay question, confirm you can see the link/record video/audio buttons
      4. Confirm you can link and submit files via the new buttons
      5. Submit your attempt
      6. On the review submission page, confirm you can see the files submitted and they are viewable/playable
      7. Continue to the next page and end of lesson.
      8. Select the 'Review lesson' link
      9. Confirm you are taken to the essay question (from #3)
      10. Confirm the files submitted in #3 are viewable/playable
      11. Login as a teacher
      12. Go to the course and lesson
      13. Select 'Reports'
      14. Select the attempt submitted by the student
      15. Confirm you can see the text and and files attached by the student and is playable/viewable(if media related files/links)
      16. Go to 'Grade essays' tab.
      17. Select the attempt submitted by the student. This is the link in the Essays column.
      18. Repeat #15
      19. Enter in your comment. Please add a picture.
      20. Update the Essay score and click the "Save changes" button.
      21. Check that the status in the status column is now set to Graded.
      22. Click the "Email graded essays" link next to the graded essay.
      23. Confirm in mailcatcher that you receive an email and repeat #15
      Show
      Test on boost. Prerequisites: Requires mailcatcher Set-up mailcatcher ( https://mailcatcher.me/ ). Log in as an admin. Visit ‘Site administration’ > ‘Server’ > ‘Outgoing mail configuration’. Set the 'SMTP hosts' field to '127.0.0.1:1025'. Save. Alternatively in moodle's config.php set $CFG->smtphosts = 'localhost:1025'; Visit 'http://127.0.0.1:1080/' to view outgoing emails and stay on this page for the remainder of this test. When any of the below instructions mention check your email it means refer to this page. A course with the following: A lesson with the following options: Allow student review - Y Provide option to try a question again - Y Max attempts - 3 In the lesson, create a essay question and a content page with the latter having an EOL 'Jump to' navigation. A teacher and student enrolled into the same course Set up mailcatcher Testing: Login as a student Go to the course and attempt lesson When on the essay question, confirm you can see the link/record video/audio buttons Confirm you can link and submit files via the new buttons Submit your attempt On the review submission page, confirm you can see the files submitted and they are viewable/playable Continue to the next page and end of lesson. Select the 'Review lesson' link Confirm you are taken to the essay question (from #3) Confirm the files submitted in #3 are viewable/playable Login as a teacher Go to the course and lesson Select 'Reports' Select the attempt submitted by the student Confirm you can see the text and and files attached by the student and is playable/viewable(if media related files/links) Go to 'Grade essays' tab. Select the attempt submitted by the student. This is the link in the Essays column. Repeat #15 Enter in your comment. Please add a picture. Update the Essay score and click the "Save changes" button. Check that the status in the status column is now set to Graded. Click the "Email graded essays" link next to the graded essay. Confirm in mailcatcher that you receive an email and repeat #15
    • Affected Branches:
      MOODLE_23_STABLE, MOODLE_24_STABLE, MOODLE_25_STABLE, MOODLE_34_STABLE, MOODLE_37_STABLE
    • Fixed Branches:
      MOODLE_37_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-39261-master

      Description

      In the Lesson activity, the Essay question provides the student with a full TinyMCE text editor. Unfortunately, the Insert image button only allows linking an image from an Internet URL, it does not display a link to the filepicker.
      Plus, the Insert Moodle Media links to a "dumb" popup windows, totally useless.

      The best, most complete solution, would be to add a setting similar to the one in use in the Quiz Essay question type:
      Response format
      HTML editor
      HTML editor with file picker
      Plain text
      Plain text, monospaced font

      The minimal solution would be to provide the file picker anyway.

        Attachments

          Issue Links

            Activity

              People

              • Votes:
                6 Vote for this issue
                Watchers:
                14 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  20/May/19

                  Time Tracking

                  Estimated:
                  Original Estimate - 0 minutes
                  0m
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 1 week, 4 days, 46 minutes
                  1w 4d 46m