Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Critical Critical
    • Resolution: Fixed
    • Affects Version/s: 2.5
    • Fix Version/s: 2.5
    • Component/s: Themes
    • Labels:
      None
    • Rank:
      49893

      Description

      Unfortunately we've just discovered that a responsive theme called 'simple' already exists in the plugins database. My fault for not checking at the start.

      Instead of bludgeoning the existing author to change, this might be an opportunity to regularise the new bootstrap theme names to make a little more sense (wrt Moodle and how the old themes worked too).

      So I'm proposing:

      /theme/bootstrap --> /theme/bootbase
      /theme/simple --> /theme/bootstandard

      (After discussion below this ended up as 'bootstrapbase' and 'clean').

        Issue Links

          Activity

          Hide
          Martin Dougiamas added a comment -

          Adding some watchers here to be informed and give anyone a last chance to argue against it. Sorry to be rushing such things but time is short and it has to be done ASAP.

          Show
          Martin Dougiamas added a comment - Adding some watchers here to be informed and give anyone a last chance to argue against it. Sorry to be rushing such things but time is short and it has to be done ASAP.
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Could we also get this as an opportunity to "normalize" the way we are going to use .less and generated .css files?

          In order to be able to "compute" all the less compilations to perform we would need something like:

          1) All the main .less files (not the included ones) to stay always under theme/xxx/less
          2) Each one of those main files will lead to, always, a .css file under theme/xxx/styles with the same name than the original (aka, moodle.less => moodle.css, editor.less => editor.css...).

          Please consider it, else it's not easily guessable (right now we are generating a "generated.css" file instead of moodle.css).

          Ciao

          Show
          Eloy Lafuente (stronk7) added a comment - Could we also get this as an opportunity to "normalize" the way we are going to use .less and generated .css files? In order to be able to "compute" all the less compilations to perform we would need something like: 1) All the main .less files (not the included ones) to stay always under theme/xxx/less 2) Each one of those main files will lead to, always, a .css file under theme/xxx/styles with the same name than the original (aka, moodle.less => moodle.css, editor.less => editor.css...). Please consider it, else it's not easily guessable (right now we are generating a "generated.css" file instead of moodle.css). Ciao
          Hide
          Martin Dougiamas added a comment -

          I agree that makes sense, Eloy, but it's a separate issue, unless you agree to integrate it as included in this issue.

          Show
          Martin Dougiamas added a comment - I agree that makes sense, Eloy, but it's a separate issue, unless you agree to integrate it as included in this issue.
          Hide
          Eloy Lafuente (stronk7) added a comment -

          MDL-39278 created about the normalization.

          Show
          Eloy Lafuente (stronk7) added a comment - MDL-39278 created about the normalization.
          Hide
          Mary Evans added a comment -

          What ugly names!
          What about booty and bootyful?

          Show
          Mary Evans added a comment - What ugly names! What about booty and bootyful?
          Hide
          Mary Evans added a comment -

          Or

          simplybase and simplystandard

          Show
          Mary Evans added a comment - Or simplybase and simplystandard
          Hide
          Martin Dougiamas added a comment -

          Blame Twitter for naming bootstrap! Note these names don't appear in the GUI anyway, they are just directory names. In the GUI it can be "Standard (Bootstrap)" or something like that. It's probably good they are not names other people are likely to want to use, to avoid future conflicts.

          My -1 for "simply" as just adds a new term that is not actually helping to explain things to developers. Unless we're going to start referring to all these as "simply" themes and forget about bootstrap.

          I like that it's easier for developers to be reminded to update "base" and "bootbase". I guess an alternative would be bsboot/bsstandard or bootbs/standardbs but to me these felt harder to say/type.

          Show
          Martin Dougiamas added a comment - Blame Twitter for naming bootstrap! Note these names don't appear in the GUI anyway, they are just directory names. In the GUI it can be "Standard (Bootstrap)" or something like that. It's probably good they are not names other people are likely to want to use, to avoid future conflicts. My -1 for "simply" as just adds a new term that is not actually helping to explain things to developers. Unless we're going to start referring to all these as "simply" themes and forget about bootstrap. I like that it's easier for developers to be reminded to update "base" and "bootbase". I guess an alternative would be bsboot/bsstandard or bootbs/standardbs but to me these felt harder to say/type.
          Hide
          Mary Evans added a comment -

          BS = British Standard so that has to have +1 from me.

          bsbase and bsstandard would work OK.

          Show
          Mary Evans added a comment - BS = British Standard so that has to have +1 from me. bsbase and bsstandard would work OK.
          Hide
          Mary Evans added a comment -

          @Eloy: MDL-39260 is one of my concerns in a similar sort of way.

          Show
          Mary Evans added a comment - @Eloy: MDL-39260 is one of my concerns in a similar sort of way.
          Hide
          Mary Evans added a comment -

          +1 for compiling individual LESS file content into corresponding css files.

          Show
          Mary Evans added a comment - +1 for compiling individual LESS file content into corresponding css files.
          Hide
          Tim Hunt added a comment -

          You might want to rethink that http://www.urbandictionary.com/define.php?term=BS

          Why not theme_bootstrapbase and theme_bootstrapstandard?

          Show
          Tim Hunt added a comment - You might want to rethink that http://www.urbandictionary.com/define.php?term=BS Why not theme_bootstrapbase and theme_bootstrapstandard?
          Hide
          Martin Dougiamas added a comment -

          That's the joke Tim.

          I thought bootstrapbase and bootstrapstandard might have been too long but looking at them now they are probably not so bad after all.

          Show
          Martin Dougiamas added a comment - That's the joke Tim. I thought bootstrapbase and bootstrapstandard might have been too long but looking at them now they are probably not so bad after all.
          Hide
          Mary Evans added a comment -

          bootstrapbase and simplebootstrap

          Show
          Mary Evans added a comment - bootstrapbase and simplebootstrap
          Hide
          Tim Hunt added a comment -

          bootstrapbase and myfirstbootstrap

          Show
          Tim Hunt added a comment - bootstrapbase and myfirstbootstrap
          Hide
          Mary Evans added a comment - - edited

          I quite like that. As soon as we can settle on a name the quicker I can get this done.
          So what's it to be?

          Show
          Mary Evans added a comment - - edited I quite like that. As soon as we can settle on a name the quicker I can get this done. So what's it to be?
          Hide
          Tim Hunt added a comment -

          I think that as the person doing the work, you should get the casting vote.

          Show
          Tim Hunt added a comment - I think that as the person doing the work, you should get the casting vote.
          Hide
          Sam Hemelryk added a comment - - edited

          Just an another idea what about bootstrapbase and bootstrap.

          bootstrapbase will only ever be used by theme developers so I figure its name should include the word base as theme devs associate that with the basic "must parent" theme. Alternatively basebootstrap perhaps. Other than that it doesn't really matter, so make this name the longer more obscure one. The most prominent place this theme will feature will likely be the dev docs and here on tracker.
          I like the idea of calling the theme that will actually be used bootstrap (formerly simple). To me that is what it is; the first bootstrap theme in Moodle that people can select.
          The name of this theme is going to be seen by admins, teachers (course themes) and users (user themes) so I think keeping it smartly concise is an advantage and as mentioned above I think the name bootstrap embodies this.

          But I'm an idiot, so what ever goes I am happy with

          Show
          Sam Hemelryk added a comment - - edited Just an another idea what about bootstrapbase and bootstrap . bootstrapbase will only ever be used by theme developers so I figure its name should include the word base as theme devs associate that with the basic "must parent" theme. Alternatively basebootstrap perhaps. Other than that it doesn't really matter, so make this name the longer more obscure one. The most prominent place this theme will feature will likely be the dev docs and here on tracker. I like the idea of calling the theme that will actually be used bootstrap (formerly simple). To me that is what it is; the first bootstrap theme in Moodle that people can select. The name of this theme is going to be seen by admins, teachers (course themes) and users (user themes) so I think keeping it smartly concise is an advantage and as mentioned above I think the name bootstrap embodies this. But I'm an idiot, so what ever goes I am happy with
          Hide
          Mary Evans added a comment - - edited

          I agree with what you are saying Sam, because it is bootstrap that everyone is talking about, and the theme that people want.

          So if Simple became Bootstrap, then Bootstrap might as well just be called bsbase

          Show
          Mary Evans added a comment - - edited I agree with what you are saying Sam, because it is bootstrap that everyone is talking about, and the theme that people want. So if Simple became Bootstrap, then Bootstrap might as well just be called bsbase
          Hide
          Marina Glancy added a comment -

          Can we use for base theme name something like "less" or "responsive" or "baseresponsive" or "responsivebase" or "lessbase" (or "baseless")

          Show
          Marina Glancy added a comment - Can we use for base theme name something like "less" or "responsive" or "baseresponsive" or "responsivebase" or "lessbase" (or "baseless")
          Hide
          Mary Evans added a comment -

          I like the word 'responsive', although 'baseless' is probably better. Good choice!

          Show
          Mary Evans added a comment - I like the word 'responsive', although 'baseless' is probably better. Good choice!
          Hide
          Jason Fowler added a comment -

          Marina, LESS is an extension of CSS, and really isn't part of the name for the system we are using. same with responsive. You can have a responsive theme without using either bootstrap or LESS. so I think to stay true to what this theme and base are, they need to be, as Sam said, bootstrapbase and bootstrap (or bootstrapstandard).

          Show
          Jason Fowler added a comment - Marina, LESS is an extension of CSS, and really isn't part of the name for the system we are using. same with responsive. You can have a responsive theme without using either bootstrap or LESS. so I think to stay true to what this theme and base are, they need to be, as Sam said, bootstrapbase and bootstrap (or bootstrapstandard).
          Hide
          Bas Brands added a comment -

          +1 for Sam's suggestion to use bootstrapbase and bootstrap. I think these names are simple and easy to understand, although "my percious" would be very suitable as well

          Show
          Bas Brands added a comment - +1 for Sam's suggestion to use bootstrapbase and bootstrap. I think these names are simple and easy to understand, although "my percious" would be very suitable as well
          Hide
          Martin Dougiamas added a comment -

          Well, thanks for all the comments ... what a paintshed this is turning out to be! It's extremely hard to settle on anything even in my own mind!

          I'm concerned about calling any theme "bootstrap" alone as it will just lead to confusion when distinguishing a "bootstrap theme" vs the specific theme bootstrap.

          The base theme must have "base" in it, no question.

          It's less important to retain "standard" though. I know it has some connotations and unlike the old standard the new theme contains almost no new CSS of it's own. I agree with Sam it's good to give it a concise name that is easy for users to use. I'd go further in saying that it should be free of tech jargon (that's why we liked "Simple" after all).

          I considered all the above as well as "default", "moodle", "vanilla", "white", "modest", "clean", "elemental" and "basic" (all are not taken yet in the plugins db).

          But after weighing it up I'd like to put all my money on:

          • bootstrapbase
          • clean

          It's user-centric (describes how it looks, while still coping with colour adjustments an admin might make in settings), short, positive and unique.

          Naturally we would also make it the new default theme in 2.6 (I don't think it's quite there yet for 2.5).

          All those for please +1, all against please -1 or abstain. You have until the dev meeting today.

          Show
          Martin Dougiamas added a comment - Well, thanks for all the comments ... what a paintshed this is turning out to be! It's extremely hard to settle on anything even in my own mind! I'm concerned about calling any theme "bootstrap" alone as it will just lead to confusion when distinguishing a "bootstrap theme" vs the specific theme bootstrap. The base theme must have "base" in it, no question. It's less important to retain "standard" though. I know it has some connotations and unlike the old standard the new theme contains almost no new CSS of it's own. I agree with Sam it's good to give it a concise name that is easy for users to use. I'd go further in saying that it should be free of tech jargon (that's why we liked "Simple" after all). I considered all the above as well as "default", "moodle", "vanilla", "white", "modest", "clean", "elemental" and "basic" (all are not taken yet in the plugins db). But after weighing it up I'd like to put all my money on: bootstrapbase clean It's user-centric (describes how it looks, while still coping with colour adjustments an admin might make in settings), short, positive and unique. Naturally we would also make it the new default theme in 2.6 (I don't think it's quite there yet for 2.5). All those for please +1, all against please -1 or abstain. You have until the dev meeting today.
          Hide
          Jason Fowler added a comment -

          +1 for clean

          Show
          Jason Fowler added a comment - +1 for clean
          Hide
          Tim Hunt added a comment -

          +1 for bootstrapbase & clean.

          Show
          Tim Hunt added a comment - +1 for bootstrapbase & clean.
          Hide
          Mary Evans added a comment -

          There is a Twitter "Clean" theme.
          http://cleanthemes.co.uk/clean/theme-features/

          So we could always go back to calling the Simple theme "Vanguard" as I called it originally.

          van guard

          Noun:
          A group of people leading the way in new developments or ideas.
          A position at the forefront of new developments or ideas:
          "in the vanguard of technical development".

          Show
          Mary Evans added a comment - There is a Twitter "Clean" theme. http://cleanthemes.co.uk/clean/theme-features/ So we could always go back to calling the Simple theme "Vanguard" as I called it originally. van guard Noun: A group of people leading the way in new developments or ideas. A position at the forefront of new developments or ideas: "in the vanguard of technical development".
          Hide
          Martin Dougiamas added a comment -

          No, there is a Wordpress theme called Vanguard http://vanguard.unispheredesign.com/

          (Surely we're only interested in Moodle themes!)

          Show
          Martin Dougiamas added a comment - No, there is a Wordpress theme called Vanguard http://vanguard.unispheredesign.com/ (Surely we're only interested in Moodle themes!)
          Hide
          Richard Oelmann added a comment -

          +1 for Mary's +1 re: compiling individual LESS file content into corresponding css files.

          Show
          Richard Oelmann added a comment - +1 for Mary's +1 re: compiling individual LESS file content into corresponding css files.
          Hide
          Dan Poltawski added a comment -

          I have created MDLSITE-2232 for sorting this out in AMOS.

          Show
          Dan Poltawski added a comment - I have created MDLSITE-2232 for sorting this out in AMOS.
          Hide
          Sam Hemelryk added a comment -

          +1 for clean

          Show
          Sam Hemelryk added a comment - +1 for clean
          Hide
          Eloy Lafuente (stronk7) added a comment -

          +1 if none of them are reserved already in the plugins database.

          Show
          Eloy Lafuente (stronk7) added a comment - +1 if none of them are reserved already in the plugins database.
          Hide
          Gareth J Barnard added a comment - - edited

          How about:

          Bootstrap -> Sole or Solebase
          Simple -> Shoelace

          Cheers,

          Gareth

          Show
          Gareth J Barnard added a comment - - edited How about: Bootstrap -> Sole or Solebase Simple -> Shoelace Cheers, Gareth
          Hide
          Mary Evans added a comment - - edited

          I think shoelace is a great idea.

          I hope others here agree.

          bootstrapbase however will need to stay for the reasons Martin has given already.

          Show
          Mary Evans added a comment - - edited I think shoelace is a great idea. I hope others here agree. bootstrapbase however will need to stay for the reasons Martin has given already.
          Hide
          Martin Dougiamas added a comment -

          I do like the joke of shoelace but still think "clean" is the better name for a default theme in 2.6. It's likely people with only rudimentary understanding of English are going to understand the meaning of it and that's important here too (we can't translate theme names).

          Remember this is just a basic theme for people to start building their own on.

          I think all these other great names would be perfect for subsequent themes anyone wants to build and I promise I'll butt out completely on all their names.

          Based on +1s above I'm putting my boot down on "clean".

          Show
          Martin Dougiamas added a comment - I do like the joke of shoelace but still think "clean" is the better name for a default theme in 2.6. It's likely people with only rudimentary understanding of English are going to understand the meaning of it and that's important here too (we can't translate theme names). Remember this is just a basic theme for people to start building their own on. I think all these other great names would be perfect for subsequent themes anyone wants to build and I promise I'll butt out completely on all their names. Based on +1s above I'm putting my boot down on "clean".
          Hide
          Mary Evans added a comment -

          OK...will this change be immediate? If so I'll fix it after Moodle master has been updated then I am not going to get conflicts.

          Thanks everyone.

          Show
          Mary Evans added a comment - OK...will this change be immediate? If so I'll fix it after Moodle master has been updated then I am not going to get conflicts. Thanks everyone.
          Hide
          David Scotson added a comment -

          I don't really understand the master/integration stuff but wouldn't it be better to fix this as the very last thing before master updates? Then all the previous work is fine and the next weeks work can start on the basis that the themes have new names.

          Show
          David Scotson added a comment - I don't really understand the master/integration stuff but wouldn't it be better to fix this as the very last thing before master updates? Then all the previous work is fine and the next weeks work can start on the basis that the themes have new names.
          Hide
          Mary Evans added a comment -

          No because it is too late integration is finished for this week. Anyway, it's probably already been done and we know now't about it! At least I am hoping so. LOL

          Show
          Mary Evans added a comment - No because it is too late integration is finished for this week. Anyway, it's probably already been done and we know now't about it! At least I am hoping so. LOL
          Hide
          Gareth J Barnard added a comment -

          I'm not sure it's too late as I remember Petr putting in a fix as late as Thursday evening GMT and it got through. But that was a serious bug in 2.4.

          Show
          Gareth J Barnard added a comment - I'm not sure it's too late as I remember Petr putting in a fix as late as Thursday evening GMT and it got through. But that was a serious bug in 2.4.
          Hide
          Petr Škoda added a comment -

          There is the "must fix for 2.5" flag, so I suppose this would be accepted for integration.

          Show
          Petr Škoda added a comment - There is the "must fix for 2.5" flag, so I suppose this would be accepted for integration.
          Hide
          Mary Evans added a comment -

          bootstrapbase/less/bootstrap

          Do I leave this directory as bootstrap or change it to bootstrapbase?

          I have already changed the js scripts to use bootstrapbase but was wondering do I really need to change the less/bootstrap directory as it is more of a reference to the original twitter "bootstrap" css mark-up that is being used, so for that reason alone I think it should keep it's name.

          Quick answers please!!!

          Show
          Mary Evans added a comment - bootstrapbase/less/bootstrap Do I leave this directory as bootstrap or change it to bootstrapbase? I have already changed the js scripts to use bootstrapbase but was wondering do I really need to change the less/bootstrap directory as it is more of a reference to the original twitter "bootstrap" css mark-up that is being used, so for that reason alone I think it should keep it's name. Quick answers please!!!
          Hide
          Gareth J Barnard added a comment - - edited

          I would have thought leave as 'bootstrapbase/less/bootstrap' as a change in name means editing 'moodle.less' and 'editor.less' and possibly other 'less' files.

          Show
          Gareth J Barnard added a comment - - edited I would have thought leave as 'bootstrapbase/less/bootstrap' as a change in name means editing 'moodle.less' and 'editor.less' and possibly other 'less' files.
          Hide
          Mary Evans added a comment -

          What about the YUI JS? Do I change all instances of BootstrapEngine to BootstrapbaseEngine?

          Show
          Mary Evans added a comment - What about the YUI JS? Do I change all instances of BootstrapEngine to BootstrapbaseEngine?
          Hide
          Mary Evans added a comment -

          It's only the directory Gareth the less files in it will still be there

          Show
          Mary Evans added a comment - It's only the directory Gareth the less files in it will still be there
          Hide
          Mary Evans added a comment - - edited

          I get what you mean -> the links inside the less files That's a good reason to leave it.

          Show
          Mary Evans added a comment - - edited I get what you mean -> the links inside the less files That's a good reason to leave it.
          Hide
          Gareth J Barnard added a comment -

          True but in 'moodle.less' there are imports that refer to the 'less/bootstrap' folder.

          Plus I notice in 'build.json' of 'yui/src/bootstrap' there is 'moodle-theme_bootstrap-bootstrap' which creates a folder of the same name in 'yui/build' and is then used in 'javascript/moodlebootstrap.js'. Which I would have thought needs changing, but with 'BootstrapEngine' then that should stay as is as like the 'less' files refers to the original distribution of Bootstrap (YUI version) and for maintenance needs to stay the same.

          Show
          Gareth J Barnard added a comment - True but in 'moodle.less' there are imports that refer to the 'less/bootstrap' folder. Plus I notice in 'build.json' of 'yui/src/bootstrap' there is 'moodle-theme_bootstrap-bootstrap' which creates a folder of the same name in 'yui/build' and is then used in 'javascript/moodlebootstrap.js'. Which I would have thought needs changing, but with 'BootstrapEngine' then that should stay as is as like the 'less' files refers to the original distribution of Bootstrap (YUI version) and for maintenance needs to stay the same.
          Hide
          Mary Evans added a comment - - edited

          That's what I meant @import links whatever. I am rushing here! LOL

          I've just pushed Clean theme which replaces Simple theme.

          Will leave Bootstrap to David as I feel there is a lot of fiddly stuff that I don't know what I am supposed to be I'm doing with it. I'd hate to make a mistake and ruin it.

          Show
          Mary Evans added a comment - - edited That's what I meant @import links whatever. I am rushing here! LOL I've just pushed Clean theme which replaces Simple theme. Will leave Bootstrap to David as I feel there is a lot of fiddly stuff that I don't know what I am supposed to be I'm doing with it. I'd hate to make a mistake and ruin it.
          Hide
          Mary Evans added a comment -

          I've just realised I based it on the last branch I was working on!
          Need to start all over again!

          Show
          Mary Evans added a comment - I've just realised I based it on the last branch I was working on! Need to start all over again!
          Hide
          Gareth J Barnard added a comment -

          RE: "That's what I meant @import links whatever" - I was typing at the same time and did not see the comment "I get what you mean -> the links inside the less files"

          Show
          Gareth J Barnard added a comment - RE: "That's what I meant @import links whatever" - I was typing at the same time and did not see the comment "I get what you mean -> the links inside the less files"
          Hide
          Eloy Lafuente (stronk7) added a comment - - edited

          Integrated, thanks!

          Note I've added 1 extra commit moving the favicon to the clean theme.

          Also, perhaps is not the best way to rename a plugin... but as far as it only will affect people using it since a few days... no big problem.

          Finally, about the "bootstrap to bootstrapbase" renaming, I'd recommend to create a new, separate, issue (Mary Evans, David Scotson).

          And surely make it blocked by all the currently issues under peer-review/integration for next week. And, at the same time, make it a blocker for all the still open (not work started) issues.

          That way, next cycle, starting in 24h (Friday morning AU), integration order will be:

          1) all the already fixed issues using current "bootstrap".
          2) the renaming issue gets implemented and integrated.
          3) all the remanining issues, already based in the renamed theme.

          Show
          Eloy Lafuente (stronk7) added a comment - - edited Integrated, thanks! Note I've added 1 extra commit moving the favicon to the clean theme. Also, perhaps is not the best way to rename a plugin... but as far as it only will affect people using it since a few days... no big problem. Finally, about the "bootstrap to bootstrapbase" renaming, I'd recommend to create a new, separate, issue ( Mary Evans , David Scotson ). And surely make it blocked by all the currently issues under peer-review/integration for next week. And, at the same time, make it a blocker for all the still open (not work started) issues. That way, next cycle, starting in 24h (Friday morning AU), integration order will be: 1) all the already fixed issues using current "bootstrap". 2) the renaming issue gets implemented and integrated. 3) all the remanining issues, already based in the renamed theme.
          Hide
          Eloy Lafuente (stronk7) added a comment -

          I've been comparing side by side the old "simple" and the new "clean", and they look 100% the same in all the pages i visited... so passing this.

          Again, plz, don't forget to create and super-link the bootstrap renaming one.

          Ciao

          Show
          Eloy Lafuente (stronk7) added a comment - I've been comparing side by side the old "simple" and the new "clean", and they look 100% the same in all the pages i visited... so passing this. Again, plz, don't forget to create and super-link the bootstrap renaming one. Ciao
          Hide
          Mary Evans added a comment - - edited

          Eloy: It's already covered I did it earlier MDL-39341 when I was doing the changes this evening.

          Show
          Mary Evans added a comment - - edited Eloy: It's already covered I did it earlier MDL-39341 when I was doing the changes this evening.
          Hide
          Eloy Lafuente (stronk7) added a comment -

          I feel myself really alone tonight! So was time to push your fixes upstream!

          "Lest we forget. We will remember them."

          Thanks and ciao!

          Show
          Eloy Lafuente (stronk7) added a comment - I feel myself really alone tonight! So was time to push your fixes upstream! "Lest we forget. We will remember them." Thanks and ciao!
          Hide
          Eloy Lafuente (stronk7) added a comment -

          aha, super!

          The basic idea in my mind was:

          1) allow all current issues already fixed (in peer review or integration phases) to land ASAP. And hold all the rest (still not started).
          2) once 1) is done (and potentially rolled), make the MDL-39341 rename.
          3) once the rename is done, allow all the rest to start, but against the already renamed theme.

          Note that surely we could rely on git abilities to detect renamed/moved files... but surely it's recommended to do it with the order above to avoid potential problems.

          Ciao

          Show
          Eloy Lafuente (stronk7) added a comment - aha, super! The basic idea in my mind was: 1) allow all current issues already fixed (in peer review or integration phases) to land ASAP. And hold all the rest (still not started). 2) once 1) is done (and potentially rolled), make the MDL-39341 rename. 3) once the rename is done, allow all the rest to start, but against the already renamed theme. Note that surely we could rely on git abilities to detect renamed/moved files... but surely it's recommended to do it with the order above to avoid potential problems. Ciao
          Hide
          Mary Evans added a comment -

          Sound logical

          Show
          Mary Evans added a comment - Sound logical
          Hide
          David Mudrak added a comment -

          FYI the theme_simple was forgotten in lib/pluginlib.php and thence the new theme_clean is reported as an Add-on at plugin management screens. See MDL-39358.

          Show
          David Mudrak added a comment - FYI the theme_simple was forgotten in lib/pluginlib.php and thence the new theme_clean is reported as an Add-on at plugin management screens. See MDL-39358 .
          Hide
          Martin Dougiamas added a comment - - edited

          Comments and docs still contain "Simple":

          1. grep -r imple clean
            clean/config.php: * Moodle's Simple theme, an example of how to make a Bootstrap theme
            clean/layout/general.php: * Moodle's Simple theme, an example of how to make a Bootstrap theme
            clean/layout/general.php: * @package theme_simple
            clean/lib.php: * Moodle's Simple theme, an example of how to make a Bootstrap theme
            clean/settings.php: * Moodle's Simple theme, an example of how to make a Bootstrap theme
            clean/style/custom.css:/* Simple Custom CSS
            clean/version.php: * Moodle's Simple theme, an example of how to make a Bootstrap theme

          I added MDL-39364 for this

          Show
          Martin Dougiamas added a comment - - edited Comments and docs still contain "Simple": grep -r imple clean clean/config.php: * Moodle's Simple theme, an example of how to make a Bootstrap theme clean/layout/general.php: * Moodle's Simple theme, an example of how to make a Bootstrap theme clean/layout/general.php: * @package theme_simple clean/lib.php: * Moodle's Simple theme, an example of how to make a Bootstrap theme clean/settings.php: * Moodle's Simple theme, an example of how to make a Bootstrap theme clean/style/custom.css:/* Simple Custom CSS clean/version.php: * Moodle's Simple theme, an example of how to make a Bootstrap theme I added MDL-39364 for this

            People

            • Votes:
              3 Vote for this issue
              Watchers:
              17 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: