Moodle
  1. Moodle
  2. MDL-39296

invalid key is used for score tracks in graphs report

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Blocker Blocker
    • Resolution: Fixed
    • Affects Version/s: 2.4.3
    • Fix Version/s: 2.4.4
    • Component/s: SCORM
    • Labels:
    • Rank:
      49915

      Description

      This is a regression caused by MDL-33702 , that introudces scrom 2004 score supports.
      Replication steps:- MDLQA-5697
      $nostudents may not always be defined. So doing and if on it is wrong.
      $scorekey is not defined anymore resulting in incomplete track score, always

        Issue Links

          Activity

          Hide
          Ankit Agarwal added a comment -

          Just noticed graphs report need stricter group mode checks. Will create a separate issue for that.

          Show
          Ankit Agarwal added a comment - Just noticed graphs report need stricter group mode checks. Will create a separate issue for that.
          Hide
          Ankit Agarwal added a comment -

          Created MDL-39300 for the groups check and such

          Show
          Ankit Agarwal added a comment - Created MDL-39300 for the groups check and such
          Hide
          Adrian Greeve added a comment -

          [Y] Syntax
          [Y] Output
          [Y] Whitespace
          [-] Language
          [Y] Databases
          [Y] Testing
          [-] Security
          [-] Documentation
          [Y] Git
          [Y] Sanity check

          Hi Ankit. I had a look at your code and it seems to make sense to me. I can't find any problems.

          Thanks.

          Show
          Adrian Greeve added a comment - [Y] Syntax [Y] Output [Y] Whitespace [-] Language [Y] Databases [Y] Testing [-] Security [-] Documentation [Y] Git [Y] Sanity check Hi Ankit. I had a look at your code and it seems to make sense to me. I can't find any problems. Thanks.
          Hide
          Ankit Agarwal added a comment -

          Thanks for the review Adrian.
          Pushing for integration.
          Thanks

          Show
          Ankit Agarwal added a comment - Thanks for the review Adrian. Pushing for integration. Thanks
          Hide
          Dan Poltawski added a comment -

          Integrated to master and 2.4, thanks Ankit

          Show
          Dan Poltawski added a comment - Integrated to master and 2.4, thanks Ankit
          Hide
          Ankit Agarwal added a comment -

          Hi Dan,
          Accidentally my second push to 24 branch didn't went through. Just noticed it after Rosie mentioned issues in 24. Here was the change that was left behind
          https://github.com/ankitagarwal/moodle/commit/ca61ed1bbe3aee268574c0a20b29ce7096fea0db

          Just needs to be pulled in 24. can you please pull it in?
          Thanks

          Show
          Ankit Agarwal added a comment - Hi Dan, Accidentally my second push to 24 branch didn't went through. Just noticed it after Rosie mentioned issues in 24. Here was the change that was left behind https://github.com/ankitagarwal/moodle/commit/ca61ed1bbe3aee268574c0a20b29ce7096fea0db Just needs to be pulled in 24. can you please pull it in? Thanks
          Hide
          Dan Poltawski added a comment -

          Done - thanks

          Show
          Dan Poltawski added a comment - Done - thanks
          Hide
          Dan Poltawski added a comment -

          (although how did you end up with two commits different like that?!)

          Show
          Dan Poltawski added a comment - (although how did you end up with two commits different like that?!)
          Hide
          Ankit Agarwal added a comment -

          heh, I had created both branches when i noticed it, made a new commit on master, rebased, pushed to github, for some reason push to github on 24 failed midway

          Show
          Ankit Agarwal added a comment - heh, I had created both branches when i noticed it, made a new commit on master, rebased, pushed to github, for some reason push to github on 24 failed midway
          Hide
          Rossiani Wijaya added a comment -

          Retested this issue again and it works as expected.

          Tested for 2.4 and master

          Test passed.

          Show
          Rossiani Wijaya added a comment - Retested this issue again and it works as expected. Tested for 2.4 and master Test passed.
          Hide
          Eloy Lafuente (stronk7) added a comment -

          I feel myself really alone tonight! So was time to push your fixes upstream!

          "Lest we forget. We will remember them."

          Thanks and ciao!

          Show
          Eloy Lafuente (stronk7) added a comment - I feel myself really alone tonight! So was time to push your fixes upstream! "Lest we forget. We will remember them." Thanks and ciao!

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: