Moodle
  1. Moodle
  2. MDL-39298

Add additional delimiters for uploading and downloading csv gradebook files.

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.5
    • Fix Version/s: 2.5
    • Component/s: Gradebook
    • Labels:
      None
    • Testing Instructions:
      Hide
      1. Create or find a course with grade-able activities such as an assignment or quiz.
      2. Complete the testing with the following types of separators:
        • Tab
        • Comma
        • Colon
        • Semicolon
      3. Go to the gradebook and download a text file [Administration ► Grade administration ► Export ► Plain text file].
        • Make sure that the file downloads with the correct separator.
      4. Download the file.
      5. Open the file and make some changes to an activity score for some students.
      6. Upload the file using the appropriate separator [Administration ► Grade administration ► Import ► CSV file].
        • Make sure that the file imports correctly.
      Show
      Create or find a course with grade-able activities such as an assignment or quiz. Complete the testing with the following types of separators: Tab Comma Colon Semicolon Go to the gradebook and download a text file [Administration ► Grade administration ► Export ► Plain text file] . Make sure that the file downloads with the correct separator. Download the file. Open the file and make some changes to an activity score for some students. Upload the file using the appropriate separator [Administration ► Grade administration ► Import ► CSV file] . Make sure that the file imports correctly.
    • Affected Branches:
      MOODLE_25_STABLE
    • Fixed Branches:
      MOODLE_25_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      wip-MDL-39298-master
    • Rank:
      49918

      Description

      The gradebook only allows import and export of csv files with tab and comma. This does not provide enough options for some countries that use different defaults for csv files.

        Issue Links

          Activity

          Hide
          Andrew Davis added a comment -

          Simple enough.

          [Y] Syntax
          [NA] Output
          [Y] Whitespace
          [Y] Language
          [NA] Databases
          [Y] Testing
          [NA] Security
          [NA] Documentation
          [Y] Git
          [Y] Sanity check

          Submit for integration whenever you're ready.

          Show
          Andrew Davis added a comment - Simple enough. [Y] Syntax [NA] Output [Y] Whitespace [Y] Language [NA] Databases [Y] Testing [NA] Security [NA] Documentation [Y] Git [Y] Sanity check Submit for integration whenever you're ready.
          Hide
          Adrian Greeve added a comment -

          Thanks Andrew for the review.

          I think this is more of an improvement rather than a bug so it should only be for Master (willing to back port if people feel different).

          Show
          Adrian Greeve added a comment - Thanks Andrew for the review. I think this is more of an improvement rather than a bug so it should only be for Master (willing to back port if people feel different).
          Hide
          Dan Poltawski added a comment -

          The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

          TIA and ciao

          Show
          Dan Poltawski added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
          Hide
          Sam Hemelryk added a comment -

          Thanks guys, this has been integrated now.

          Show
          Sam Hemelryk added a comment - Thanks guys, this has been integrated now.
          Hide
          David Monllaó added a comment -

          It passes, all as expected

          Show
          David Monllaó added a comment - It passes, all as expected
          Hide
          Dan Poltawski added a comment -

          Thanks! You're changes are now spread to the world through this git and our source control repositories.

          No time to rest though, we've got days to make 2.5 the best yet!

          ciao

          Show
          Dan Poltawski added a comment - Thanks! You're changes are now spread to the world through this git and our source control repositories. No time to rest though, we've got days to make 2.5 the best yet! ciao

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: