Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-39317

no submissions for online-assignments shown in gradingtable with filter 'Submitted' in older courses

    Details

    • Testing Instructions:
      Hide
      1. Create an assignment
      2. Add submissions from several students
      3. Make sure some of them have been "submitted"
      4. Run update mdl_assign_submissions set timecreated = 0; in the database.
      5. Login as a teacher
      6. Go to the grading page in the assignment and change the filter to submitted
      7. Verify that you can only see students who have submitted their assignments and you do not see 0 students.
      Show
      Create an assignment Add submissions from several students Make sure some of them have been "submitted" Run update mdl_assign_submissions set timecreated = 0; in the database. Login as a teacher Go to the grading page in the assignment and change the filter to submitted Verify that you can only see students who have submitted their assignments and you do not see 0 students.
    • Affected Branches:
      MOODLE_23_STABLE, MOODLE_24_STABLE, MOODLE_25_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE, MOODLE_24_STABLE, MOODLE_25_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-39317-master

      Description

      We have courses with users and submitted assignments which where submitted a long time ago (moodle version from around 2009). The platform was updated several times (now 2.4.3) and also the old assignments where upgraded to the new assignment type.

      Take an old course and

      • in assignment click on 'view/grade all submissions
      • with the filter set to 'no filter' you see a lot of people with / and without submissions
      • in the gradingtable set the Filter on 'submitted', you will see no line, in the head of the page 'nothing to show'

      -> in the db table 'assign_submission' there are the fields 'timecreated' and 'timemodified' but for the older courses there is no entry in 'timecreated'. I think in former times in the old assignment there were perhaps no field for timecreated or the update procedure failed.

      -> solution: change line 142 in mod/assign/gradingtable.php
      -----------
      if ($this->assignment->is_any_submission_plugin_enabled()) {
      if ($filter == ASSIGN_FILTER_SUBMITTED)

      { //KK Bug $where .= ' AND s.timecreated > 0 '; $where .= ' AND s.timecreated > 0 OR s.timemodified > 0'; }

      ....

      on the same installation with newer courses there are no problems

        Gliffy Diagrams

          Activity

          Hide
          damyon Damyon Wiese added a comment -

          This issue was assigned to me automatically, however I will not be able to work on this issue in the immediate future. In order to create a truer sense of the state of this issue and to allow other developers to have chance to become involved, I am removing myself as the assignee of this issue.

          For more information, see http://docs.moodle.org/dev/Changes_to_issue_assignment

          Show
          damyon Damyon Wiese added a comment - This issue was assigned to me automatically, however I will not be able to work on this issue in the immediate future. In order to create a truer sense of the state of this issue and to allow other developers to have chance to become involved, I am removing myself as the assignee of this issue. For more information, see http://docs.moodle.org/dev/Changes_to_issue_assignment
          Hide
          damyon Damyon Wiese added a comment -

          Thanks for the bug report Katja, I'd add patches to this issue and push it for integration.

          Show
          damyon Damyon Wiese added a comment - Thanks for the bug report Katja, I'd add patches to this issue and push it for integration.
          Hide
          poltawski Dan Poltawski added a comment -

          Integrated to master, 25, 24 and 23 - thanks Damyon

          Show
          poltawski Dan Poltawski added a comment - Integrated to master, 25, 24 and 23 - thanks Damyon
          Hide
          phalacee Jason Fowler added a comment -

          Works fine Damyon, thanks!

          Show
          phalacee Jason Fowler added a comment - Works fine Damyon, thanks!
          Hide
          poltawski Dan Poltawski added a comment -

          Feature: Thanks to our superb contributors
            In order to make Moodle better
            As an integrator
            I need to thank all our contributors
           
            Scenario: Dan thanks you all
              Given I log in as "dan"
              And I see "lots of fixed issues"
              When I follow "Close integrated issues"
              Then I should see "Lots of thanks to all our contributors"
          

          Your changes are upstream

          Show
          poltawski Dan Poltawski added a comment - Feature: Thanks to our superb contributors In order to make Moodle better As an integrator I need to thank all our contributors   Scenario: Dan thanks you all Given I log in as "dan" And I see "lots of fixed issues" When I follow "Close integrated issues" Then I should see "Lots of thanks to all our contributors" Your changes are upstream

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Fix Release Date:
                8/Jul/13