Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-39322

Upload users form misreports the authentication method for site administrators

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.5
    • Fix Version/s: 2.5
    • Component/s: Administration
    • Labels:
    • Testing Instructions:
      Hide

      For this patch you need a Moodle instance with a site administrator whose authentication method isn't manual.

      1. Create a user upload CSV with at least one row. Include said site administrator.
      2. Attempt the upload. Verify that the tool doesn't update the site administrator. Verify that the status page reports the site administrator's actual authentication method.
      Show
      For this patch you need a Moodle instance with a site administrator whose authentication method isn't manual. Create a user upload CSV with at least one row. Include said site administrator. Attempt the upload. Verify that the tool doesn't update the site administrator. Verify that the status page reports the site administrator's actual authentication method.
    • Affected Branches:
      MOODLE_25_STABLE
    • Fixed Branches:
      MOODLE_25_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-39322-master

      Description

      admin/tool/uploaduser always reports a site administrator's authentication method as 'manual' (the default) because it tests for site admin before loading the authentication method. This is misleading.

        Gliffy Diagrams

          Attachments

            Activity

            Hide
            rajeshtaneja Rajesh Taneja added a comment -

            Thanks for fixing this Charles,

            Patch looks spot-on, pushing for integration.

            Show
            rajeshtaneja Rajesh Taneja added a comment - Thanks for fixing this Charles, Patch looks spot-on, pushing for integration.
            Hide
            poltawski Dan Poltawski added a comment -

            The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

            TIA and ciao

            Show
            poltawski Dan Poltawski added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
            Hide
            cfulton Charles Fulton added a comment -

            Rebased.

            Show
            cfulton Charles Fulton added a comment - Rebased.
            Hide
            damyon Damyon Wiese added a comment -

            Thanks Charles,

            The patch looks good.

            This has been integrated to master.

            Show
            damyon Damyon Wiese added a comment - Thanks Charles, The patch looks good. This has been integrated to master.
            Hide
            andyjdavis Andrew Davis added a comment -

            Seems to be working as described. Passing.

            Show
            andyjdavis Andrew Davis added a comment - Seems to be working as described. Passing.
            Hide
            poltawski Dan Poltawski added a comment -

            Thanks! You're changes are now spread to the world through this git and our source control repositories.

            No time to rest though, we've got days to make 2.5 the best yet!

            ciao

            Show
            poltawski Dan Poltawski added a comment - Thanks! You're changes are now spread to the world through this git and our source control repositories. No time to rest though, we've got days to make 2.5 the best yet! ciao

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  14/May/13