Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-39332

JS breaks in ie8 on pages with Date-time selector

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.5
    • Fix Version/s: 2.5
    • Component/s: Forms Library
    • Labels:
      None
    • Testing Instructions:
      Hide

      Pre-requisite

      1. Need ie8 for testing.
      2. Test it on all supported browsers (if possible)

      Test

      1. Save attached test_forms.php in moodle_root folder
      2. Log in as admin
      3. Navigate to test_forms.php
      4. Click on date_selector icon
      5. Make sure calendar pop's up and is placed over filepicker
      Show
      Pre-requisite Need ie8 for testing. Test it on all supported browsers (if possible) Test Save attached test_forms.php in moodle_root folder Log in as admin Navigate to test_forms.php Click on date_selector icon Make sure calendar pop's up and is placed over filepicker
    • Affected Branches:
      MOODLE_25_STABLE
    • Fixed Branches:
      MOODLE_25_STABLE
    • Pull Master Branch:
      wip-mdl-39332

      Description

      Page with date-time selector breaks JS on ie8. (Course settings/edit user profile page)
      This happens because of this.panel.removeAttr('zIndex'); in lib/form/yui/dateselector.js.

      It's a broken functionality, so should be fixed in 2.5

      FYI: It is problem in YUI and has been fixed in 3.4.1 http://yuilibrary.com/projects/yui3/ticket/2529230

        Gliffy Diagrams

          Issue Links

            Activity

            Hide
            rajeshtaneja Rajesh Taneja added a comment -

            Also, in ie8 date-time selector has a padding of 1% which makes adds extra gap between label and date-time selector fieldset.

            Show
            rajeshtaneja Rajesh Taneja added a comment - Also, in ie8 date-time selector has a padding of 1% which makes adds extra gap between label and date-time selector fieldset.
            Hide
            rajeshtaneja Rajesh Taneja added a comment -

            As mentioned previously, zindex is set to 0 by panel.render and using removeAttr breaks on ie8, now alternative is to render panel and remove z-index on current element in dom.

            Show
            rajeshtaneja Rajesh Taneja added a comment - As mentioned previously, zindex is set to 0 by panel.render and using removeAttr breaks on ie8, now alternative is to render panel and remove z-index on current element in dom.
            Hide
            samhemelryk Sam Hemelryk added a comment -

            Hi Raj,

            The end outcome looks good.

            I'm not sure whether the noted YUI bug relates to this issue we are seeing however.
            That bug is explicitly to do with chaining which I don't believe is being used here, and we're running YUI 3.9.1 so it should not have been an issue.
            No matter either way, just noting to save someone else the research.

            Many thanks
            Sam

            Show
            samhemelryk Sam Hemelryk added a comment - Hi Raj, The end outcome looks good. I'm not sure whether the noted YUI bug relates to this issue we are seeing however. That bug is explicitly to do with chaining which I don't believe is being used here, and we're running YUI 3.9.1 so it should not have been an issue. No matter either way, just noting to save someone else the research. Many thanks Sam
            Hide
            rajeshtaneja Rajesh Taneja added a comment -

            Thanks Sam,

            Is it good for integration or do you think there is something else we can do?

            Show
            rajeshtaneja Rajesh Taneja added a comment - Thanks Sam, Is it good for integration or do you think there is something else we can do?
            Hide
            samhemelryk Sam Hemelryk added a comment -

            All good for integration I think

            Show
            samhemelryk Sam Hemelryk added a comment - All good for integration I think
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            Integrated, thanks!

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - Integrated, thanks!
            Hide
            fred Frédéric Massart added a comment -

            Tested on Ubuntu (FF, Chrome, Opera), and Win7 (IE8, IE9). Thanks!

            Show
            fred Frédéric Massart added a comment - Tested on Ubuntu (FF, Chrome, Opera), and Win7 (IE8, IE9). Thanks!
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            Did you think this day was not going to arrive ever?

            Your patience has been rewarded, yay, sent upstream, thanks!

            Closing...ciao

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - Did you think this day was not going to arrive ever? Your patience has been rewarded, yay, sent upstream, thanks! Closing...ciao

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  14/May/13