Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-39344

Backspace unindents nested lists

    Details

    • Testing Instructions:
      Hide
      1. In HTML editor create list of 2 or more elements
      2. Indent one of the elements by using the HTML editor indent icon
        1. Verify that the list element becomes a nested list.
        2. Verify the TAB key moves to next forms element
      3. Now for the indented list element hit backspace/delete
        1. Verify that you delete a character from the list, but the list element remains indented.
      Show
      In HTML editor create list of 2 or more elements Indent one of the elements by using the HTML editor indent icon Verify that the list element becomes a nested list. Verify the TAB key moves to next forms element Now for the indented list element hit backspace/delete Verify that you delete a character from the list, but the list element remains indented.
    • Affected Branches:
      MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE
    • Pull from Repository:

      Description

      Running the latest MOODLE_23_STABLE (2.3.6+), if you create a list with a nested list, and you hit backspace (delete on Mac), then the nested list gets unindented.

      The MOODLE_24_STABLE (2.4.3+) and the current master branches do not have this bug/behavior.

      It might have something to do with differences in the TinyMCE editor library.

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

              Hide
              skodak Petr Skoda added a comment -

              Hello, there is no plan to backport recent TinyMCE to 2.3.x branch because starting next week it will be receiving only security fixes. Please upgrade your install if possible.

              Show
              skodak Petr Skoda added a comment - Hello, there is no plan to backport recent TinyMCE to 2.3.x branch because starting next week it will be receiving only security fixes. Please upgrade your install if possible.
              Hide
              skodak Petr Skoda added a comment -

              Ah, I missed the fact that this is a recent regression, removing the 'lists' plugin from tinymce, it fixes it for me. Thanks a lot.

              Show
              skodak Petr Skoda added a comment - Ah, I missed the fact that this is a recent regression, removing the 'lists' plugin from tinymce, it fixes it for me. Thanks a lot.
              Hide
              rex Rex Lorenzo added a comment - - edited

              Petr, you would rather just remove the "list" plugin, rather than reverting this commit?

              https://github.com/moodle/moodle/commit/2de3def418dc6391bc9d5ff6a11651b3e867fdac

              What happens when the "safari" plugin is not there anymore? Is it just not needed anymore?

              <EDIT> Nevermind, answered my own question: http://www.tinymce.com/forum/viewtopic.php?id=20787

              It is not needed.

              Show
              rex Rex Lorenzo added a comment - - edited Petr, you would rather just remove the "list" plugin, rather than reverting this commit? https://github.com/moodle/moodle/commit/2de3def418dc6391bc9d5ff6a11651b3e867fdac What happens when the "safari" plugin is not there anymore? Is it just not needed anymore? <EDIT> Nevermind, answered my own question: http://www.tinymce.com/forum/viewtopic.php?id=20787 It is not needed.
              Hide
              skodak Petr Skoda added a comment -

              There is no safari plugin any more, there is a hack in tinymce:

              							// Skip safari plugin, since it is removed as of 3.3b1
              							if (p == 'safari') {
              								return;
              							}

              Show
              skodak Petr Skoda added a comment - There is no safari plugin any more, there is a hack in tinymce: // Skip safari plugin, since it is removed as of 3.3b1 if (p == 'safari') { return; }
              Hide
              poltawski Dan Poltawski added a comment -

              The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

              TIA and ciao

              Show
              poltawski Dan Poltawski added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
              Hide
              samhemelryk Sam Hemelryk added a comment -

              Thanks Petr, this has been integrated now.

              Show
              samhemelryk Sam Hemelryk added a comment - Thanks Petr, this has been integrated now.
              Hide
              markn Mark Nelson added a comment -

              When I press tab when using the HTML editor on integration the 'Display description on course page' help icon is selected. However, on the stable branch it indents the characters, so tab does not work as expected. This is on the Chromium browser.

              Show
              markn Mark Nelson added a comment - When I press tab when using the HTML editor on integration the 'Display description on course page' help icon is selected. However, on the stable branch it indents the characters, so tab does not work as expected. This is on the Chromium browser.
              Hide
              skodak Petr Skoda added a comment - - edited

              In stable there is no lists plugin, the tab is supposed to always move to next form element. In master the lists plugin overrides TAB meaning when inside the list - it indents there, but outside it still tabs for me. I do not see any problem here.

              I have updated the testing instructions, thanks.

              Show
              skodak Petr Skoda added a comment - - edited In stable there is no lists plugin, the tab is supposed to always move to next form element. In master the lists plugin overrides TAB meaning when inside the list - it indents there, but outside it still tabs for me. I do not see any problem here. I have updated the testing instructions, thanks.
              Hide
              samhemelryk Sam Hemelryk added a comment -

              Sending back to testing

              Show
              samhemelryk Sam Hemelryk added a comment - Sending back to testing
              Hide
              markn Mark Nelson added a comment -

              Thanks Petr for clarifying and updating testing instructions. Works as expected, passing.

              Show
              markn Mark Nelson added a comment - Thanks Petr for clarifying and updating testing instructions. Works as expected, passing.
              Hide
              poltawski Dan Poltawski added a comment -

              Thanks! You're changes are now spread to the world through this git and our source control repositories.

              No time to rest though, we've got days to make 2.5 the best yet!

              ciao

              Show
              poltawski Dan Poltawski added a comment - Thanks! You're changes are now spread to the world through this git and our source control repositories. No time to rest though, we've got days to make 2.5 the best yet! ciao

                People

                • Votes:
                  0 Vote for this issue
                  Watchers:
                  5 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:
                    Fix Release Date:
                    13/May/13