Moodle
  1. Moodle
  2. MDL-39355

Drag and drop area shows through help popup

    Details

    • Testing Instructions:
      Hide
      • Open a course
      • Turn editing on
      • Open the activity chooser
      • Inspect the dialogue
      • Find the wrapping div for chooserdialogue
        • Ensure that no z-index is set explicitly on the element
        • Ensure that a z-index is set from the style sheet
      Show
      Open a course Turn editing on Open the activity chooser Inspect the dialogue Find the wrapping div for chooserdialogue Ensure that no z-index is set explicitly on the element Ensure that a z-index is set from the style sheet
    • Affected Branches:
      MOODLE_25_STABLE
    • Fixed Branches:
      MOODLE_25_STABLE
    • Pull Master Branch:
    • Rank:
      49986

      Description

      As illustrated in attached screenshot using clean theme on http://qa.moodle.net. I experienced the same problem with Leatherbound, so assume it exists with most/all themes.

        Issue Links

          Activity

          Hide
          Andrew Nicols added a comment -

          It looks like when the file was moved to Shifter, this change was lost. That'll be my fault. They were integrated on the same day.

          Re-instating that change

          Show
          Andrew Nicols added a comment - It looks like when the file was moved to Shifter, this change was lost. That'll be my fault. They were integrated on the same day. Re-instating that change
          Hide
          Dan Poltawski added a comment -

          The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

          TIA and ciao

          Show
          Dan Poltawski added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
          Hide
          Sam Hemelryk added a comment -

          Thanks for diagnosing that and getting the fix up Andrew. Its been integrated now.

          Show
          Sam Hemelryk added a comment - Thanks for diagnosing that and getting the fix up Andrew. Its been integrated now.
          Hide
          Rossiani Wijaya added a comment -

          Hi Andrew,

          While testing this I noticed the help popup still displayed within the drag and drop area (similar to the screenshot image)

          I tested this issue by adding scorm activity to the course and select the help icon for the package file. Theme 'clean' is used for this.

          Increasing the z-index value for .moodle-dialog fixed the display.

          Could you confirm on this please?

          Thanks
          Rosie

          Show
          Rossiani Wijaya added a comment - Hi Andrew, While testing this I noticed the help popup still displayed within the drag and drop area (similar to the screenshot image) I tested this issue by adding scorm activity to the course and select the help icon for the package file. Theme 'clean' is used for this. Increasing the z-index value for .moodle-dialog fixed the display. Could you confirm on this please? Thanks Rosie
          Hide
          Andrew Nicols added a comment -

          Hi Rosie,

          Yup - it looks like this is missing from the bootstrap theme. I've pushed a patch on MDL-39355-m-2 - http://github.com/andrewnicols/moodle/commit/MDL-39355-m-2

          Show
          Andrew Nicols added a comment - Hi Rosie, Yup - it looks like this is missing from the bootstrap theme. I've pushed a patch on MDL-39355 -m-2 - http://github.com/andrewnicols/moodle/commit/MDL-39355-m-2
          Hide
          Rossiani Wijaya added a comment -

          Hi Andrew,

          Thank you for the confirmation.

          I'm failing this test so the new patch can get integrated.

          Show
          Rossiani Wijaya added a comment - Hi Andrew, Thank you for the confirmation. I'm failing this test so the new patch can get integrated.
          Hide
          Sam Hemelryk added a comment -

          Good spotting thank you Rosie!

          I've integrated the fix from Andrew now and this is back up for testing.

          Show
          Sam Hemelryk added a comment - Good spotting thank you Rosie! I've integrated the fix from Andrew now and this is back up for testing.
          Hide
          Rossiani Wijaya added a comment -

          Hi Andrew,

          Sorry for failing this test again.

          The issue still remain in 'clean' theme.

          Test failed

          Show
          Rossiani Wijaya added a comment - Hi Andrew, Sorry for failing this test again. The issue still remain in 'clean' theme. Test failed
          Hide
          Andrew Nicols added a comment -

          I've pushed another commit. I must have accidentally unstaged the commit before I pushed last time (I did test it successfully first).

          Pushed again to MDL-39355-m-2.

          Andrew

          Show
          Andrew Nicols added a comment - I've pushed another commit. I must have accidentally unstaged the commit before I pushed last time (I did test it successfully first). Pushed again to MDL-39355 -m-2. Andrew
          Hide
          Damyon Wiese added a comment -

          Thanks Andrew,

          I have pushed the extra commit now - I'll reset this test.

          Show
          Damyon Wiese added a comment - Thanks Andrew, I have pushed the extra commit now - I'll reset this test.
          Hide
          Rossiani Wijaya added a comment -

          Thanks Andrew and Damyon.

          This is working as expected.

          Test passed.

          Show
          Rossiani Wijaya added a comment - Thanks Andrew and Damyon. This is working as expected. Test passed.
          Hide
          Dan Poltawski added a comment -

          Thanks! You're changes are now spread to the world through this git and our source control repositories.

          No time to rest though, we've got days to make 2.5 the best yet!

          ciao

          Show
          Dan Poltawski added a comment - Thanks! You're changes are now spread to the world through this git and our source control repositories. No time to rest though, we've got days to make 2.5 the best yet! ciao

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: