Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Blocker Blocker
    • Resolution: Fixed
    • Affects Version/s: 2.5
    • Fix Version/s: 2.5
    • Component/s: Administration
    • Labels:
    • Testing Instructions:
      Hide
      1. Enable Networking in advanced features
      2. Site admin > Networking > Manage Peers. Make sure there's no setType() error.
      3. Site admin > Networking > Peers > All hosts, select 'Services' tab. Make sure there's no setType() error.
      4. Site admin > Networking > Peers > All hosts, select 'Profile fields' tab. Make sure there's no setType() error.
      Show
      Enable Networking in advanced features Site admin > Networking > Manage Peers. Make sure there's no setType() error. Site admin > Networking > Peers > All hosts, select 'Services' tab. Make sure there's no setType() error. Site admin > Networking > Peers > All hosts, select 'Profile fields' tab. Make sure there's no setType() error.
    • Affected Branches:
      MOODLE_25_STABLE
    • Fixed Branches:
      MOODLE_25_STABLE
    • Pull from Repository:
    • Pull Master Branch:

      Description

      Did you remember to call setType() for 'last_connect_time'? Defaulting to PARAM_RAW cleaning.

      line 1289 of /lib/formslib.php: call to debugging()
      line 281 of /lib/formslib.php: call to moodleform->detectMissingSetType()
      line 202 of /lib/formslib.php: call to moodleform->_process_submission()
      line 152 of /admin/mnet/peers.php: call to moodleform->moodleform()

      Did you remember to call setType() for 'id'? Defaulting to PARAM_RAW cleaning.

      line 1289 of /lib/formslib.php: call to debugging()
      line 281 of /lib/formslib.php: call to moodleform->detectMissingSetType()
      line 202 of /lib/formslib.php: call to moodleform->_process_submission()
      line 152 of /admin/mnet/peers.php: call to moodleform->moodleform()

      Did you remember to call setType() for 'applicationid'? Defaulting to PARAM_RAW cleaning.

      line 1289 of /lib/formslib.php: call to debugging()
      line 281 of /lib/formslib.php: call to moodleform->detectMissingSetType()
      line 202 of /lib/formslib.php: call to moodleform->_process_submission()
      line 152 of /admin/mnet/peers.php: call to moodleform->moodleform()

      Did you remember to call setType() for 'oldpublickey'? Defaulting to PARAM_RAW cleaning.

      line 1289 of /lib/formslib.php: call to debugging()
      line 281 of /lib/formslib.php: call to moodleform->detectMissingSetType()
      line 202 of /lib/formslib.php: call to moodleform->_process_submission()
      line 152 of /admin/mnet/peers.php: call to moodleform->moodleform()

      Did you remember to call setType() for 'deleted'? Defaulting to PARAM_RAW cleaning.

      line 1289 of /lib/formslib.php: call to debugging()
      line 281 of /lib/formslib.php: call to moodleform->detectMissingSetType()
      line 202 of /lib/formslib.php: call to moodleform->_process_submission()
      line 152 of /admin/mnet/peers.php: call to moodleform->moodleform()

        Gliffy Diagrams

          Issue Links

            Activity

            Hide
            Mark Nelson added a comment -

            Hi Rosie,

            Looks great, nice work.

            One trivial thing, you are missing a full-stop after the comment "// Temporary fixed until MDL-38885 gets integrated" - also it should be 'fix', not 'fixed'.

            Show
            Mark Nelson added a comment - Hi Rosie, Looks great, nice work. One trivial thing, you are missing a full-stop after the comment "// Temporary fixed until MDL-38885 gets integrated" - also it should be 'fix', not 'fixed'.
            Hide
            Rossiani Wijaya added a comment -

            Thanks Mark for reviewing.

            Updated the patch according to your suggestion.

            Submitting for integration review.

            Show
            Rossiani Wijaya added a comment - Thanks Mark for reviewing. Updated the patch according to your suggestion. Submitting for integration review.
            Hide
            Damyon Wiese added a comment -

            Thanks Rosie, looks good. When MDL-38885 is integrated, this will need updating (but so will alot of other forms).

            Integrated to master.

            Show
            Damyon Wiese added a comment - Thanks Rosie, looks good. When MDL-38885 is integrated, this will need updating (but so will alot of other forms). Integrated to master.
            Hide
            Damyon Wiese added a comment -

            Tested in integration - all passed on master.

            Show
            Damyon Wiese added a comment - Tested in integration - all passed on master.
            Hide
            Rossiani Wijaya added a comment -

            Thanks Damyon,

            Yes, I have created MDL-39370 to fix the temp fix issue. Will add link to it.

            Show
            Rossiani Wijaya added a comment - Thanks Damyon, Yes, I have created MDL-39370 to fix the temp fix issue. Will add link to it.
            Hide
            Damyon Wiese added a comment -

            This issue is fixed - there is one more blocker for the qatest. Removing the mdlqa from this issue (when the other is fixed we can reset the test).

            Show
            Damyon Wiese added a comment - This issue is fixed - there is one more blocker for the qatest. Removing the mdlqa from this issue (when the other is fixed we can reset the test).
            Hide
            Dan Poltawski added a comment -

            Thanks! You're changes are now spread to the world through this git and our source control repositories.

            No time to rest though, we've got days to make 2.5 the best yet!

            ciao

            Show
            Dan Poltawski added a comment - Thanks! You're changes are now spread to the world through this git and our source control repositories. No time to rest though, we've got days to make 2.5 the best yet! ciao

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: