Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Critical Critical
    • Resolution: Fixed
    • Affects Version/s: 2.5
    • Fix Version/s: 2.5
    • Component/s: Themes
    • Labels:
    • Rank:
      49997

      Description

      Comments and docs still contain "Simple":
      >> grep -r imple clean
      clean/config.php: * Moodle's Simple theme, an example of how to make a Bootstrap theme
      clean/layout/general.php: * Moodle's Simple theme, an example of how to make a Bootstrap theme
      clean/layout/general.php: * @package theme_simple
      clean/lib.php: * Moodle's Simple theme, an example of how to make a Bootstrap theme
      clean/settings.php: * Moodle's Simple theme, an example of how to make a Bootstrap theme
      clean/style/custom.css:/* Simple Custom CSS
      clean/version.php: * Moodle's Simple theme, an example of how to make a Bootstrap theme

        Issue Links

          Activity

          Hide
          Mary Evans added a comment -

          I have changed this to critical because this require 'bootstrapbase' to work.

          Show
          Mary Evans added a comment - I have changed this to critical because this require 'bootstrapbase' to work.
          Hide
          Dan Poltawski added a comment -

          The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

          TIA and ciao

          Show
          Dan Poltawski added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
          Hide
          Mary Evans added a comment -

          REBASED - cheers

          Show
          Mary Evans added a comment - REBASED - cheers
          Hide
          Sam Hemelryk added a comment -

          Thanks Mary - this has been integrated now.

          Show
          Sam Hemelryk added a comment - Thanks Mary - this has been integrated now.
          Hide
          Ankit Agarwal added a comment -

          Tested a few random things in the clean theme. All seems good.
          Passing.

          Show
          Ankit Agarwal added a comment - Tested a few random things in the clean theme. All seems good. Passing.
          Hide
          Martin Dougiamas added a comment -

          Hmm, these are bad testing instructions. Did you read the bug, Ankit?

          I can still see this:

          style/custom.css:/* Simple Custom CSS

          but it's probably not enough to stop integration. Would be good if an integrator could just fix it quickly though.

          Show
          Martin Dougiamas added a comment - Hmm, these are bad testing instructions. Did you read the bug, Ankit? I can still see this: style/custom.css:/* Simple Custom CSS but it's probably not enough to stop integration. Would be good if an integrator could just fix it quickly though.
          Hide
          Ankit Agarwal added a comment -

          Ah missed that, I assumed this was just regression testing.

          Show
          Ankit Agarwal added a comment - Ah missed that, I assumed this was just regression testing.
          Hide
          Dan Poltawski added a comment -

          Thanks! You're changes are now spread to the world through this git and our source control repositories.

          No time to rest though, we've got days to make 2.5 the best yet!

          ciao

          Show
          Dan Poltawski added a comment - Thanks! You're changes are now spread to the world through this git and our source control repositories. No time to rest though, we've got days to make 2.5 the best yet! ciao
          Hide
          Mary Evans added a comment -

          This hasn't been fixed at all.

          Show
          Mary Evans added a comment - This hasn't been fixed at all.
          Hide
          Mary Evans added a comment -

          I've just added the last part of this fix.

          Show
          Mary Evans added a comment - I've just added the last part of this fix.
          Hide
          Sam Hemelryk added a comment -

          Hi Mary - I've integrated the last tid-bit now.

          If this happens another time please create a new issue instead of opening reopening the issue from closed. I know it can be bit of a pain but it keeps things much cleaner.

          Many thanks
          Sam

          Show
          Sam Hemelryk added a comment - Hi Mary - I've integrated the last tid-bit now. If this happens another time please create a new issue instead of opening reopening the issue from closed. I know it can be bit of a pain but it keeps things much cleaner. Many thanks Sam
          Hide
          Sam Hemelryk added a comment -

          Tested and passed during integration review.

          Show
          Sam Hemelryk added a comment - Tested and passed during integration review.
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Did you think this day was not going to arrive ever?

          Your patience has been rewarded, yay, sent upstream, thanks!

          Closing...ciao

          Show
          Eloy Lafuente (stronk7) added a comment - Did you think this day was not going to arrive ever? Your patience has been rewarded, yay, sent upstream, thanks! Closing...ciao

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: