Moodle
  1. Moodle
  2. MDL-39365

get_scorm_question_count() returns one less than actual

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Blocker Blocker
    • Resolution: Fixed
    • Affects Version/s: 2.4.3
    • Fix Version/s: 2.3.7, 2.4.4
    • Component/s: SCORM
    • Labels:
    • Rank:
      49998

      Description

      get_scorm_question_count always returns one less than the actual number of questions

        Issue Links

          Activity

          Hide
          Adrian Greeve added a comment -

          Hello,

          I don't see anything wrong with this patch. The git message is fine, testing instructions are taken care of, and it fixes the issue.

          Send to integration!

          Show
          Adrian Greeve added a comment - Hello, I don't see anything wrong with this patch. The git message is fine, testing instructions are taken care of, and it fixes the issue. Send to integration!
          Hide
          Ankit Agarwal added a comment -

          Thanks Adrian, sending for integration.

          Show
          Ankit Agarwal added a comment - Thanks Adrian, sending for integration.
          Hide
          Dan Poltawski added a comment -

          Can we get a +1 from Dan Marsden?

          Show
          Dan Poltawski added a comment - Can we get a +1 from Dan Marsden ?
          Hide
          Sam Hemelryk added a comment -

          Thanks Ankit, this has been integrated now.

          Show
          Sam Hemelryk added a comment - Thanks Ankit, this has been integrated now.
          Hide
          Frédéric Massart added a comment -

          Passing, thanks!

          Show
          Frédéric Massart added a comment - Passing, thanks!
          Hide
          Dan Marsden added a comment -

          sorry - spending time with family this week after spending time at NZ moot last week.

          +1 (bit late)

          Show
          Dan Marsden added a comment - sorry - spending time with family this week after spending time at NZ moot last week. +1 (bit late)
          Hide
          Dan Poltawski added a comment -

          Thanks! You're changes are now spread to the world through this git and our source control repositories.

          No time to rest though, we've got days to make 2.5 the best yet!

          ciao

          Show
          Dan Poltawski added a comment - Thanks! You're changes are now spread to the world through this git and our source control repositories. No time to rest though, we've got days to make 2.5 the best yet! ciao

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: