Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-39376

performance problem while calling admin setting page in case of large amount of categories

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide
      1. Enable the plugins enrol_ldap and enrol_database
      2. Visit some admin pages, and notice how quickly they load
      3. Generate a lot of categories (the attached script may help)
      4. Visit some admin pages, and notice that they load at the same speed as before (with the exception of Manage courses)
      5. Visit the ldap enrol plugin settings page
        • Make sure you can select a category in enrol_ldap | category
        • Make sure the default category is the first one
      6. Visit the database enrol plugin settings page
        • Make sure you can select a category in enrol_database | defaultcategory
        • Make sure the default category is the one with ID 1
      Show
      Enable the plugins enrol_ldap and enrol_database Visit some admin pages, and notice how quickly they load Generate a lot of categories (the attached script may help) Visit some admin pages, and notice that they load at the same speed as before (with the exception of Manage courses ) Visit the ldap enrol plugin settings page Make sure you can select a category in enrol_ldap | category Make sure the default category is the first one Visit the database enrol plugin settings page Make sure you can select a category in enrol_database | defaultcategory Make sure the default category is the one with ID 1
    • Affected Branches:
      MOODLE_24_STABLE
    • Fixed Branches:
      MOODLE_27_STABLE, MOODLE_28_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-39376-master
    • Sprint:
      BACKEND Sprint 18

      Description

      Hello,

      while customizing our plateform on moodle 2.4.x, We,ve got big performance troubles with admin settings pages due to the following facts :

      while calling admin/settings.php for a given section code is loading all setting tree threw admin_get_root (line 18), so pass to all settings pages of all plugins
      in two of this settings page, the method make_category_list is called one or more time

      since we have a big amount of categories and a structuer with parents (depth 3), loading a setting page became very too long

      My question , is it absolutely obvious to read all setting tree, can't we load a partial tree?

      Thank you

      Céline

        Attachments

          Issue Links

            Activity

              People

              • Votes:
                1 Vote for this issue
                Watchers:
                8 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  13/Nov/14