Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-39377

Increase padding for grouped field labels in question types

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.5
    • Fix Version/s: 2.5
    • Component/s: Questions
    • Labels:
    • Testing Instructions:
      Hide

      Open a question type with fields grouped onto one line e.g. calculated, calculated multi, calculated simple and numerical.
      The label preceding each element should have a small space to it's right so it is still related to the element to its right but not too close. In css it should be .3em away.

      Show
      Open a question type with fields grouped onto one line e.g. calculated, calculated multi, calculated simple and numerical. The label preceding each element should have a small space to it's right so it is still related to the element to its right but not too close. In css it should be .3em away.
    • Affected Branches:
      MOODLE_25_STABLE
    • Fixed Branches:
      MOODLE_25_STABLE
    • Pull from Repository:
      git@github.com:colchambers/moodle.git
    • Pull Master Branch:

      Description

      Where question type fields are now grouped onto the same line. Their labels are too close to the elements they refer to. They require more padding. This affects several question types including calculated, calculated multi, calculated simple and numerical.

        Gliffy Diagrams

          Attachments

            Activity

            Hide
            colchambers Colin Chambers added a comment -

            Added a padding right and refactored the command to one line to fit the rest of the file.

            This fix is particularly required for the OU drag and drop question type forms. The answer fields start to get lost behind the elements they refer to.

            Show
            colchambers Colin Chambers added a comment - Added a padding right and refactored the command to one line to fit the rest of the file. This fix is particularly required for the OU drag and drop question type forms. The answer fields start to get lost behind the elements they refer to.
            Hide
            timhunt Tim Hunt added a comment -

            +1 from me/ Submitting for integration.

            Show
            timhunt Tim Hunt added a comment - +1 from me/ Submitting for integration.
            Hide
            samhemelryk Sam Hemelryk added a comment -

            Thanks Colin, this has been integrated now.

            Show
            samhemelryk Sam Hemelryk added a comment - Thanks Colin, this has been integrated now.
            Hide
            abgreeve Adrian Greeve added a comment -

            Tested on stable and integration. There is now padding between the labels and elements that they relate to on the editing page.
            Test passed.

            Show
            abgreeve Adrian Greeve added a comment - Tested on stable and integration. There is now padding between the labels and elements that they relate to on the editing page. Test passed.
            Hide
            poltawski Dan Poltawski added a comment -

            Thanks! You're changes are now spread to the world through this git and our source control repositories.

            No time to rest though, we've got days to make 2.5 the best yet!

            ciao

            Show
            poltawski Dan Poltawski added a comment - Thanks! You're changes are now spread to the world through this git and our source control repositories. No time to rest though, we've got days to make 2.5 the best yet! ciao

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  14/May/13