Details

    • Type: Sub-task
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.5
    • Fix Version/s: 2.5
    • Component/s: HTML and CSS, Libraries
    • Labels:
    • Testing Instructions:
      Hide

      Having the totara elementlibrary installed helps as it has a page which excercises the tab render in a variety of ways.

      If not then visit anything with tabs, Wiki, Lesson, Quiz editing, Glossary.

      Check

      a) the HTML produced is in line with that documented by Bootstrap:

      http://twitter.github.io/bootstrap/components.html#navs

      b) the visual appearance is consistent with above, and doesn't clash with surroundings in Moodle Bootstrapbase theme

      c) tabs with a second level should render as one row above the other

      d) the tabs should collapse into what Bootstrap calls stackable tabs at screen widths less than 480px

      Show
      Having the totara elementlibrary installed helps as it has a page which excercises the tab render in a variety of ways. If not then visit anything with tabs, Wiki, Lesson, Quiz editing, Glossary. Check a) the HTML produced is in line with that documented by Bootstrap: http://twitter.github.io/bootstrap/components.html#navs b) the visual appearance is consistent with above, and doesn't clash with surroundings in Moodle Bootstrapbase theme c) tabs with a second level should render as one row above the other d) the tabs should collapse into what Bootstrap calls stackable tabs at screen widths less than 480px
    • Affected Branches:
      MOODLE_25_STABLE
    • Fixed Branches:
      MOODLE_25_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-39388-master

      Description

      The code for generating tabs got moved to a renderer. This is a renderer for the Bootstrapbase theme that generates the standard Bootstrap HTML for tabs as documented here:

      http://twitter.github.io/bootstrap/components.html#navs

      As a result we can also delete some CSS that was being generated to make Bootstrap's standard tab HTML look superficially like Bootstrap.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              marina Marina Glancy
              Reporter:
              bawjaws David Scotson
              Peer reviewer:
              Marina Glancy
              Integrator:
              Damyon Wiese
              Tester:
              Mark Nelson
              Participants:
              Component watchers:
              Amy Groshek, David Scotson, Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Sara Arjona (@sarjona), Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Sara Arjona (@sarjona)
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                14/May/13