Details

    • Sub-task
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • 2.5
    • 2.5
    • HTML and CSS, Libraries
    • MOODLE_25_STABLE
    • MOODLE_25_STABLE
    • MDL-39388-master
    • Hide

      Having the totara elementlibrary installed helps as it has a page which excercises the tab render in a variety of ways.

      If not then visit anything with tabs, Wiki, Lesson, Quiz editing, Glossary.

      Check

      a) the HTML produced is in line with that documented by Bootstrap:

      http://twitter.github.io/bootstrap/components.html#navs

      b) the visual appearance is consistent with above, and doesn't clash with surroundings in Moodle Bootstrapbase theme

      c) tabs with a second level should render as one row above the other

      d) the tabs should collapse into what Bootstrap calls stackable tabs at screen widths less than 480px

      Show
      Having the totara elementlibrary installed helps as it has a page which excercises the tab render in a variety of ways. If not then visit anything with tabs, Wiki, Lesson, Quiz editing, Glossary. Check a) the HTML produced is in line with that documented by Bootstrap: http://twitter.github.io/bootstrap/components.html#navs b) the visual appearance is consistent with above, and doesn't clash with surroundings in Moodle Bootstrapbase theme c) tabs with a second level should render as one row above the other d) the tabs should collapse into what Bootstrap calls stackable tabs at screen widths less than 480px

    Description

      The code for generating tabs got moved to a renderer. This is a renderer for the Bootstrapbase theme that generates the standard Bootstrap HTML for tabs as documented here:

      http://twitter.github.io/bootstrap/components.html#navs

      As a result we can also delete some CSS that was being generated to make Bootstrap's standard tab HTML look superficially like Bootstrap.

      Attachments

        Issue Links

          Activity

            People

              marina Marina Glancy
              bawjaws David Scotson
              Marina Glancy Marina Glancy
              Damyon Wiese Damyon Wiese
              Mark Nelson Mark Nelson
              Amy Groshek, David Scotson, David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo, David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                14/May/13