Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-39404

Update question/format files to match codechecker standards

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.5
    • Fix Version/s: 2.6
    • Component/s: Questions
    • Labels:
    • Testing Instructions:
      Hide

      Testing questions import

      Import the various sample files that are in question/format/xxx/tests/fixtures and verify that no warning or error is displayed during import with debugging set to DEVELOPER level.
      Some remarks:

      • the learnwise-example.xml sample file for learnwise format is not in tests/fixtures subdir (maybe we should fix that for consistency some day ?)
      • all sample files for Moodle xml format contains images and sounds, so they will produce "Before calling format_text(), the content must be processed with file_rewrite_pluginfile_urls()" warning, this is unrelated to this issue and MDL-39507 will take care of that problem, so ignore it for now.
      • there is no sample file for xhml format because this is an export only format

      Testing questions export

      For the formats that support export (Gift, Moodle XML, XHML) verify that you can export the questions in a category and that the exported file looks correct (for Gift and Moodle XML an easy way to do that is to try to re-import the file, and for XHML that the file only contains valid HML).

      Show
      Testing questions import Import the various sample files that are in question/format/xxx/tests/fixtures and verify that no warning or error is displayed during import with debugging set to DEVELOPER level. Some remarks: the learnwise-example.xml sample file for learnwise format is not in tests/fixtures subdir (maybe we should fix that for consistency some day ?) all sample files for Moodle xml format contains images and sounds, so they will produce "Before calling format_text(), the content must be processed with file_rewrite_pluginfile_urls()" warning, this is unrelated to this issue and MDL-39507 will take care of that problem, so ignore it for now. there is no sample file for xhml format because this is an export only format Testing questions export For the formats that support export (Gift, Moodle XML, XHML) verify that you can export the questions in a category and that the exported file looks correct (for Gift and Moodle XML an easy way to do that is to try to re-import the file, and for XHML that the file only contains valid HML).
    • Affected Branches:
      MOODLE_25_STABLE
    • Fixed Branches:
      MOODLE_26_STABLE
    • Pull Master Branch:

      Description

      Maybe this is not the right timing to do that just before a release but I failed to find some time to do it sooner.
      After Pierre Pichet's good work in MDL-31680 to clean a lot of style issues in question/type, I think I need to do the same for question/format.
      Fortunately a lot of files there are already compliant, the most offending one is gift/format.php and I have already done part of the job while working on the contributed giftmedia format so I just need to port these changes and fix the remaining.
      If such a change seems to risky for 2.5, jst hold it for 2.5.1

        Gliffy Diagrams

          Attachments

            Activity

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  18/Nov/13