Details

    • Type: New Feature New Feature
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.9
    • Fix Version/s: 1.9, 2.0
    • Component/s: Forum
    • Labels:
      None
    • Environment:
      All
    • Database:
      Any
    • Affected Branches:
      MOODLE_19_STABLE
    • Fixed Branches:
      MOODLE_19_STABLE, MOODLE_20_STABLE
    • Rank:
      37138

      Description

      Currently if forum posts are numerically rated, the forum grade is the average score of all a student's rated posts. For example, if a forum is worth 10 pts and a student post is rated at 9 and then the same student posts again and it is rated at 3, the student grade is 6 – students can lose points for additional posting.

      An optional Additive option would allow the score to be the sum of all the student's rated posts, limited to the max value set for the forum (recalc if forum scale is changed to different max value).

      This would also allow for rating each post 1 for those who simply want a count, though Count could also be an addtional rating type and would be automatic if selected, without putting anything in (or altering) the rating field.

      Yet another possible rating type would be Highest (to take an analogy from quiz scoring).

      Ideally none of these would affect the individual ratings, just the score that is sent to the gradebook.

        Issue Links

          Activity

          Hide
          Anthony Borrow added a comment -

          I would like to see greater flexibility with the scoring of a forum such that a teacher could select whether the grading of the forum would be based on count, max, min, or average. I would think this would be fairly simple to do and would greatly enhance the flexibility of how forums can be used in a classroom setting. I like to use a maximum score because it encourages quality of post rather than mere quantity. Is there any chance that this might work its way into 1.7?

          Show
          Anthony Borrow added a comment - I would like to see greater flexibility with the scoring of a forum such that a teacher could select whether the grading of the forum would be based on count, max, min, or average. I would think this would be fairly simple to do and would greatly enhance the flexibility of how forums can be used in a classroom setting. I like to use a maximum score because it encourages quality of post rather than mere quantity. Is there any chance that this might work its way into 1.7?
          Hide
          Martin Dougiamas added a comment -

          I've always had trouble with this concept.

          Is ten posts worth 1 point each equal, educationally, to one post worth ten points? Does this promote quantity over quality?

          Show
          Martin Dougiamas added a comment - I've always had trouble with this concept. Is ten posts worth 1 point each equal, educationally, to one post worth ten points? Does this promote quantity over quality?
          Hide
          Anthony Borrow added a comment -

          I prefer to have quality to quantity educationally speaking; however, I can see where different educators might use the forums in different ways. It seems pretty simple to me in concept to allow a grading option of max, min, avg, sum, and count and just do a case where it reports the grade where it is currently defaulting to average. I think this would give the teacher the flexibility to setup each forum in the way that is most beneficial. I've not had a chance to work on implementing it myself yet but wanted to throw the idea out.

          Show
          Anthony Borrow added a comment - I prefer to have quality to quantity educationally speaking; however, I can see where different educators might use the forums in different ways. It seems pretty simple to me in concept to allow a grading option of max, min, avg, sum, and count and just do a case where it reports the grade where it is currently defaulting to average. I think this would give the teacher the flexibility to setup each forum in the way that is most beneficial. I've not had a chance to work on implementing it myself yet but wanted to throw the idea out.
          Hide
          Kaaren ORourke added a comment -

          I agree. I am using graded forums and I am trying to encourage my students to thoughtfully respond to each other's comments. However, they are penalized for additional posting as I don't want to award full point value to a follow post as I would an initial post.

          Show
          Kaaren ORourke added a comment - I agree. I am using graded forums and I am trying to encourage my students to thoughtfully respond to each other's comments. However, they are penalized for additional posting as I don't want to award full point value to a follow post as I would an initial post.
          Hide
          Martin Dougiamas added a comment -

          Assigning to me temporarily because Vy-Shane no longer works for Moodle HQ.

          Show
          Martin Dougiamas added a comment - Assigning to me temporarily because Vy-Shane no longer works for Moodle HQ.
          Hide
          Chardelle Busch added a comment -
          Show
          Chardelle Busch added a comment - Please see this discussion: http://moodle.org/mod/forum/discuss.php?d=66008#297750
          Hide
          Martin Dougiamas added a comment -

          You can easily do this as part of the gradebook revamp in 1.9

          It's basically just a new boolean in the forum table to choose the aggregate method for final grades (sum, mean, median).

          Show
          Martin Dougiamas added a comment - You can easily do this as part of the gradebook revamp in 1.9 It's basically just a new boolean in the forum table to choose the aggregate method for final grades (sum, mean, median).
          Hide
          Martin Dougiamas added a comment -

          ...and max, min and count

          Show
          Martin Dougiamas added a comment - ...and max, min and count
          Hide
          Barry Bookout added a comment -

          Our teachers would like to be able to rate one required primary posting to a forum as, say, up to 10 points, and two required replies as up to 5 points each, up to a maximum of 20 points, for example. The sum option would make that possible, and doesn't necessarily replace quality with quantity. It does require the teacher to remember that she has graded one posting and two replies for a given student, but at least it would be possible to grade this way. Being able to specify minimum required number of original posts and replies in a forum would be a nice feature, but is probably substantially more complicated to implement.

          Show
          Barry Bookout added a comment - Our teachers would like to be able to rate one required primary posting to a forum as, say, up to 10 points, and two required replies as up to 5 points each, up to a maximum of 20 points, for example. The sum option would make that possible, and doesn't necessarily replace quality with quantity. It does require the teacher to remember that she has graded one posting and two replies for a given student, but at least it would be possible to grade this way. Being able to specify minimum required number of original posts and replies in a forum would be a nice feature, but is probably substantially more complicated to implement.
          Hide
          D.I. von Briesen added a comment -

          Even though the gradebook may accomodate this, it seems that if this option exists in the quizzes, it would make sense and be more consistent to include it in the forums. I've also struggled a lot with the whole issue of how to deal with multiple submissions, and averaging would help a bit with this, as would min/max. There's no simple solution for every permutation of desired grading, but there are some obvious options.

          Show
          D.I. von Briesen added a comment - Even though the gradebook may accomodate this, it seems that if this option exists in the quizzes, it would make sense and be more consistent to include it in the forums. I've also struggled a lot with the whole issue of how to deal with multiple submissions, and averaging would help a bit with this, as would min/max. There's no simple solution for every permutation of desired grading, but there are some obvious options.
          Hide
          Anthony Borrow added a comment - - edited

          Martin/Skodak,

          I am glad that the new gradebook will allow for this to be handled. I agree with D.I. that it would be nice if there were an option in the forum (when it is being created/updated) that the gradebook could check if it exists (i.e. accumulation=average, max, etc.) then use that accumulation in the gradebook. But then we get into a which option should override which. I'm not sure how the quiz module handles it. I suspect that if the forum one was used it could be seen as force forum aggregation setting to gradebook where one of the options is none - use gradebook aggregation.

          A particular case that may be worth looking at is what happens when the ratings are 1-10 and a user gets 3 ratings of 10 by the teacher. The teacher then uses the sum aggregation. Is there a check to ensure that the aggregation does not exceed to the forum's max rating?

          Peace - Anthony

          p.s. - I'm of the opinion that since the functionality of this request can be achieved in Moodle 1.9 that it be marked as resolved and fixed for Moodle 1.9.

          Show
          Anthony Borrow added a comment - - edited Martin/Skodak, I am glad that the new gradebook will allow for this to be handled. I agree with D.I. that it would be nice if there were an option in the forum (when it is being created/updated) that the gradebook could check if it exists (i.e. accumulation=average, max, etc.) then use that accumulation in the gradebook. But then we get into a which option should override which. I'm not sure how the quiz module handles it. I suspect that if the forum one was used it could be seen as force forum aggregation setting to gradebook where one of the options is none - use gradebook aggregation. A particular case that may be worth looking at is what happens when the ratings are 1-10 and a user gets 3 ratings of 10 by the teacher. The teacher then uses the sum aggregation. Is there a check to ensure that the aggregation does not exceed to the forum's max rating? Peace - Anthony p.s. - I'm of the opinion that since the functionality of this request can be achieved in Moodle 1.9 that it be marked as resolved and fixed for Moodle 1.9.
          Hide
          D.I. von Briesen added a comment -

          For my part, I don't feel like a direct mod of the gradebook is an adequate solution to this- although I'm not familar enough with the new gradebook to understand how it works. When you grade you want to see the stuff in front of you - you're looking at the assignment results, and giving grades. I only go to the gradebook to try and deduce what students are missing...

          But regardless, anything that would allow the averaging thing to be resolved (since when my TA gives partial credit I'm unable to give it full credit later - it averages) so that the max score counts is a big help! Sounds like the gradebook will do that.

          FWIW I don't think this is trivial (as marked here) at all - since it's caused us a bit of grief, and I have to modify the way we grade to deal with it.
          di

          Show
          D.I. von Briesen added a comment - For my part, I don't feel like a direct mod of the gradebook is an adequate solution to this- although I'm not familar enough with the new gradebook to understand how it works. When you grade you want to see the stuff in front of you - you're looking at the assignment results, and giving grades. I only go to the gradebook to try and deduce what students are missing... But regardless, anything that would allow the averaging thing to be resolved (since when my TA gives partial credit I'm unable to give it full credit later - it averages) so that the max score counts is a big help! Sounds like the gradebook will do that. FWIW I don't think this is trivial (as marked here) at all - since it's caused us a bit of grief, and I have to modify the way we grade to deal with it. di
          Hide
          Anthony Borrow added a comment -

          di - When you are speaking of averages you are talking about ratings to a particular post. When I was speaking of averages I was assuming the student had made numerous posts. This raises another issue. Could we have the max grade from a particular post and the average of those max grades from various posts made by a student.

          Just to be clear, an example may help. Let's say I have student A, the beloved T.A., and me the teacher. Student A goes in and makes posts 1, 2, and 3. The T.A. gives post 1 a score of 5 (out of 10), the teacher gives it and 7. On post 2, the ta gives a 1 and the teacher a 3. On post 3, the ta gives an 6 and the teacher a 8.

          So we would want the max from each post. Post 1=7, post 2=3, post 3=8. Now in the gradebook we want the average of those 3 posts which would be (7+3+8)/3=6.

          Should there be an option to handle max, average, min, etc. within posts for the case when there are multiple teachers rating the post? Should there be an option to allow student ratings to be used for the grade? I can see this getting more complicated.

          I agree that this is not a trivial issue. I'll bump it up a notch. Peace - Anthony

          Show
          Anthony Borrow added a comment - di - When you are speaking of averages you are talking about ratings to a particular post. When I was speaking of averages I was assuming the student had made numerous posts. This raises another issue. Could we have the max grade from a particular post and the average of those max grades from various posts made by a student. Just to be clear, an example may help. Let's say I have student A, the beloved T.A., and me the teacher. Student A goes in and makes posts 1, 2, and 3. The T.A. gives post 1 a score of 5 (out of 10), the teacher gives it and 7. On post 2, the ta gives a 1 and the teacher a 3. On post 3, the ta gives an 6 and the teacher a 8. So we would want the max from each post. Post 1=7, post 2=3, post 3=8. Now in the gradebook we want the average of those 3 posts which would be (7+3+8)/3=6. Should there be an option to handle max, average, min, etc. within posts for the case when there are multiple teachers rating the post? Should there be an option to allow student ratings to be used for the grade? I can see this getting more complicated. I agree that this is not a trivial issue. I'll bump it up a notch. Peace - Anthony
          Hide
          Anthony Borrow added a comment -

          Actually - considering the popularity of this issue I think it merits being classified as having a major priority. I think the pieces are in place with the new gradebook to help resolve this but it probably needs a bit more attention. Perhaps some improvements could be for Moodle 2.0. One of the tricks will be to keep the user interface simply and clear about what is happening. Peace - Anthony

          Show
          Anthony Borrow added a comment - Actually - considering the popularity of this issue I think it merits being classified as having a major priority. I think the pieces are in place with the new gradebook to help resolve this but it probably needs a bit more attention. Perhaps some improvements could be for Moodle 2.0. One of the tricks will be to keep the user interface simply and clear about what is happening. Peace - Anthony
          Hide
          Anthony Borrow added a comment -

          To keep the language clear I think we should distinguish between:

          1) Post rating grade accumulation: min, max, count, average, sum (up to max grade) [this will calculate the various ratings of a single post for the roles selected for inclusion in the grade]

          a) We should probably distinguish between the ability to select the roles that can rate and then select the roles whose ratings will be included in grade calculations.

          2) Forum grade accumulation: min, max, count, average, sum (up to max grade) [this will calculate the chosen function of all posts by a particular user and could be handled by the gradebook accumulation option as MartinD mentions above]

          a) Should the accumulation method be displayed somewhere within the forum so that the teacher knows how it is being graded?

          I think this would allow for most scenarios and greatly enhance how forums can be used without making things overly confusing. Comments?

          Show
          Anthony Borrow added a comment - To keep the language clear I think we should distinguish between: 1) Post rating grade accumulation: min, max, count, average, sum (up to max grade) [this will calculate the various ratings of a single post for the roles selected for inclusion in the grade] a) We should probably distinguish between the ability to select the roles that can rate and then select the roles whose ratings will be included in grade calculations. 2) Forum grade accumulation: min, max, count, average, sum (up to max grade) [this will calculate the chosen function of all posts by a particular user and could be handled by the gradebook accumulation option as MartinD mentions above] a) Should the accumulation method be displayed somewhere within the forum so that the teacher knows how it is being graded? I think this would allow for most scenarios and greatly enhance how forums can be used without making things overly confusing. Comments?
          Hide
          D.I. von Briesen added a comment -

          Anthony- thanks for your attention.
          I agree that we are referring to two different things- but I think they are worth considering.

          Currently there is only one grading scheme on the forums- anything not graded is null, and anything graded on a single FORUM (regardless of threads or topics) is averaged across all who have given grades. This creates a number of problems, most of which have been alluded to here:

          -if resubmissions are allowed (as in my case) how does a different grader give full score (it can never be full score if the initial grade was low)
          if there is a "post to this, reply to that" option, things are further complicated - you are in effect trying to grade two different things in one forum. The only way out of this that I can conceive of us to differentiate initial posts from replies. While this sounds really sexy, it feels like a low priority at this juncture. It's hard to say though i've not done these kinds of assignments for this very reason- there's no way to grade them easily, and the workarounds are too painful for large numbers of students. Having said that, i'm really liking the idea of differentiating posts from replies the more I think about it!! Lots of interestinng options
          -if there are multiple posts to grade, averaging might make sense, but there's no easy way to differentiate 3 posts from 1 - if you take the max, or the average... the single poster does as well or better than the triple poster. The only way I can see around this is to have a function that counts the posts, or have settings that relate to the number of posts (i.e. instead of "each person posts a single discussion" you have "each person posts (drop down) discussions" and then have scoring options based on that.
          -but back to my original supposition, if we simply duplicated the test options (min, max, average) it would be a HUGE step forward, and make my life a lot easier. In fact, with tests you can specify between 1 and 6 attempts, or unlimited. Why not do the very same with forums? You can post X number of times, and the grade is min, max, or ave.

          As I think about this (sorry) you could work around some of this by an option making posts automatically have zero or something like a 1, so that it would allow the math to do its thing instead of ignoring unrated posts- these low scores could then be adjusted as items are graded.

          Peer grading brings up a whole other set of issues, but again, if we can focus on what people need and use most we may be able to satisfy 80 pct of the needs with 20pct of the effort.

          di

          ps- after all this it's worth noting that the only reason I do use the forums so often for homework is that I like for students to see each other's work- in webpages i want them to see what the others have done (the forum is simply a link to their site) and in programming they might attach a zip of their files. The ONLY reason i don't just use assignments is I want them to be public so classmates can look at each others work.

          We are using 1.54 right now (upgrading to 1.8 over xmas) so I presume roles might address this in some regard - but using roles seems like hardly a fix for design fixes...

          Show
          D.I. von Briesen added a comment - Anthony- thanks for your attention. I agree that we are referring to two different things- but I think they are worth considering. Currently there is only one grading scheme on the forums- anything not graded is null, and anything graded on a single FORUM (regardless of threads or topics) is averaged across all who have given grades. This creates a number of problems, most of which have been alluded to here: -if resubmissions are allowed (as in my case) how does a different grader give full score (it can never be full score if the initial grade was low) if there is a "post to this, reply to that" option, things are further complicated - you are in effect trying to grade two different things in one forum. The only way out of this that I can conceive of us to differentiate initial posts from replies. While this sounds really sexy, it feels like a low priority at this juncture. It's hard to say though i've not done these kinds of assignments for this very reason- there's no way to grade them easily, and the workarounds are too painful for large numbers of students. Having said that, i'm really liking the idea of differentiating posts from replies the more I think about it!! Lots of interestinng options -if there are multiple posts to grade, averaging might make sense, but there's no easy way to differentiate 3 posts from 1 - if you take the max, or the average... the single poster does as well or better than the triple poster. The only way I can see around this is to have a function that counts the posts, or have settings that relate to the number of posts (i.e. instead of "each person posts a single discussion" you have "each person posts (drop down) discussions" and then have scoring options based on that. -but back to my original supposition, if we simply duplicated the test options (min, max, average) it would be a HUGE step forward, and make my life a lot easier. In fact, with tests you can specify between 1 and 6 attempts, or unlimited. Why not do the very same with forums? You can post X number of times, and the grade is min, max, or ave. As I think about this (sorry) you could work around some of this by an option making posts automatically have zero or something like a 1, so that it would allow the math to do its thing instead of ignoring unrated posts- these low scores could then be adjusted as items are graded. Peer grading brings up a whole other set of issues, but again, if we can focus on what people need and use most we may be able to satisfy 80 pct of the needs with 20pct of the effort. di ps- after all this it's worth noting that the only reason I do use the forums so often for homework is that I like for students to see each other's work- in webpages i want them to see what the others have done (the forum is simply a link to their site) and in programming they might attach a zip of their files. The ONLY reason i don't just use assignments is I want them to be public so classmates can look at each others work. We are using 1.54 right now (upgrading to 1.8 over xmas) so I presume roles might address this in some regard - but using roles seems like hardly a fix for design fixes...
          Hide
          Anthony Borrow added a comment -

          di - I'm afraid I was not able to follow your last comment. I agree that there is great potential to make forums even more useful and the grading easier for the teacher. I think what I proposed about making a distinction between the number of ratings on a single post and the number of posts within a discussion could be implemented without an extreme amount of work. I'm not sure I understood the advantage of distinguishing between a reply and a post. From a teacher's perspective I do know that I encouraged quality over quantity. I wanted each student to at least make one substantial post in response to a question that I proposed; however, I wanted them to feel free to make smaller, supportive posts and to respond to their classmates. For that reason, I would use max.; however, I had designed a custom sql script since I had access to the database to put the data into a separate offline assignment. Obviously, this was a lot of work and not available to most teachers. My general sense with changes is that it is best to introduce one change at a time and to take things slowly. At this point, I would be happy to see the flexibility to establish different ways of aggregating ratings on a single post and various posts within a forum discussion. I do think with a little effort we can cover 95% of the cases. I'm all for making the largest gains with the least effort. Basically, I think we are 99% in agreement. I will see if I can play with some of the code and perhaps work on making some type of patch available (however, if one of the developers beats me to it - all the better). Peace - Anthony

          Show
          Anthony Borrow added a comment - di - I'm afraid I was not able to follow your last comment. I agree that there is great potential to make forums even more useful and the grading easier for the teacher. I think what I proposed about making a distinction between the number of ratings on a single post and the number of posts within a discussion could be implemented without an extreme amount of work. I'm not sure I understood the advantage of distinguishing between a reply and a post. From a teacher's perspective I do know that I encouraged quality over quantity. I wanted each student to at least make one substantial post in response to a question that I proposed; however, I wanted them to feel free to make smaller, supportive posts and to respond to their classmates. For that reason, I would use max.; however, I had designed a custom sql script since I had access to the database to put the data into a separate offline assignment. Obviously, this was a lot of work and not available to most teachers. My general sense with changes is that it is best to introduce one change at a time and to take things slowly. At this point, I would be happy to see the flexibility to establish different ways of aggregating ratings on a single post and various posts within a forum discussion. I do think with a little effort we can cover 95% of the cases. I'm all for making the largest gains with the least effort. Basically, I think we are 99% in agreement. I will see if I can play with some of the code and perhaps work on making some type of patch available (however, if one of the developers beats me to it - all the better). Peace - Anthony
          Hide
          D.I. von Briesen added a comment -

          Anthony- sorry to muddy the waters. I think we're in agreement that KISS is critical.

          To clarify my point, although I do not think anyone should worry about it right now, I'll say the following: I think a typical assignment might include a post, and then 2 replies on other students' posts. So if you make the forum worth 20, and give 10 for the initial post, and 5 for each reply, it really makes setting up a grading scheme tricky. Under the current setup (assuming max score) it would average 10, 5 and 5 to give you 6. something. If you upped the max to 20, you'd get the same. You could theoretically curve it to something to compensate, but that's just mucky muck. So the idea would be, suppose you could grade the post the student ORIGINATES one way, and any replies another way. This would account for the scenario you described, but as you've alluded to, might even need two entries in the gradebook!

          So no worries on this angle right now!

          d.i.

          Show
          D.I. von Briesen added a comment - Anthony- sorry to muddy the waters. I think we're in agreement that KISS is critical. To clarify my point, although I do not think anyone should worry about it right now, I'll say the following: I think a typical assignment might include a post, and then 2 replies on other students' posts. So if you make the forum worth 20, and give 10 for the initial post, and 5 for each reply, it really makes setting up a grading scheme tricky. Under the current setup (assuming max score) it would average 10, 5 and 5 to give you 6. something. If you upped the max to 20, you'd get the same. You could theoretically curve it to something to compensate, but that's just mucky muck. So the idea would be, suppose you could grade the post the student ORIGINATES one way, and any replies another way. This would account for the scenario you described, but as you've alluded to, might even need two entries in the gradebook! So no worries on this angle right now! d.i.
          Hide
          Anthony Borrow added a comment - - edited

          I've begun working on a patch that would enable the teacher to select the aggregation type for ratings. Another variable that might be helpful is whether to include all ratings or only those of a teacher. I'm changing the affects version to 1.9 and 2.0. Since the patch involves a change to the database, namely adding an enum field (avg, count, max, min, sum) called assessaggregate to the mdl_forums table it is likely that this will not be considered for inclusion into core until Moodle 2.0. Peace - Anthony

          Show
          Anthony Borrow added a comment - - edited I've begun working on a patch that would enable the teacher to select the aggregation type for ratings. Another variable that might be helpful is whether to include all ratings or only those of a teacher. I'm changing the affects version to 1.9 and 2.0. Since the patch involves a change to the database, namely adding an enum field (avg, count, max, min, sum) called assessaggregate to the mdl_forums table it is likely that this will not be considered for inclusion into core until Moodle 2.0. Peace - Anthony
          Hide
          Anthony Borrow added a comment -

          Petr - This patch does not create the enum (avg, sum, max, min, count) field in mdl_forums named assessaggregate with a default value of avg since I did that manually. The name of the field is to be consistent with the assess fields already in the forum and the aggregate vocabulary associated with the gradebook.

          The patch is meant to demonstrate my basic line of thought for how we could add some increased flexibility to the scoring of forums. It does not seem to be taking advantage of the $user variable but that could simply be because I was logged in as admin rather than teacher. I'll need to go back and do a little more thorough testing.

          I would also like to see where the gradebook items get reset if the assessaggregate field is changed. In other words, changing the forum aggregate type needs to trigger a re-calculation of the scores for each student. It might be helpful to add another variable to include or not include student ratings or only teacher ratings.

          Let me know if you have any questions.

          Peace - Anthony

          Show
          Anthony Borrow added a comment - Petr - This patch does not create the enum (avg, sum, max, min, count) field in mdl_forums named assessaggregate with a default value of avg since I did that manually. The name of the field is to be consistent with the assess fields already in the forum and the aggregate vocabulary associated with the gradebook. The patch is meant to demonstrate my basic line of thought for how we could add some increased flexibility to the scoring of forums. It does not seem to be taking advantage of the $user variable but that could simply be because I was logged in as admin rather than teacher. I'll need to go back and do a little more thorough testing. I would also like to see where the gradebook items get reset if the assessaggregate field is changed. In other words, changing the forum aggregate type needs to trigger a re-calculation of the scores for each student. It might be helpful to add another variable to include or not include student ratings or only teacher ratings. Let me know if you have any questions. Peace - Anthony
          Hide
          Petr Škoda added a comment -

          adding Eloy,
          would it be better to use constants instead of enums?

          Show
          Petr Škoda added a comment - adding Eloy, would it be better to use constants instead of enums?
          Hide
          Anthony Borrow added a comment -

          Petr - Using constants would certainly be more Moodle-esque. To that end, I'll redefine the field as an INT and have created the following constants in /mod/forum/lib.php:

          define ('FORUM_AGGREGATE_AVG', 1);
          define ('FORUM_AGGREGATE_COUNT', 2);
          define ('FORUM_AGGREGATE_MAX', 3);
          define ('FORUM_AGGREGATE_MIN', 4);
          define ('FORUM_AGGREGATE_SUM', 5);

          I'll go back through and make the needed changes and work toward making this a workable patch for 1.9 that could introduced in CONTRIB for greater testing.

          Peace - Anthony

          Show
          Anthony Borrow added a comment - Petr - Using constants would certainly be more Moodle-esque. To that end, I'll redefine the field as an INT and have created the following constants in /mod/forum/lib.php: define ('FORUM_AGGREGATE_AVG', 1); define ('FORUM_AGGREGATE_COUNT', 2); define ('FORUM_AGGREGATE_MAX', 3); define ('FORUM_AGGREGATE_MIN', 4); define ('FORUM_AGGREGATE_SUM', 5); I'll go back through and make the needed changes and work toward making this a workable patch for 1.9 that could introduced in CONTRIB for greater testing. Peace - Anthony
          Hide
          Anthony Borrow added a comment -

          I have deleted and am uploading this revised patch that now utilizes CONSTANTS rather than enum in the mdl_forum for the assessaggregate field. I changed the field type to SMALLINT. I like this idea of an aggregation type as it does open up for the possibility of having other ways of aggregating the scores by simply creating the case scenario and defining the CONSTANTS and language strings. Peace - Anthony

          Show
          Anthony Borrow added a comment - I have deleted and am uploading this revised patch that now utilizes CONSTANTS rather than enum in the mdl_forum for the assessaggregate field. I changed the field type to SMALLINT. I like this idea of an aggregation type as it does open up for the possibility of having other ways of aggregating the scores by simply creating the case scenario and defining the CONSTANTS and language strings. Peace - Anthony
          Hide
          Anthony Borrow added a comment -

          revised patch file using constants rather than previous enum - i.e. mdl_forum assessaggregate field is now defined as a smallint.

          Show
          Anthony Borrow added a comment - revised patch file using constants rather than previous enum - i.e. mdl_forum assessaggregate field is now defined as a smallint.
          Hide
          Eloy Lafuente (stronk7) added a comment - - edited

          Well, from a pure DB criteria, I'd use enums if those values are going to be really stable along the time. If we thing that new values can arrive more or less often, then I really think that some constants are the way (as declared above by Anthony).

          Some quick comments:

          • It requires one new field (to store the aggregate type - couldn't we use the existing "assesed" one, with 0 meaning no grading (like now), 1 meaning average (like now) and new values for the new type of gradings? That will provide automatically backwards compatibility (upgrade, backup & restore...).
          • While looking to the patch, one question arrived to my mind, "what happens when the aggregation type is changed?" Is everything recalculated automatically? It should, IMO (or we can have really out-of-sync data in the gradebook). Note that this question is applicable to all the activities in general. i.e, each activity should declare what fields are related to grades, in order to perform a full refresh of the activity grades in gradebook each time one of those fields are modified.

          Ciao

          Show
          Eloy Lafuente (stronk7) added a comment - - edited Well, from a pure DB criteria, I'd use enums if those values are going to be really stable along the time. If we thing that new values can arrive more or less often, then I really think that some constants are the way (as declared above by Anthony). Some quick comments: It requires one new field (to store the aggregate type - couldn't we use the existing "assesed" one, with 0 meaning no grading (like now), 1 meaning average (like now) and new values for the new type of gradings? That will provide automatically backwards compatibility (upgrade, backup & restore...). While looking to the patch, one question arrived to my mind, "what happens when the aggregation type is changed?" Is everything recalculated automatically? It should, IMO (or we can have really out-of-sync data in the gradebook). Note that this question is applicable to all the activities in general. i.e, each activity should declare what fields are related to grades, in order to perform a full refresh of the activity grades in gradebook each time one of those fields are modified. Ciao
          Hide
          Anthony Borrow added a comment -

          Eloy - Using the assess field that is already there - you're brilliant! I'll make the changes so that no database update is required. Yes, I agree with you that we need to be careful about keeping things in sync. I believe I mentioned earlier that changing the assessed field (i.e. the aggregation type) needs to reset the gradebook and recalculate all of the scores. In order for this to be a functional patch, that needs to happen. Peace - Anthony

          Show
          Anthony Borrow added a comment - Eloy - Using the assess field that is already there - you're brilliant! I'll make the changes so that no database update is required. Yes, I agree with you that we need to be careful about keeping things in sync. I believe I mentioned earlier that changing the assessed field (i.e. the aggregation type) needs to reset the gradebook and recalculate all of the scores. In order for this to be a functional patch, that needs to happen. Peace - Anthony
          Hide
          Anthony Borrow added a comment -

          Eloy - Just to clarify, I think leaving the assessed field as an int is best as it results in no chance to the database; however, I do think that the constants are the better way to go as it does facilitate additional ways of aggregating the ratings. I can foresee some creative scenarios developing once folks get used to having the freedom to specify an aggregation type. Peace - Anthony

          Show
          Anthony Borrow added a comment - Eloy - Just to clarify, I think leaving the assessed field as an int is best as it results in no chance to the database; however, I do think that the constants are the better way to go as it does facilitate additional ways of aggregating the ratings. I can foresee some creative scenarios developing once folks get used to having the freedom to specify an aggregation type. Peace - Anthony
          Hide
          Anthony Borrow added a comment -

          Updating the diff file. Including patch for MDL-12961 to avoid PHP notice in /forum/rate.php. This code now uses the assessed field and requires no changes to the database. I still need to add in the gradebook reset and recalculation if there is a change to the aggregate type (assessed field). Otherwise, I'm reasonably satisfied with how this works. Peace - Anthony

          Show
          Anthony Borrow added a comment - Updating the diff file. Including patch for MDL-12961 to avoid PHP notice in /forum/rate.php. This code now uses the assessed field and requires no changes to the database. I still need to add in the gradebook reset and recalculation if there is a change to the aggregate type (assessed field). Otherwise, I'm reasonably satisfied with how this works. Peace - Anthony
          Hide
          Anthony Borrow added a comment -

          Now that we are using the assessed field in mdl_forum, it may not be a bad idea to simply modify the previously used help button so that it includes the information for the forum aggregation types.

          Show
          Anthony Borrow added a comment - Now that we are using the assessed field in mdl_forum, it may not be a bad idea to simply modify the previously used help button so that it includes the information for the forum aggregation types.
          Hide
          Anthony Borrow added a comment -

          Petr/Eloy - Where would be the best place to put the code to reset the forum grades and process the re-calculation such that it would be triggered whenever the forum aggregate type is changed (i.e. the mdl_forum assessed field)? I'm thinking of using the forum's already existing function to reset the grades and then getting a list of the users who have posted a discussion and using a foreach loop to tell it to process the ratings (i.e. grades). I just want to make sure that I put it in the right place. Peace - Anthony

          Show
          Anthony Borrow added a comment - Petr/Eloy - Where would be the best place to put the code to reset the forum grades and process the re-calculation such that it would be triggered whenever the forum aggregate type is changed (i.e. the mdl_forum assessed field)? I'm thinking of using the forum's already existing function to reset the grades and then getting a list of the users who have posted a discussion and using a foreach loop to tell it to process the ratings (i.e. grades). I just want to make sure that I put it in the right place. Peace - Anthony
          Hide
          Anthony Borrow added a comment -

          OK - I tracked down where best to put the code reset and recalculate the grades. I believe the code should go in the /mod/forum/lib.php file in the forum_update_instance function. My next question has to do with how to trigger that if and only if the assessed value has changed. Otherwise, it seems to me that we are doing a lot of additional work. As it stands, is there a way to get the old value of assessed and compare it to the new value? Otherwise, I'm thinking of tagging on another field to $forum like $forum->oldassessed. So that it gets passed along to the forum_update_instance function but if it already available then I would like to use what is there. Another alternative is to do a query and get the existing values with something like a $oldforum = get_record. Again, if I can avoid another query all the better. Thanks for allowing me to think out loud and for any pointers you might have to make this updating of the grades as efficient as possible. Peace - Anthony

          Show
          Anthony Borrow added a comment - OK - I tracked down where best to put the code reset and recalculate the grades. I believe the code should go in the /mod/forum/lib.php file in the forum_update_instance function. My next question has to do with how to trigger that if and only if the assessed value has changed. Otherwise, it seems to me that we are doing a lot of additional work. As it stands, is there a way to get the old value of assessed and compare it to the new value? Otherwise, I'm thinking of tagging on another field to $forum like $forum->oldassessed. So that it gets passed along to the forum_update_instance function but if it already available then I would like to use what is there. Another alternative is to do a query and get the existing values with something like a $oldforum = get_record. Again, if I can avoid another query all the better. Thanks for allowing me to think out loud and for any pointers you might have to make this updating of the grades as efficient as possible. Peace - Anthony
          Hide
          Anthony Borrow added a comment -

          The revised patch now handles recalculating student scores if the aggregation type or the scale (i.e. max score) changes. Teachers wishing to prevent other students from rating posts need to do so when they create the forum. I did not modify how Moodle determines which ratings to include but instead only made available the possibility to choose whether it takes the avg, max, min, sum, or count of those ratings.

          Show
          Anthony Borrow added a comment - The revised patch now handles recalculating student scores if the aggregation type or the scale (i.e. max score) changes. Teachers wishing to prevent other students from rating posts need to do so when they create the forum. I did not modify how Moodle determines which ratings to include but instead only made available the possibility to choose whether it takes the avg, max, min, sum, or count of those ratings.
          Hide
          Anthony Borrow added a comment -

          A scenario that could potentially be problematic which AFAIK is not handled is how to handle already rated posts whose scores exceed an updated scale. In other words, what happens if a teacher originally makes a forum worth 100 points - goes in and rates the posts giving them scores of 0-100 and then changes the scale to 10. If this scenario is not handled or checked for, it would be worth creating a separate tracker issue for it. The patches for this issue do not intend to address that scenario.

          The question that would need to be resolved is how should Moodle respond to the above scenario. One option would be to have Moodle automatically assign the scale value if the current value exceeds it. Another approach would be make the new rating proportional to the old. My preference would be to check that no ratings exist which are higher than the new scale. If they do exist, then the teacher is warned that ratings exist which exceed the current scale. To prevent losing data, the teacher would be required to adjust the ratings first before changing the scale.

          Show
          Anthony Borrow added a comment - A scenario that could potentially be problematic which AFAIK is not handled is how to handle already rated posts whose scores exceed an updated scale. In other words, what happens if a teacher originally makes a forum worth 100 points - goes in and rates the posts giving them scores of 0-100 and then changes the scale to 10. If this scenario is not handled or checked for, it would be worth creating a separate tracker issue for it. The patches for this issue do not intend to address that scenario. The question that would need to be resolved is how should Moodle respond to the above scenario. One option would be to have Moodle automatically assign the scale value if the current value exceeds it. Another approach would be make the new rating proportional to the old. My preference would be to check that no ratings exist which are higher than the new scale. If they do exist, then the teacher is warned that ratings exist which exceed the current scale. To prevent losing data, the teacher would be required to adjust the ratings first before changing the scale.
          Hide
          Anthony Borrow added a comment -

          Petr/Eloy - The submitted patch seems to be pretty functional and takes advantage of existing functionality - not too much innovation, just using old pieces in a new way. I will leave it to your judgment as to whether this might be something beneficial to throw into Moodle 1.9 or better to wait for Moodle 2.0. In some ways, it fits with some of the enhancements in the gradebook. I think it provides a great deal of flexibility to the teachers and will enhance the usability of forums in the classroom so I would like to see it in 1.9 but both of you have a better feel for these things so I trust your judgment. Peace - Anthony

          Show
          Anthony Borrow added a comment - Petr/Eloy - The submitted patch seems to be pretty functional and takes advantage of existing functionality - not too much innovation, just using old pieces in a new way. I will leave it to your judgment as to whether this might be something beneficial to throw into Moodle 1.9 or better to wait for Moodle 2.0. In some ways, it fits with some of the enhancements in the gradebook. I think it provides a great deal of flexibility to the teachers and will enhance the usability of forums in the classroom so I would like to see it in 1.9 but both of you have a better feel for these things so I trust your judgment. Peace - Anthony
          Hide
          Anthony Borrow added a comment -

          removed the global $FORUM_AGGREGATE_TYPES and replaced with forum_get_aggregate_types function

          Show
          Anthony Borrow added a comment - removed the global $FORUM_AGGREGATE_TYPES and replaced with forum_get_aggregate_types function
          Hide
          Martin Dougiamas added a comment -

          Overall this approach looks very low-impact but useful and I would like to see it in Moodle 1.9.

          Two issues still to be resolved:

          1) The aggregation of grades for each individual POST should match the aggregation of grades for the whole forum, just to keep things consistent

          2) The new help file could be reorganised a bit to make it clearer (for example make the list a real list). Suggested text below:

          -------------------------------------------------------------------------
          Forum aggregation defines how all the ratings given to posts in a forum are combined to form the final grade (for each post and for the whole forum activity).

          Choose from the following aggregation methods:

          o Average (default)

          The mean of all the ratings given to posts in that forum. This is especially useful with peer grading when there are a lot of ratings being made.

          o Count

          The number of rated posts becomes the final grade. This is useful when the number of posts is important. Note that the total can not exceed the maximum grade allowed for the forum.

          o Max

          The highest rating is returned as the final grade. This method is useful for emphasising the best work from participants, allowing them to post one high-quality post as well as a number of more casual responses to others.

          o Min

          The smallest rating is returned as the final grade. This method promotes a culture of high quality for all posts.

          o Sum

          All the ratings for a particular user are added together. Note that the total is not allowed to exceed the maximum grade for the forum.
          -------------------------------------------------------------------------

          Show
          Martin Dougiamas added a comment - Overall this approach looks very low-impact but useful and I would like to see it in Moodle 1.9. Two issues still to be resolved: 1) The aggregation of grades for each individual POST should match the aggregation of grades for the whole forum, just to keep things consistent 2) The new help file could be reorganised a bit to make it clearer (for example make the list a real list). Suggested text below: ------------------------------------------------------------------------- Forum aggregation defines how all the ratings given to posts in a forum are combined to form the final grade (for each post and for the whole forum activity). Choose from the following aggregation methods: o Average (default) The mean of all the ratings given to posts in that forum. This is especially useful with peer grading when there are a lot of ratings being made. o Count The number of rated posts becomes the final grade. This is useful when the number of posts is important. Note that the total can not exceed the maximum grade allowed for the forum. o Max The highest rating is returned as the final grade. This method is useful for emphasising the best work from participants, allowing them to post one high-quality post as well as a number of more casual responses to others. o Min The smallest rating is returned as the final grade. This method promotes a culture of high quality for all posts. o Sum All the ratings for a particular user are added together. Note that the total is not allowed to exceed the maximum grade for the forum. -------------------------------------------------------------------------
          Hide
          Anthony Borrow added a comment -

          Eloy/Petr - Here is an updated patch file that includes new functions to calculate post max, min, count, summary, (and of course avg). I changed the text so that it will display the aggregation type next to post ratings so that it is clear to the user why the post rating is being calculated the way it is. In other words, if there are post ratings of 1, 2, 3 and the user sees an overall rating of 2 for that post it will tell them that the average aggregate type was used. I also updated the help file as Martin suggested. Please look closely at the newly created functions forum_get_ratings_count, forum_get_ratings_max, forum_get_ratings_min, forum_get_ratings_sum derived off of forum_get_ratings_mean as I was tired when I was working on this. I also added a parameter to forum_print_ratings_mean to prevent having to lookup the forum id from discussion. I searched to make sure there were no other places that used that function. I'll be traveling the rest of the day but will check when I get to California for any feedback, questions, etc. Peace - Anthony

          Show
          Anthony Borrow added a comment - Eloy/Petr - Here is an updated patch file that includes new functions to calculate post max, min, count, summary, (and of course avg). I changed the text so that it will display the aggregation type next to post ratings so that it is clear to the user why the post rating is being calculated the way it is. In other words, if there are post ratings of 1, 2, 3 and the user sees an overall rating of 2 for that post it will tell them that the average aggregate type was used. I also updated the help file as Martin suggested. Please look closely at the newly created functions forum_get_ratings_count, forum_get_ratings_max, forum_get_ratings_min, forum_get_ratings_sum derived off of forum_get_ratings_mean as I was tired when I was working on this. I also added a parameter to forum_print_ratings_mean to prevent having to lookup the forum id from discussion. I searched to make sure there were no other places that used that function. I'll be traveling the rest of the day but will check when I get to California for any feedback, questions, etc. Peace - Anthony
          Hide
          Peter Kupfer added a comment -

          So, I am a little bit in experienced in this kinds of things, but I don't know how to use this thing you have uploaded.

          I installed 1.9 beta 4 in a test area and I want to try and have a forum graded like this. I would like to do it 1.8.4 but that doesn't seem possible.

          In looking at the 1.9 I installed I don't see this option anywhere, but in general the new gradebook confuses me. Any help would be appreciated.

          Show
          Peter Kupfer added a comment - So, I am a little bit in experienced in this kinds of things, but I don't know how to use this thing you have uploaded. I installed 1.9 beta 4 in a test area and I want to try and have a forum graded like this. I would like to do it 1.8.4 but that doesn't seem possible. In looking at the 1.9 I installed I don't see this option anywhere, but in general the new gradebook confuses me. Any help would be appreciated.
          Hide
          Anthony Borrow added a comment -

          Petr - I'm changing this fix version to 1.9 so that this does not fall between the cracks. I'm back from Mexico and head to the Dominican Republic tonight. Peace - Anthony

          Show
          Anthony Borrow added a comment - Petr - I'm changing this fix version to 1.9 so that this does not fall between the cracks. I'm back from Mexico and head to the Dominican Republic tonight. Peace - Anthony
          Hide
          Peter Kupfer added a comment -

          Anthony –

          I am not familiar with the lingo, but does that mean it is fixed in 1.9, that is will be fixed in 1.9, or that it should be fixed in 1.9.\

          Thanks.

          PK

          Show
          Peter Kupfer added a comment - Anthony – I am not familiar with the lingo, but does that mean it is fixed in 1.9, that is will be fixed in 1.9, or that it should be fixed in 1.9.\ Thanks. PK
          Hide
          Anthony Borrow added a comment -

          Peter - It simply means that we hope to have it fixed in that version. The patch attached with this issue is designed for Moodle 1.9 and MartinD had commented that he would like to see it in 1.9. I know that the hope is to get 1.9 officially released soon. As I am still traveling, I simply wanted to make sure that this patch was not overlooked before the release of 1.9. Peace - Anthony

          Show
          Anthony Borrow added a comment - Peter - It simply means that we hope to have it fixed in that version. The patch attached with this issue is designed for Moodle 1.9 and MartinD had commented that he would like to see it in 1.9. I know that the hope is to get 1.9 officially released soon. As I am still traveling, I simply wanted to make sure that this patch was not overlooked before the release of 1.9. Peace - Anthony
          Hide
          Petr Škoda added a comment -

          I have fixed the whitespace and committed the patch into cvs :-D
          please test and report bugs as new issues, thanks for the report, patch and testing...

          Show
          Petr Škoda added a comment - I have fixed the whitespace and committed the patch into cvs :-D please test and report bugs as new issues, thanks for the report, patch and testing...
          Hide
          Dan Poltawski added a comment -

          On upgrade i'm getting warnings:

          forum module needs upgrading

          Warning: Invalid argument supplied for foreach() in /var/www/moodle/mod/forum/lib.php on line 1234

          Warning: Invalid argument supplied for foreach() in /var/www/moodle/mod/forum/lib.php on line 1234

          Warning: Invalid argument supplied for foreach() in /var/www/moodle/mod/forum/lib.php on line 1234

          Warning: Invalid argument supplied for foreach() in /var/www/moodle/mod/forum/lib.php on line 1234

          Warning: Invalid argument supplied for foreach() in /var/www/moodle/mod/forum/lib.php on line 1234

          Warning: Invalid argument supplied for foreach() in /var/www/moodle/mod/forum/lib.php on line 1234

          Warning: Invalid argument supplied for foreach() in /var/www/moodle/mod/forum/lib.php on line 1234

          Warning: Invalid argument supplied for foreach() in /var/www/moodle/mod/forum/lib.php on line 1234

          Warning: Invalid argument supplied for foreach() in /var/www/moodle/mod/forum/lib.php on line 1234

          Warning: Invalid argument supplied for foreach() in /var/www/moodle/mod/forum/lib.php on line 1234

          Warning: Invalid argument supplied for foreach() in /var/www/moodle/mod/forum/lib.php on line 1234

          Warning: Invalid argument supplied for foreach() in /var/www/moodle/mod/forum/lib.php on line 1234

          Warning: Invalid argument supplied for foreach() in /var/www/moodle/mod/forum/lib.php on line 1234

          Warning: Invalid argument supplied for foreach() in /var/www/moodle/mod/forum/lib.php on line 1234

          Warning: Invalid argument supplied for foreach() in /var/www/moodle/mod/forum/lib.php on line 1234

          Warning: Invalid argument supplied for foreach() in /var/www/moodle/mod/forum/lib.php on line 1234

          Warning: Invalid argument supplied for foreach() in /var/www/moodle/mod/forum/lib.php on line 1234

          Warning: Invalid argument supplied for foreach() in /var/www/moodle/mod/forum/lib.php on line 1234

          Warning: Invalid argument supplied for foreach() in /var/www/moodle/mod/forum/lib.php on line 1234

          Warning: Invalid argument supplied for foreach() in /var/www/moodle/mod/forum/lib.php on line 1234

          Warning: Invalid argument supplied for foreach() in /var/www/moodle/mod/forum/lib.php on line 1234

          Warning: Invalid argument supplied for foreach() in /var/www/moodle/mod/forum/lib.php on line 1234

          Warning: Invalid argument supplied for foreach() in /var/www/moodle/mod/forum/lib.php on line 1234

          Warning: Invalid argument supplied for foreach() in /var/www/moodle/mod/forum/lib.php on line 1234

          Warning: Invalid argument supplied for foreach() in /var/www/moodle/mod/forum/lib.php on line 1234

          Warning: Invalid argument supplied for foreach() in /var/www/moodle/mod/forum/lib.php on line 1234

          Warning: Invalid argument supplied for foreach() in /var/www/moodle/mod/forum/lib.php on line 1234

          Warning: Invalid argument supplied for foreach() in /var/www/moodle/mod/forum/lib.php on line 1234

          Warning: Invalid argument supplied for foreach() in /var/www/moodle/mod/forum/lib.php on line 1234

          Warning: Invalid argument supplied for foreach() in /var/www/moodle/mod/forum/lib.php on line 1234

          Warning: Invalid argument supplied for foreach() in /var/www/moodle/mod/forum/lib.php on line 1234

          Warning: Invalid argument supplied for foreach() in /var/www/moodle/mod/forum/lib.php on line 1234

          Warning: Invalid argument supplied for foreach() in /var/www/moodle/mod/forum/lib.php on line 1234

          Show
          Dan Poltawski added a comment - On upgrade i'm getting warnings: forum module needs upgrading Warning: Invalid argument supplied for foreach() in /var/www/moodle/mod/forum/lib.php on line 1234 Warning: Invalid argument supplied for foreach() in /var/www/moodle/mod/forum/lib.php on line 1234 Warning: Invalid argument supplied for foreach() in /var/www/moodle/mod/forum/lib.php on line 1234 Warning: Invalid argument supplied for foreach() in /var/www/moodle/mod/forum/lib.php on line 1234 Warning: Invalid argument supplied for foreach() in /var/www/moodle/mod/forum/lib.php on line 1234 Warning: Invalid argument supplied for foreach() in /var/www/moodle/mod/forum/lib.php on line 1234 Warning: Invalid argument supplied for foreach() in /var/www/moodle/mod/forum/lib.php on line 1234 Warning: Invalid argument supplied for foreach() in /var/www/moodle/mod/forum/lib.php on line 1234 Warning: Invalid argument supplied for foreach() in /var/www/moodle/mod/forum/lib.php on line 1234 Warning: Invalid argument supplied for foreach() in /var/www/moodle/mod/forum/lib.php on line 1234 Warning: Invalid argument supplied for foreach() in /var/www/moodle/mod/forum/lib.php on line 1234 Warning: Invalid argument supplied for foreach() in /var/www/moodle/mod/forum/lib.php on line 1234 Warning: Invalid argument supplied for foreach() in /var/www/moodle/mod/forum/lib.php on line 1234 Warning: Invalid argument supplied for foreach() in /var/www/moodle/mod/forum/lib.php on line 1234 Warning: Invalid argument supplied for foreach() in /var/www/moodle/mod/forum/lib.php on line 1234 Warning: Invalid argument supplied for foreach() in /var/www/moodle/mod/forum/lib.php on line 1234 Warning: Invalid argument supplied for foreach() in /var/www/moodle/mod/forum/lib.php on line 1234 Warning: Invalid argument supplied for foreach() in /var/www/moodle/mod/forum/lib.php on line 1234 Warning: Invalid argument supplied for foreach() in /var/www/moodle/mod/forum/lib.php on line 1234 Warning: Invalid argument supplied for foreach() in /var/www/moodle/mod/forum/lib.php on line 1234 Warning: Invalid argument supplied for foreach() in /var/www/moodle/mod/forum/lib.php on line 1234 Warning: Invalid argument supplied for foreach() in /var/www/moodle/mod/forum/lib.php on line 1234 Warning: Invalid argument supplied for foreach() in /var/www/moodle/mod/forum/lib.php on line 1234 Warning: Invalid argument supplied for foreach() in /var/www/moodle/mod/forum/lib.php on line 1234 Warning: Invalid argument supplied for foreach() in /var/www/moodle/mod/forum/lib.php on line 1234 Warning: Invalid argument supplied for foreach() in /var/www/moodle/mod/forum/lib.php on line 1234 Warning: Invalid argument supplied for foreach() in /var/www/moodle/mod/forum/lib.php on line 1234 Warning: Invalid argument supplied for foreach() in /var/www/moodle/mod/forum/lib.php on line 1234 Warning: Invalid argument supplied for foreach() in /var/www/moodle/mod/forum/lib.php on line 1234 Warning: Invalid argument supplied for foreach() in /var/www/moodle/mod/forum/lib.php on line 1234 Warning: Invalid argument supplied for foreach() in /var/www/moodle/mod/forum/lib.php on line 1234 Warning: Invalid argument supplied for foreach() in /var/www/moodle/mod/forum/lib.php on line 1234 Warning: Invalid argument supplied for foreach() in /var/www/moodle/mod/forum/lib.php on line 1234
          Hide
          Petr Škoda added a comment -

          fixed, thanks!

          Show
          Petr Škoda added a comment - fixed, thanks!
          Hide
          Peter Kupfer added a comment -

          Sorry again, I am trying to learn the lingo. The comment about in fixed in 2.0 and then again in 1.9 throws me off. If I download the latest 1.9 beta and try it, will I see this feature added?

          Thank,
          PK

          Show
          Peter Kupfer added a comment - Sorry again, I am trying to learn the lingo. The comment about in fixed in 2.0 and then again in 1.9 throws me off. If I download the latest 1.9 beta and try it, will I see this feature added? Thank, PK
          Hide
          Anthony Borrow added a comment -

          Peter - No problem. As development of the code continues, sometimes it is helpful branch the code so that we have a separate version to work on. To fix something in version 1.9 we work on the 19STABLE branch and to fix something for the current development version (which is currently 2.0) we work on the HEAD branch. So to say that it was fixed in 1.9 and 2.0 means that the changes were applied to both the 19STABLE branch and HEAD (so that it will be in future releases). The nightly build for the 1.9 beta takes a snapshot of the 19STABLE branch and puts it into a zip file. I'm not sure if the most recent changes will be in the zip or tar files of the latest 19STABLE branch but you can be assured that after 24 hours they will be . Thanks for your patience. Peace - Anthony

          Show
          Anthony Borrow added a comment - Peter - No problem. As development of the code continues, sometimes it is helpful branch the code so that we have a separate version to work on. To fix something in version 1.9 we work on the 19STABLE branch and to fix something for the current development version (which is currently 2.0) we work on the HEAD branch. So to say that it was fixed in 1.9 and 2.0 means that the changes were applied to both the 19STABLE branch and HEAD (so that it will be in future releases). The nightly build for the 1.9 beta takes a snapshot of the 19STABLE branch and puts it into a zip file. I'm not sure if the most recent changes will be in the zip or tar files of the latest 19STABLE branch but you can be assured that after 24 hours they will be . Thanks for your patience. Peace - Anthony
          Hide
          Nicolas Martignoni added a comment -

          Closing, as this works as described on 19_STABLE branch.

          Show
          Nicolas Martignoni added a comment - Closing, as this works as described on 19_STABLE branch.
          Hide
          D.I. von Briesen added a comment -

          I'm very excited to see this new functionality - though it may be a while before I can use it (our school only just now upgraded from 1.5.4 to 1.8).

          I wonder if I might make one final plea for the adding of a button/link that allows a post to be graded AND replied to with one click? I've got 103 students in one class, and i want to give each a grade AND a reply on each forum (and I have about 35 forums) and just that little issue would really really help, without over-complicating things.

          Basically it would be a process to kick off the same thing that hitting the rate button does now, but then kick of the process that the reply link does just after that.

          This is actually a separate feature request: http://tracker.moodle.org/browse/MDL-10324 which Martin seems to have pegged as for 2.0... but couldn't we simply make that tiny little change (add a button that rates and loads reply window) while we're here already?

          d.i.

          ps- did i say I'd give $100 for this? I would....

          Show
          D.I. von Briesen added a comment - I'm very excited to see this new functionality - though it may be a while before I can use it (our school only just now upgraded from 1.5.4 to 1.8). I wonder if I might make one final plea for the adding of a button/link that allows a post to be graded AND replied to with one click? I've got 103 students in one class, and i want to give each a grade AND a reply on each forum (and I have about 35 forums) and just that little issue would really really help, without over-complicating things. Basically it would be a process to kick off the same thing that hitting the rate button does now, but then kick of the process that the reply link does just after that. This is actually a separate feature request: http://tracker.moodle.org/browse/MDL-10324 which Martin seems to have pegged as for 2.0... but couldn't we simply make that tiny little change (add a button that rates and loads reply window) while we're here already? d.i. ps- did i say I'd give $100 for this? I would....
          Hide
          Petr Škoda added a comment -

          Though it may seem simple, there would have to be some very dark javascript magic involved or the page would have to be completely rewritten, I am afraid this can not be done in 1.9, sorry

          Show
          Petr Škoda added a comment - Though it may seem simple, there would have to be some very dark javascript magic involved or the page would have to be completely rewritten, I am afraid this can not be done in 1.9, sorry

            People

            • Votes:
              14 Vote for this issue
              Watchers:
              10 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: