Details

    • Testing Instructions:
      Hide
      1. Select the Clean theme
      2. In any page where you can add text using TinyMCE TEST to see that the default font used in the editor is not too small and that the font family is Arial or Helvetica or sans-serif, depending on your browser.

      The text in the editor should match (font, size, color) the font displayed when saved.

      Show
      Select the Clean theme In any page where you can add text using TinyMCE TEST to see that the default font used in the editor is not too small and that the font family is Arial or Helvetica or sans-serif, depending on your browser. The text in the editor should match (font, size, color) the font displayed when saved.
    • Affected Branches:
      MOODLE_25_STABLE
    • Fixed Branches:
      MOODLE_25_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      wip-MDL-39424-master
    • Rank:
      50073

      Description

      The editor default font should match what the text will look like in the page once it's displayed (it's called WYSIWYG)

        Issue Links

          Activity

          Hide
          Martin Dougiamas added a comment -

          Assigning to you for comment Mary but please feel free to assign to moodle.com if you can't do this. Anyone is free to take it in fact

          Show
          Martin Dougiamas added a comment - Assigning to you for comment Mary but please feel free to assign to moodle.com if you can't do this. Anyone is free to take it in fact
          Hide
          Mary Evans added a comment -

          @Martin, there is no where that I can see in bootstrapbase/style/editor.css that mentions verdana font.
          The font-face comes from bootstrapbase/less/editor.less which @import imports bootstrapbase/less/bootstrap/variables.less and that file only includes the following:

          @sansFontFamily: "Helvetica Neue", Helvetica, Arial, sans-serif;
          @serifFontFamily: Georgia, "Times New Roman", Times, serif;
          @monoFontFamily: Monaco, Menlo, Consolas, "Courier New", monospace;
          

          You can check it yourself here if you doubt my findings...

          https://github.com/moodle/moodle/blob/master/theme/bootstrapbase/less/bootstrap/variables.less

          Are you sure it's not the browser default that's doing this?

          In Firefox Browser select Tools-> Options-> Advanced->User options?

          Show
          Mary Evans added a comment - @Martin, there is no where that I can see in bootstrapbase/style/editor.css that mentions verdana font. The font-face comes from bootstrapbase/less/editor.less which @import imports bootstrapbase/less/bootstrap/variables.less and that file only includes the following: @sansFontFamily: "Helvetica Neue" , Helvetica, Arial, sans-serif; @serifFontFamily: Georgia, "Times New Roman" , Times, serif; @monoFontFamily: Monaco, Menlo, Consolas, "Courier New" , monospace; You can check it yourself here if you doubt my findings... https://github.com/moodle/moodle/blob/master/theme/bootstrapbase/less/bootstrap/variables.less Are you sure it's not the browser default that's doing this? In Firefox Browser select Tools-> Options-> Advanced->User options?
          Hide
          Mary Evans added a comment -
          Show
          Mary Evans added a comment - It's coming from TinyMCE stylesheet here's the url... http://localhost/moodle25/lib/editor/tinymce/tiny_mce/3.5.8/themes/advanced/skins/o2k7/content.css
          Hide
          Martin Dougiamas added a comment -

          So it is! In fact it's not changed in ages and matches the overall tiny fonts used in Standard (eg MDL-26058 which was closed without resolution).

          I still think it's something that should be overridden in bootstrapbase though, to make it look more WYSIWYG. When a font is unspecified in the HTML the text should have the same size/font as it will when displayed out of the editor.

          Show
          Martin Dougiamas added a comment - So it is! In fact it's not changed in ages and matches the overall tiny fonts used in Standard (eg MDL-26058 which was closed without resolution). I still think it's something that should be overridden in bootstrapbase though, to make it look more WYSIWYG. When a font is unspecified in the HTML the text should have the same size/font as it will when displayed out of the editor.
          Hide
          David Scotson added a comment -

          I looked into this a while ago as we got the same report against our live site that has a Bootstrap based theme. I didn't find a way to fix it on the live site via adding custom CSS, which means I don't think you can fix it by changing the normal theme CSS, due to the way the editor is embedded into the page. But perhaps it can be fixed in the editor.css?

          Show
          David Scotson added a comment - I looked into this a while ago as we got the same report against our live site that has a Bootstrap based theme. I didn't find a way to fix it on the live site via adding custom CSS, which means I don't think you can fix it by changing the normal theme CSS, due to the way the editor is embedded into the page. But perhaps it can be fixed in the editor.css?
          Hide
          Mary Evans added a comment - - edited

          Moodle.org TinyMCE uses Lucinda font which is specified in https://moodle.org/theme/moodleofficial/style/editor.css

          With this in mind, and also the fact that base theme too only has one CSS rule, but in comparison uses Arial font. https://github.com/moodle/moodle/blob/master/theme/base/style/editor.css

          Why is it then that bootstrapbase has a plethora of rules, which seems to be ignored?

          Shall I dispense with the editor.less in bootstrapbase and just add editor.css to theme/clean/style/editor.css which contains only one line?

          body {font:13px/1.231 arial,helvetica,clean,sans-serif;}
          Show
          Mary Evans added a comment - - edited Moodle.org TinyMCE uses Lucinda font which is specified in https://moodle.org/theme/moodleofficial/style/editor.css With this in mind, and also the fact that base theme too only has one CSS rule, but in comparison uses Arial font. https://github.com/moodle/moodle/blob/master/theme/base/style/editor.css Why is it then that bootstrapbase has a plethora of rules, which seems to be ignored? Shall I dispense with the editor.less in bootstrapbase and just add editor.css to theme/clean/style/editor.css which contains only one line? body {font:13px/1.231 arial,helvetica,clean,sans-serif;}
          Hide
          Mary Evans added a comment -

          I'll test it in clean theme and let you know. Also if the problem is a regression, perhaps it's because the editor.css is not being picked up form the parent theme?

          Show
          Mary Evans added a comment - I'll test it in clean theme and let you know. Also if the problem is a regression, perhaps it's because the editor.css is not being picked up form the parent theme?
          Hide
          David Scotson added a comment -

          The problem is in less/editor.less, the line that declares the basic font styles for bootstrap isn't included.

          If you add

          @import "bootstrap/scaffolding.less";

          just before the line:

          @import "bootstrap/type.less";

          and regenerate style/editor.css with recess then it picks it up (the basic font styles are defined in scaffolding.less not type.less).

          Show
          David Scotson added a comment - The problem is in less/editor.less, the line that declares the basic font styles for bootstrap isn't included. If you add @import "bootstrap/scaffolding.less"; just before the line: @import "bootstrap/type.less"; and regenerate style/editor.css with recess then it picks it up (the basic font styles are defined in scaffolding.less not type.less).
          Hide
          Mary Evans added a comment - - edited

          OK...that's easy enough. But do we need all the other CSS in less/editor.less that ends up in editor.css?

          Show
          Mary Evans added a comment - - edited OK...that's easy enough. But do we need all the other CSS in less/editor.less that ends up in editor.css?
          Hide
          David Scotson added a comment -

          It depends how much you want the stuff in the editor to look like what will be displayed when you hit save and which parts of the CSS you're using.

          If you use something like this:

          <a href="#" class="btn btn-success btn-large"><i class="icon-white icon-heart"></i> Bootstrap Button Generator</a>

          Then it'll look quite different in the editor (a simple text link) compared with the actual page (a big green button with an icon) if the Bootstrap CSS isn't included.

          In a a simple paragraph of text in a forum post it might not make any difference at all, but if you're using the Bootstrap styles to jazz up a class text you probably want it to be vaguely WYSIWYG.

          Show
          David Scotson added a comment - It depends how much you want the stuff in the editor to look like what will be displayed when you hit save and which parts of the CSS you're using. If you use something like this: <a href="#" class="btn btn-success btn-large"><i class="icon-white icon-heart"></i> Bootstrap Button Generator</a> Then it'll look quite different in the editor (a simple text link) compared with the actual page (a big green button with an icon) if the Bootstrap CSS isn't included. In a a simple paragraph of text in a forum post it might not make any difference at all, but if you're using the Bootstrap styles to jazz up a class text you probably want it to be vaguely WYSIWYG.
          Hide
          Mary Evans added a comment -

          David, I think it would be helpful to show un-minified CSS at Integration Review, and let the Integrator run Recess to generate the minified CSS when being merged into Moodle, as it is not easy to see what changes have taken place in the un-minified version.

          Show
          Mary Evans added a comment - David, I think it would be helpful to show un-minified CSS at Integration Review, and let the Integrator run Recess to generate the minified CSS when being merged into Moodle, as it is not easy to see what changes have taken place in the un-minified version.
          Hide
          Andrew Davis added a comment -

          It's hard to tell from the diff as it contains minified CSS however if there is any chance that this could impact other themes it would be best to expand the testing instructions to include checking that Standard hasn't been altered unexpectedly.

          Show
          Andrew Davis added a comment - It's hard to tell from the diff as it contains minified CSS however if there is any chance that this could impact other themes it would be best to expand the testing instructions to include checking that Standard hasn't been altered unexpectedly.
          Hide
          Mary Evans added a comment -

          It has nothing to do with Moodle other standard themes, it's just a bootstrapbase problem. And since Clean is the only theme that used bootstrapbase as a parent, only Clean is affected.

          To tell you the truth I don't think anyone has ever bothered checking to see if the font specified in theme/base/style/editor.css works in the TinyMCE editor or that theme/afterburner has no editor.css at all but has it listed in theme/afterburner/config.php.

          Show
          Mary Evans added a comment - It has nothing to do with Moodle other standard themes, it's just a bootstrapbase problem. And since Clean is the only theme that used bootstrapbase as a parent, only Clean is affected. To tell you the truth I don't think anyone has ever bothered checking to see if the font specified in theme/base/style/editor.css works in the TinyMCE editor or that theme/afterburner has no editor.css at all but has it listed in theme/afterburner/config.php.
          Hide
          Mary Evans added a comment -

          Is anyone bovvered?

          Show
          Mary Evans added a comment - Is anyone bovvered?
          Hide
          Andrew Davis added a comment -

          Probably best to open one or more new MDLs if there are other editor.css related problems rather than expanding this issue's scope. When in doubt, raise more MDLs :|

          Show
          Andrew Davis added a comment - Probably best to open one or more new MDLs if there are other editor.css related problems rather than expanding this issue's scope. When in doubt, raise more MDLs :|
          Hide
          Michael de Raadt added a comment -

          It would be good to know where this issue is going.

          It is currently up for peer review. Is that the correct state?

          A few people have looked at this issue and commented. Does it need more reviewing?

          If more work needs to be done, perhaps it should be removed from the "Must fix for 2.5" backlog.

          Show
          Michael de Raadt added a comment - It would be good to know where this issue is going. It is currently up for peer review. Is that the correct state? A few people have looked at this issue and commented. Does it need more reviewing? If more work needs to be done, perhaps it should be removed from the "Must fix for 2.5" backlog.
          Hide
          Mary Evans added a comment -

          @Michael: I think this should have been set for Integration Review but David does not appear to have the permission to do this and since he does not ask me to set it so, then it stays as is.

          Show
          Mary Evans added a comment - @Michael: I think this should have been set for Integration Review but David does not appear to have the permission to do this and since he does not ask me to set it so, then it stays as is.
          Hide
          Mary Evans added a comment -

          This will probably need to be rebased.

          Show
          Mary Evans added a comment - This will probably need to be rebased.
          Hide
          David Scotson added a comment -

          I've just noticed that I included in the commit an extra css file that I created just to diff and see what had changed.

          The editor_generated.css file isn't needed.

          Show
          David Scotson added a comment - I've just noticed that I included in the commit an extra css file that I created just to diff and see what had changed. The editor_generated.css file isn't needed.
          Hide
          David Scotson added a comment -

          I've updated the git branch to remove the unneccesary file.

          Is there some documentation on the right way to prepare git branches for review? I'm creating branches with a single commit, but if on review there are issues and a change needs to be made I don't really know how to precede. At the moment I'm simply deleting the published branch from github and pushing a new one to the same place, sometimes created from scratch. I supposed I could do the same with git's history rewriting tools, the ones they tell you never to use after you've made code public. Neither really feels right to me.

          It kind of feels like the commit squashing shouldn't happen until after other people have checked that the code is sound.

          Show
          David Scotson added a comment - I've updated the git branch to remove the unneccesary file. Is there some documentation on the right way to prepare git branches for review? I'm creating branches with a single commit, but if on review there are issues and a change needs to be made I don't really know how to precede. At the moment I'm simply deleting the published branch from github and pushing a new one to the same place, sometimes created from scratch. I supposed I could do the same with git's history rewriting tools, the ones they tell you never to use after you've made code public. Neither really feels right to me. It kind of feels like the commit squashing shouldn't happen until after other people have checked that the code is sound.
          Hide
          Eloy Lafuente (stronk7) added a comment -

          david you can always, when a branch is "ongoing" (under development / integration) do any of these:

          1) add more commits to the branch (if the changes are isolated/different and up to a limit (say 2-3 commits). Nothing forbids you to have multiple commits, in fact it helps some times the review process if they are a chain of changes (because I changed this here then I have to change that there...).

          2) But when it's about to "fix" something that in the previous commit was wrong, I think it's better to amend the existing commit (so the wrong never happened). To do so, you only need to do:

          a) make your changes fixing the wrong thing.
          b) git add the changed files
          c) git commit --amend
          d) then you will be asked for a new commit message (with the previous one being shown by default).
          e) git push --force (this will make the old commit to disappear completely and be replaced by the new one, hence, the "wrong" never happened).

          And those are the 2 strategies used usually to add stuff to "ongoing" issues. new commits for new changes and amending for fixes. Basically.

          Note the --force options never can be used in public stuff (repos cloned by others, for example moodle.git). But for "ongoing" branches (development ones, still not integrated at all, that will be deleted after, it's not a problem, but a nice utility).

          Ciao

          Show
          Eloy Lafuente (stronk7) added a comment - david you can always, when a branch is "ongoing" (under development / integration) do any of these: 1) add more commits to the branch (if the changes are isolated/different and up to a limit (say 2-3 commits). Nothing forbids you to have multiple commits, in fact it helps some times the review process if they are a chain of changes (because I changed this here then I have to change that there...). 2) But when it's about to "fix" something that in the previous commit was wrong, I think it's better to amend the existing commit (so the wrong never happened). To do so, you only need to do: a) make your changes fixing the wrong thing. b) git add the changed files c) git commit --amend d) then you will be asked for a new commit message (with the previous one being shown by default). e) git push --force (this will make the old commit to disappear completely and be replaced by the new one, hence, the "wrong" never happened). And those are the 2 strategies used usually to add stuff to "ongoing" issues. new commits for new changes and amending for fixes. Basically. Note the --force options never can be used in public stuff (repos cloned by others, for example moodle.git). But for "ongoing" branches (development ones, still not integrated at all, that will be deleted after, it's not a problem, but a nice utility). Ciao
          Hide
          Eloy Lafuente (stronk7) added a comment -

          The phrase that decides the possibility of using the amend/force alternative is, simply:

          "is the code (the commit) that I'm going to kill (by amending it) only mine?" (aka, it's not in anyone's else repository).

          If yes, then you can amend/force (and rebase, that's another story). If no, add new commits (it's the only safe way if your commit is already "shared" in other repositories (integration.git, moodle.git).

          Ciao

          Show
          Eloy Lafuente (stronk7) added a comment - The phrase that decides the possibility of using the amend/force alternative is, simply: "is the code (the commit) that I'm going to kill (by amending it) only mine?" (aka, it's not in anyone's else repository). If yes, then you can amend/force (and rebase, that's another story). If no, add new commits (it's the only safe way if your commit is already "shared" in other repositories (integration.git, moodle.git). Ciao
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Back to the issue I'd say that yes, I note it constantly. Specially in some themes where the font face/size used for tables is, once again, ridiculous small (I use Overlay in Lucas' (my little beast) school site). Body / paragraph text looks ok but...

          ... I hate the editor each time i decide to create a table there, because differences with the final result are like day and night.

          So the most we get similar visualization, the better IMO (not only with this theme but with all). Of course, in another issue, this is only about bootstrap/clean.

          Show
          Eloy Lafuente (stronk7) added a comment - Back to the issue I'd say that yes, I note it constantly. Specially in some themes where the font face/size used for tables is, once again, ridiculous small (I use Overlay in Lucas' (my little beast) school site). Body / paragraph text looks ok but... ... I hate the editor each time i decide to create a table there, because differences with the final result are like day and night. So the most we get similar visualization, the better IMO (not only with this theme but with all). Of course, in another issue, this is only about bootstrap/clean.
          Hide
          Mary Evans added a comment - - edited

          Surely it would just be simpler to add editor.css to theme/clean/style like all the other core themes, wouldn't it? Minus all the Bootstrap CSS that is. Normally all we have in the editor.css is

          body {font:13px/1.231 arial,helvetica,sans-serif;}
          
          Show
          Mary Evans added a comment - - edited Surely it would just be simpler to add editor.css to theme/clean/style like all the other core themes, wouldn't it? Minus all the Bootstrap CSS that is. Normally all we have in the editor.css is body {font:13px/1.231 arial,helvetica,sans-serif;}
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Mary, if there is something to land into theme/clean/style/editor.css then we should create theme/clean/less/editor.css (if we want to do it properly).

          Although, personally, it seems better if the very-basic styles for a good visualization are set in the base theme, so any other will immediately benefit (by default).

          Anyway, I'm not an expert about that, so I leave you to decide it. I'll keep this open for some hours.

          Ciao

          Show
          Eloy Lafuente (stronk7) added a comment - Mary, if there is something to land into theme/clean/style/editor.css then we should create theme/clean/less/editor.css (if we want to do it properly). Although, personally, it seems better if the very-basic styles for a good visualization are set in the base theme, so any other will immediately benefit (by default). Anyway, I'm not an expert about that, so I leave you to decide it. I'll keep this open for some hours. Ciao
          Hide
          Mary Evans added a comment -

          Eloy the branch David submitted should work. Can you integrate it please?

          It contains this CSS which is all that was needed...

          body{margin:0;font-family:"Helvetica Neue",Helvetica,Arial,sans-serif;font-size:14px;line-height:20px;color:#333;background-color:#fff}
          
          Show
          Mary Evans added a comment - Eloy the branch David submitted should work. Can you integrate it please? It contains this CSS which is all that was needed... body{margin:0;font-family: "Helvetica Neue" ,Helvetica,Arial,sans-serif;font-size:14px;line-height:20px;color:#333;background-color:#fff}
          Hide
          Tim Hunt added a comment -

          Note that I fixed this issue in the OU theme, then I made this forum thread about doing the fix in core: https://moodle.org/mod/forum/discuss.php?d=217487

          Sadly, it looks like we did not get as far as submitting a patch to core.

          Anyway, MDL-35051 is the non-bootstrap version of this issue.

          Note that the HTML editor is meant to be WYSIWYG, so I disagree with Martin when he says: "I suggest making the default font for Bootstrap themes match the font used in text editing fields for consistency". It should match the font used for main page content. Actually Martin corrects himself: https://tracker.moodle.org/browse/MDL-39424?focusedCommentId=219438&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-219438

          Show
          Tim Hunt added a comment - Note that I fixed this issue in the OU theme, then I made this forum thread about doing the fix in core: https://moodle.org/mod/forum/discuss.php?d=217487 Sadly, it looks like we did not get as far as submitting a patch to core. Anyway, MDL-35051 is the non-bootstrap version of this issue. Note that the HTML editor is meant to be WYSIWYG, so I disagree with Martin when he says: "I suggest making the default font for Bootstrap themes match the font used in text editing fields for consistency". It should match the font used for main page content. Actually Martin corrects himself: https://tracker.moodle.org/browse/MDL-39424?focusedCommentId=219438&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-219438
          Hide
          Mary Evans added a comment - - edited

          I still maintain that there is far too much CSS in the bootstrapbase/less/editor.less. In actual fact it is importing bootstrap/ css files and NOT moodle/ css as moodle.css does. Checking out the editor.css in the W3C CSS Validator give a load of parse errors so it may be that TinyMCS is not set up to read this or Moodle burps and throws it out.

          Anyway, theme/clean has no editor.css specified with is required I would have thought, if we are to take any standard Moodle theme as a guide in this matter.

          Another problem which may be blocking this is that theme/clean like bootstrapbase, has YUI CSS blocked.

          Can we not just have a simple set of css rules set in bootstrapbase/less/editor.less to test this?

          Show
          Mary Evans added a comment - - edited I still maintain that there is far too much CSS in the bootstrapbase/less/editor.less. In actual fact it is importing bootstrap/ css files and NOT moodle/ css as moodle.css does. Checking out the editor.css in the W3C CSS Validator give a load of parse errors so it may be that TinyMCS is not set up to read this or Moodle burps and throws it out. Anyway, theme/clean has no editor.css specified with is required I would have thought, if we are to take any standard Moodle theme as a guide in this matter. Another problem which may be blocking this is that theme/clean like bootstrapbase, has YUI CSS blocked. Can we not just have a simple set of css rules set in bootstrapbase/less/editor.less to test this?
          Hide
          David Scotson added a comment -

          @ Mary,

          I'm a bit confused about your objection(s). In the bug Tim links to you seem keen for the editor to reflect what the actual content will look like once saved. That requires the same CSS to be used in both places since that's what controls the appearance.

          As far as I'm aware the updated editor.css basically works as expected. Are you saying that you've experienced a problem with it, that you think might be to do with it's size, or it's validation status, or it's interaction with YUI? In your last line above what is it that you want to test?

          Have you tried purging all caches? The last time I worked on the editor.css I could never get it to update as easily as the main theme CSS which makes testing changes to it pretty tricky. If you're seeing weird stuff happen I'd say that caching is the most likely culprit.

          Show
          David Scotson added a comment - @ Mary, I'm a bit confused about your objection(s). In the bug Tim links to you seem keen for the editor to reflect what the actual content will look like once saved. That requires the same CSS to be used in both places since that's what controls the appearance. As far as I'm aware the updated editor.css basically works as expected. Are you saying that you've experienced a problem with it, that you think might be to do with it's size, or it's validation status, or it's interaction with YUI? In your last line above what is it that you want to test? Have you tried purging all caches? The last time I worked on the editor.css I could never get it to update as easily as the main theme CSS which makes testing changes to it pretty tricky. If you're seeing weird stuff happen I'd say that caching is the most likely culprit.
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Adding example after applying David's patch. Really better than without it. Anyway I detected the problem with the tiny font size used by table contents I commented above.

          So, do you want me to push this and leave tables for another issue or do you want to fix it here.

          Also, offtopic, to test this.. I did a forum reply, and way really surprised about the BIG blank space reserved for the labels, it causes the editor to be shown crazily on the right, overlaping badly with the blocks there.

          Looking to CSS, it seems that we have 2 big margins being applied causing the enormous blank space.

          Show
          Eloy Lafuente (stronk7) added a comment - Adding example after applying David's patch. Really better than without it. Anyway I detected the problem with the tiny font size used by table contents I commented above. So, do you want me to push this and leave tables for another issue or do you want to fix it here. Also, offtopic, to test this.. I did a forum reply, and way really surprised about the BIG blank space reserved for the labels, it causes the editor to be shown crazily on the right, overlaping badly with the blocks there. Looking to CSS, it seems that we have 2 big margins being applied causing the enormous blank space.
          Hide
          David Scotson added a comment - - edited

          I think the table issue is best fixed by removing the CSS rule that sets them that size, which fixes it for all themes. It's possible to fix it in the editor.css but it's a hack that'll lead to the same confusion later (i.e. why does the editor have different settings from what I set in the theme). So that probably requires a new bug.

          For the padding in the forum. There was a change (MDL-39158) that was intended to increase the width of those labels at larger screen sizes. I think something must have gone wrong though as it never seems to use the smallest size (180px wide) even though it's defined in the CSS, instead it's set to use the middle size (200px wide) from 768px up to 979 pixels then the very widest setting (245px wide) from that point on, which is a bit aggressive I think. They probably should only kick in at higher levels.

          edit: although I still the think the above settings kick in too quickly and could probably be recalibrated it's probably worth noting that even at the default bootstrap size (i.e 160px width for the form labels, 20px thinner than the minimum we use) there's simply not enough room for the larger form elements on a netbook or horizontal-ipad screen (1024px) and two columns as well. Even with Standard theme some controls get cut off on the right hand side.

          Show
          David Scotson added a comment - - edited I think the table issue is best fixed by removing the CSS rule that sets them that size, which fixes it for all themes. It's possible to fix it in the editor.css but it's a hack that'll lead to the same confusion later (i.e. why does the editor have different settings from what I set in the theme). So that probably requires a new bug. For the padding in the forum. There was a change ( MDL-39158 ) that was intended to increase the width of those labels at larger screen sizes. I think something must have gone wrong though as it never seems to use the smallest size (180px wide) even though it's defined in the CSS, instead it's set to use the middle size (200px wide) from 768px up to 979 pixels then the very widest setting (245px wide) from that point on, which is a bit aggressive I think. They probably should only kick in at higher levels. edit: although I still the think the above settings kick in too quickly and could probably be recalibrated it's probably worth noting that even at the default bootstrap size (i.e 160px width for the form labels, 20px thinner than the minimum we use) there's simply not enough room for the larger form elements on a netbook or horizontal-ipad screen (1024px) and two columns as well. Even with Standard theme some controls get cut off on the right hand side.
          Hide
          Eloy Lafuente (stronk7) added a comment -

          So then, landing this and keeping the tables and margins problems apart? If so, I assume you'll create them.

          Show
          Eloy Lafuente (stronk7) added a comment - So then, landing this and keeping the tables and margins problems apart? If so, I assume you'll create them.
          Hide
          David Scotson added a comment -

          I've filed MDL-39591 for "Making the HTML editor more WYSIWYG" and asked in MDL-39158 if they want to re-open that to fix the label widths or create a new bug for the issue.

          Show
          David Scotson added a comment - I've filed MDL-39591 for "Making the HTML editor more WYSIWYG" and asked in MDL-39158 if they want to re-open that to fix the label widths or create a new bug for the issue.
          Hide
          Mary Evans added a comment -

          What I am getting at David is that yes it is OK to use Moodle CSS in the editor.css providing that's what it contains. I just doubted it, that's all.

          I hate the minified version of CSS. I also maintain it should be rendered in normal format for integration reviews and then only minified by the Integrators when finally merged into Moodle. But that another issue.

          Show
          Mary Evans added a comment - What I am getting at David is that yes it is OK to use Moodle CSS in the editor.css providing that's what it contains. I just doubted it, that's all. I hate the minified version of CSS. I also maintain it should be rendered in normal format for integration reviews and then only minified by the Integrators when finally merged into Moodle. But that another issue.
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Integrated, thanks!

          Show
          Eloy Lafuente (stronk7) added a comment - Integrated, thanks!
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Mary, feel free to open a new issue to discuss the need of producing un-minified versions of the css files, worth discussing it, IMO.

          Show
          Eloy Lafuente (stronk7) added a comment - Mary, feel free to open a new issue to discuss the need of producing un-minified versions of the css files, worth discussing it, IMO.
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Passing this as far as the attachment I added some comments above verify the editor body now uses the theme's face, size, color.

          Show
          Eloy Lafuente (stronk7) added a comment - Passing this as far as the attachment I added some comments above verify the editor body now uses the theme's face, size, color.
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Did you think this day was not going to arrive ever?

          Your patience has been rewarded, yay, sent upstream, thanks!

          Closing...ciao

          Show
          Eloy Lafuente (stronk7) added a comment - Did you think this day was not going to arrive ever? Your patience has been rewarded, yay, sent upstream, thanks! Closing...ciao

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              11 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: