Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.4.3, 2.5
    • Fix Version/s: 2.4.4
    • Component/s: Filepicker
    • Labels:
    • Testing Instructions:
      Hide
      1. Install RTL language
      2. Create a Folder resource, add files and folders there
      3. Make sure that files in filepicker (tree view) are displayed correctly
      4. Make sure the Folder resource is displayed correctly
      5. Switch to RTL language
      6. Repeat check in both filepicker and folder view

      In 2.5 check also in Clean theme

      Show
      Install RTL language Create a Folder resource, add files and folders there Make sure that files in filepicker (tree view) are displayed correctly Make sure the Folder resource is displayed correctly Switch to RTL language Repeat check in both filepicker and folder view In 2.5 check also in Clean theme
    • Affected Branches:
      MOODLE_24_STABLE, MOODLE_25_STABLE
    • Fixed Branches:
      MOODLE_24_STABLE
    • Pull Master Branch:
      wip-MDL-39436-master

      Description

      in RTL language Folder resource is displayed not properly

        Gliffy Diagrams

        1. after_clean.png
          7 kB
        2. after_standard.png
          6 kB
        3. before_clean.png
          7 kB
        4. before.png
          6 kB
        5. ltr_clean.png
          7 kB
        6. ltr_standard.png
          6 kB
        7. LTR.png
          149 kB
        8. RTL.png
          145 kB

          Issue Links

            Activity

            Hide
            Dan Poltawski added a comment -

            The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

            TIA and ciao

            Show
            Dan Poltawski added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
            Hide
            Dan Poltawski added a comment -

            Integrated to master and 24, thanks Marina

            Show
            Dan Poltawski added a comment - Integrated to master and 24, thanks Marina
            Hide
            Jason Fowler added a comment -

            Still issues present.

            Show
            Jason Fowler added a comment - Still issues present.
            Hide
            Jason Fowler added a comment -

            Issues are with the expand icon in the file picker, it isn't positioned correctly in Clean theme while an RTL language is in use.

            Compare RTL.png and LTR.png to see what I am talking about

            Show
            Jason Fowler added a comment - Issues are with the expand icon in the file picker, it isn't positioned correctly in Clean theme while an RTL language is in use. Compare RTL.png and LTR.png to see what I am talking about
            Hide
            Marina Glancy added a comment -

            Thanks Jason, that's a good catch
            I added commits to both branches to address it. Pls integrate

            Show
            Marina Glancy added a comment - Thanks Jason, that's a good catch I added commits to both branches to address it. Pls integrate
            Hide
            Damyon Wiese added a comment -

            Looking...

            Show
            Damyon Wiese added a comment - Looking...
            Hide
            Damyon Wiese added a comment -

            Thanks Marina,

            I pulled in the extra fixes and tested them on 24 and master. Looks ok to me - will send back to testing for final tick.

            Show
            Damyon Wiese added a comment - Thanks Marina, I pulled in the extra fixes and tested them on 24 and master. Looks ok to me - will send back to testing for final tick.
            Hide
            Jason Fowler added a comment -

            All working now Marina, Thanks!

            Show
            Jason Fowler added a comment - All working now Marina, Thanks!
            Hide
            Eloy Lafuente (stronk7) added a comment -

            Did you think this day was not going to arrive ever?

            Your patience has been rewarded, yay, sent upstream, thanks!

            Closing...ciao

            Show
            Eloy Lafuente (stronk7) added a comment - Did you think this day was not going to arrive ever? Your patience has been rewarded, yay, sent upstream, thanks! Closing...ciao

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: