Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-39443 META: OU Moodle 2.4 performance tuning
  3. MDL-39444

get_string calls clean_param A LOT and that is expensive

XMLWordPrintable

    • Icon: Sub-task Sub-task
    • Resolution: Fixed
    • Icon: Critical Critical
    • 2.3.7, 2.4.4
    • 2.3.6, 2.4.3, 2.5
    • Performance
    • MOODLE_23_STABLE, MOODLE_24_STABLE, MOODLE_25_STABLE
    • MOODLE_23_STABLE, MOODLE_24_STABLE
    • Hide

      1. Run all the unit tests.
      2. Poke around you Moodle site with developer debug off, and verify nothing is obviously broken.

      Show
      1. Run all the unit tests. 2. Poke around you Moodle site with developer debug off, and verify nothing is obviously broken.

      This seems to be a regression caused by MDL-22015.

      The clean_param is useful for developers, but we should not be paying that price in live use.

        1. after.png
          after.png
          3.80 MB
        2. before.png
          before.png
          4.19 MB

            timhunt Tim Hunt
            timhunt Tim Hunt
            Dan Poltawski Dan Poltawski
            Eloy Lafuente (stronk7) Eloy Lafuente (stronk7)
            Eloy Lafuente (stronk7) Eloy Lafuente (stronk7)
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated:
              Resolved:

                Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.