Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-39443 META: OU Moodle 2.4 performance tuning
  3. MDL-39445

Calling clean_param(, PARAM_PLUGIN) a lot is expensive

    XMLWordPrintable

    Details

    • Type: Sub-task
    • Status: Closed
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: 2.4.3
    • Fix Version/s: 2.3.7, 2.4.4, 2.5
    • Component/s: Performance
    • Labels:

      Description

      I am seeing 600 calls even when when logged in as student, and it hurts.

      It turns out that a separate is_valid_plugin_name function is a win.

        Attachments

        1. after.png
          after.png
          3.59 MB
        2. before.png
          before.png
          3.80 MB

          Activity

            People

            Assignee:
            timhunt Tim Hunt
            Reporter:
            timhunt Tim Hunt
            Peer reviewer:
            Dan Poltawski
            Integrator:
            Damyon Wiese
            Tester:
            Damyon Wiese
            Participants:
            Component watchers:
            Matteo Scaramuccia, Jake Dallimore, Jun Pataleta
            Votes:
            1 Vote for this issue
            Watchers:
            5 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              13/May/13