Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-39443 META: OU Moodle 2.4 performance tuning
  3. MDL-39445

Calling clean_param(, PARAM_PLUGIN) a lot is expensive

    XMLWordPrintable

Details

    • Sub-task
    • Status: Closed
    • Critical
    • Resolution: Fixed
    • 2.4.3
    • 2.3.7, 2.4.4, 2.5
    • Performance

    Description

      I am seeing 600 calls even when when logged in as student, and it hurts.

      It turns out that a separate is_valid_plugin_name function is a win.

      Attachments

        1. after.png
          after.png
          3.59 MB
        2. before.png
          before.png
          3.80 MB

        Activity

          People

            timhunt Tim Hunt
            timhunt Tim Hunt
            Dan Poltawski Dan Poltawski
            Damyon Wiese Damyon Wiese
            Damyon Wiese Damyon Wiese
            Matteo Scaramuccia, David Woloszyn, Huong Nguyen, Jake Dallimore, Michael Hawkins, Stevani Andolo
            Votes:
            1 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:
              13/May/13