[MDL-39445] Calling clean_param(, PARAM_PLUGIN) a lot is expensive - Moodle Tracker

XML

Word

Printable

Affected Branches:
MOODLE_24_STABLE
Fixed Branches:
MOODLE_23_STABLE, MOODLE_24_STABLE, MOODLE_25_STABLE
Pull from Repository:
git://github.com/timhunt/moodle.git
Pull Master Branch:
~~MDL-39445~~
Pull Master Diff URL:
https://github.com/timhunt/moodle/compare/master...MDL-39445
Testing Instructions:

Hide

1. Run the unit tests.

2. Poke around a bit to make sure nothing is obviously broken in Moodle

Show
1. Run the unit tests. 2. Poke around a bit to make sure nothing is obviously broken in Moodle

I am seeing 600 calls even when when logged in as student, and it hurts.

It turns out that a separate is_valid_plugin_name function is a win.

Participants:: Damyon Wiese, Dan Poltawski, Eloy Lafuente (stronk7), Tim Hunt

Component watchers:: Matteo Scaramuccia, David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo