Details
-
Type:
Sub-task
-
Status: Closed
-
Priority:
Major
-
Resolution: Fixed
-
Affects Version/s: 2.4.3
-
Fix Version/s: 2.5
-
Component/s: Course, Forum, Performance
-
Labels:
-
Testing Instructions:
- Exploratory testing around all course/forum pages which you can think of, including social course format etc
-
Affected Branches:MOODLE_24_STABLE
-
Fixed Branches:MOODLE_25_STABLE
-
Pull from Repository:
-
Pull Master Branch:
-
Pull Master Diff URL:
Description
forum lib.php is badly written. It is huge and requires a lot of other library code.
(Probably a lot of code there should be moved to locallib.php.)
Anwyay, it is not a problem for us, since we don't use forum.php, so it is disappoining to see forum lib.php showing up in our profiling as 2% of the page-load time.
This simple patch seems to fix it, but it might cause regressions.
Attachments
Issue Links
- has been marked as being related by
-
MDL-39583 mod/forum/lib.php should require_once mod/forum/post_form.php less liberally
-
- Closed
-