[MDL-39450] Terrible performance in the course format code - Moodle Tracker

XML

Word

Printable

Affected Branches:
MOODLE_24_STABLE
Fixed Branches:
MOODLE_24_STABLE
Pull from Repository:
git://github.com/timhunt/moodle.git
Pull Master Branch:
~~MDL-39450~~
Pull Master Diff URL:
https://github.com/timhunt/moodle/compare/master...MDL-39450
Testing Instructions:
Hide

1. Run the unit tests.

2. Do some basic CRUD operations on some courses in a range of formats, to ensure there are not obvious regressions.

Test 3 (performance):

Create course in topics format (having the default format weeks)

View the course, make sure that performance info on course/view.php is better than before change
Show
1. Run the unit tests. 2. Do some basic CRUD operations on some courses in a range of formats, to ensure there are not obvious regressions. Test 3 (performance): Create course in topics format (having the default format weeks) View the course, make sure that performance info on course/view.php is better than before change

There are hundreds of calls to format_base::instance on a typical course, and that function is very expensive (despite its internal caching).

has a non-specific relationship to

MDL-35727 use MUC for caching of format_base instances

Participants:: Andrew Davis, Damyon Wiese, Dan Poltawski, Eloy Lafuente (stronk7), Gareth J Barnard, Marina Glancy, Tim Hunt

Component watchers:: Amaia Anabitarte, Bas Brands, Carlos Escobedo, Laurent David, Raquel Ortega, Sabina Abellan, Sara Arjona (@sarjona)