Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-39443 META: OU Moodle 2.4 performance tuning
  3. MDL-39454

is_siteadmin gets called repeatedly, is a bit slow

    XMLWordPrintable

    Details

    • Type: Sub-task
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.4.3
    • Fix Version/s: 2.4.5, 2.5.1
    • Component/s: Roles / Access
    • Labels:
    • Testing Instructions:
      Hide

      1. View a course page when logged in as admin. Verify that there are no errors and that you have full access to course options e.g. the 'turn editing on' button.

      2. Log in as a student and view the same page. Verify that there are no errors and that you do not have the 'turn editing on' button/option.

      Show
      1. View a course page when logged in as admin. Verify that there are no errors and that you have full access to course options e.g. the 'turn editing on' button. 2. Log in as a student and view the same page. Verify that there are no errors and that you do not have the 'turn editing on' button/option.
    • Affected Branches:
      MOODLE_24_STABLE
    • Fixed Branches:
      MOODLE_24_STABLE, MOODLE_25_STABLE
    • Pull Master Branch:
      MDL-39454-master

      Description

      In a typical page request, is_siteadmin gets called more than 200 times. In my profiling this takes about 5ms.

      The function is not very efficient. I am investigating two approaches to improve performance with the aim of saving a couple of milliseconds.

        Attachments

          Activity

            People

            Assignee:
            quen Sam Marshall
            Reporter:
            quen Sam Marshall
            Integrator:
            Sam Hemelryk
            Tester:
            Jason Fowler
            Participants:
            Component watchers:
            Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Sara Arjona (@sarjona)
            Votes:
            1 Vote for this issue
            Watchers:
            6 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              8/Jul/13