Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-39470

Component not specified in get_string call.

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.4.3, 2.5
    • Fix Version/s: 2.4.4
    • Component/s: Caching
    • Labels:
      None
    • Testing Instructions:
      Hide

      Test 1

      1. Log in as an administrator.
      2. Visit the page yoursite/cache/admin.php.
      3. Scroll down to 'Summary of cache lock instances' and add a new lock instance with the name 'lockname'.
      4. Once added scroll down to the same section and click on the 'Delete' link.
      5. In the URL change 'lock=lockname' to 'lock=invalidlock' and click enter to visit the altered URL.
      6. Check that a message notifying you that you entered an invalid lock appears rather than '[[invalidlock]]'.

      Test 2

      1. Log in as an administrator.
      2. Visit the page yoursite/cache/admin.php.
      3. Click on the link 'Add instance', enter 'storename' as the Store name then click 'Save changes'.
      4. Under 'Configured store instances' click on 'Delete store' next to the newly created store.
      5. In the URL change 'store=storename' to 'store=invalidstore' and click enter to visit the altered URL.
      6. Check that a message notifying you that you entered an invalid store appears rather than '[[invalidstore]]'.
      Show
      Test 1 Log in as an administrator. Visit the page yoursite/cache/admin.php. Scroll down to 'Summary of cache lock instances' and add a new lock instance with the name 'lockname'. Once added scroll down to the same section and click on the 'Delete' link. In the URL change 'lock=lockname' to 'lock=invalidlock' and click enter to visit the altered URL. Check that a message notifying you that you entered an invalid lock appears rather than '[ [invalidlock] ]'. Test 2 Log in as an administrator. Visit the page yoursite/cache/admin.php. Click on the link 'Add instance', enter 'storename' as the Store name then click 'Save changes'. Under 'Configured store instances' click on 'Delete store' next to the newly created store. In the URL change 'store=storename' to 'store=invalidstore' and click enter to visit the altered URL. Check that a message notifying you that you entered an invalid store appears rather than '[ [invalidstore] ]'.
    • Affected Branches:
      MOODLE_24_STABLE, MOODLE_25_STABLE
    • Fixed Branches:
      MOODLE_24_STABLE
    • Pull Master Branch:
      MDL-39470_master

      Description

      Missing component in get_string call means string does not display.

        Gliffy Diagrams

          Issue Links

            Activity

            Hide
            markn Mark Nelson added a comment -

            My github is playing up, so will push fix tomorrow.

            Show
            markn Mark Nelson added a comment - My github is playing up, so will push fix tomorrow.
            Hide
            poltawski Dan Poltawski added a comment -

            There was an instance of this in 2.4 too. I created a patch for it and integrated both.

            Show
            poltawski Dan Poltawski added a comment - There was an instance of this in 2.4 too. I created a patch for it and integrated both.
            Hide
            phalacee Jason Fowler added a comment -

            All good Mark

            Show
            phalacee Jason Fowler added a comment - All good Mark
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            Did you think this day was not going to arrive ever?

            Your patience has been rewarded, yay, sent upstream, thanks!

            Closing...ciao

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - Did you think this day was not going to arrive ever? Your patience has been rewarded, yay, sent upstream, thanks! Closing...ciao

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  13/May/13