Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-39443 META: OU Moodle 2.4 performance tuning
  3. MDL-39472

cache::get_from_persist_cache could be optimised

    XMLWordPrintable

    Details

    • Type: Sub-task
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.4.3
    • Fix Version/s: 2.4.5, 2.5.1
    • Component/s: Caching
    • Labels:
    • Testing Instructions:
      Hide

      (This is a 'check it isn't broken' test as there should be no functional change.)

      1. Browse around a few pages of the site including a course view page.
      2. Turn on the performance information and check that the cache information shown at the bottom of the page still looks plausible.

      Show
      (This is a 'check it isn't broken' test as there should be no functional change.) 1. Browse around a few pages of the site including a course view page. 2. Turn on the performance information and check that the cache information shown at the bottom of the page still looks plausible.
    • Affected Branches:
      MOODLE_24_STABLE
    • Fixed Branches:
      MOODLE_24_STABLE, MOODLE_25_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-39472-master
    • Pull Master Diff URL:

      Description

      The get_from_persist_cache function could benefit from optimisations:

      1) Where perfdebug is turned on (some live sites used this option), record_cache_hit takes an annoyingly long time.
      2) Micro-optimisations could improve performance of the main function.

      I'll give details in comments.

        Attachments

          Activity

            People

            Assignee:
            quen Sam Marshall
            Reporter:
            quen Sam Marshall
            Peer reviewer:
            Sam Hemelryk
            Integrator:
            Dan Poltawski
            Tester:
            Dan Poltawski
            Participants:
            Component watchers:
            Matteo Scaramuccia, Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Sara Arjona (@sarjona)
            Votes:
            1 Vote for this issue
            Watchers:
            5 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              8/Jul/13