Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-39443 META: OU Moodle 2.4 performance tuning
  3. MDL-39473

cache::parse_key: supports_multiple_identifiers check a bit slow

    XMLWordPrintable

    Details

    • Type: Sub-task
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.4.3
    • Fix Version/s: 2.4.4
    • Component/s: Caching
    • Labels:
      None

      Description

      The cache::parse_key function takes a fair chunk of time (in my test page it is called 482 times). As part of the MUC infrastructure this should be optimised.

      I didn't find very much wrong with it, but a small detail is that the supports_multiple_identifiers check takes a significant amount of time. It is possible to optimise this (albeit with some duplication) by overriding the function in each of the cache store types for which it always has a fixed value anyway. (I left the mongodb cache alone, because that one's more complicated.)

        Attachments

          Activity

            People

            • Assignee:
              quen Sam Marshall
              Reporter:
              quen Sam Marshall
              Peer reviewer:
              Sam Hemelryk
              Integrator:
              Dan Poltawski
              Tester:
              Dan Poltawski
              Participants:
              Component watchers:
              Matteo Scaramuccia, Amaia Anabitarte, Bas Brands, Carlos Escobedo, Sara Arjona (@sarjona), Víctor Déniz Falcón
            • Votes:
              1 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Fix Release Date:
                13/May/13