Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-39477

Create data generators for repositories

    Details

      Description

      To simplify the creation of repository types and instances.

        Gliffy Diagrams

          Issue Links

            Activity

            Hide
            fred Frédéric Massart added a comment -

            Ping!

            Show
            fred Frédéric Massart added a comment - Ping!
            Hide
            fred Frédéric Massart added a comment -

            Hi Andrew Davis, are you still reviewing this?

            Show
            fred Frédéric Massart added a comment - Hi Andrew Davis , are you still reviewing this?
            Hide
            poltawski Dan Poltawski added a comment -

            Hi Fred,

            Another problem detected with this, is that lib/testing/generator/repository_generator.php requires MOODLE_INTERNAL. We can't have that for the behat environment.

            Show
            poltawski Dan Poltawski added a comment - Hi Fred, Another problem detected with this, is that lib/testing/generator/repository_generator.php requires MOODLE_INTERNAL. We can't have that for the behat environment.
            Hide
            poltawski Dan Poltawski added a comment -

            Discovered in MDL-39702

            Show
            poltawski Dan Poltawski added a comment - Discovered in MDL-39702
            Hide
            dmonllao David Monllaó added a comment -

            I guess same problem with phpunit, generators are required before including config.php & lib/setup.php

            Show
            dmonllao David Monllaó added a comment - I guess same problem with phpunit, generators are required before including config.php & lib/setup.php
            Hide
            fred Frédéric Massart added a comment -

            Thanks, I removed the MOODLE_INTERAL checks.

            Show
            fred Frédéric Massart added a comment - Thanks, I removed the MOODLE_INTERAL checks.
            Hide
            damyon Damyon Wiese added a comment -

            Adding integration_held to this issue - I commented on MDL-38498 that the master only changes for that issue should be incorporated into this one (or both issues will have to wait until after the on-sync period).

            Show
            damyon Damyon Wiese added a comment - Adding integration_held to this issue - I commented on MDL-38498 that the master only changes for that issue should be incorporated into this one (or both issues will have to wait until after the on-sync period).
            Hide
            poltawski Dan Poltawski added a comment -

            I don't think this should be master only

            Show
            poltawski Dan Poltawski added a comment - I don't think this should be master only
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            So MDL-39702 will be re-adding the MOODLE_INTERNAL check to this (coz we have changed the way to require that stuff in behat).

            Is there any reason for having this held and/or not backporting it to 25_STABLE ? I don't get it.

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - So MDL-39702 will be re-adding the MOODLE_INTERNAL check to this (coz we have changed the way to require that stuff in behat). Is there any reason for having this held and/or not backporting it to 25_STABLE ? I don't get it.
            Hide
            poltawski Dan Poltawski added a comment -

            Yep, +1 for 25_STABLE too?

            Show
            poltawski Dan Poltawski added a comment - Yep, +1 for 25_STABLE too?
            Hide
            damyon Damyon Wiese added a comment -

            Thanks Fred,

            This issue has been integrated to 25 and master.

            Note: at the last integrators meeting we agreed on a new principal that has been applied here. See integration principal 6 on:

            http://docs.moodle.org/dev/Integration_Review

            I updated the @since tags because this was backported and removed a couple of unused variables.

            I've tested this (unit tests) on master and 25 branches, so I'll pass the test.

            Show
            damyon Damyon Wiese added a comment - Thanks Fred, This issue has been integrated to 25 and master. Note: at the last integrators meeting we agreed on a new principal that has been applied here. See integration principal 6 on: http://docs.moodle.org/dev/Integration_Review I updated the @since tags because this was backported and removed a couple of unused variables. I've tested this (unit tests) on master and 25 branches, so I'll pass the test.
            Hide
            damyon Damyon Wiese added a comment -

            Ran unit tests for both branches in integration. All good.

            Show
            damyon Damyon Wiese added a comment - Ran unit tests for both branches in integration. All good.
            Hide
            damyon Damyon Wiese added a comment -

            Thanks for your hard work. This issue has now been sent upstream and will soon be downloaded by millions of Moodlers!

            Regards, Damyon

            Show
            damyon Damyon Wiese added a comment - Thanks for your hard work. This issue has now been sent upstream and will soon be downloaded by millions of Moodlers! Regards, Damyon

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  8/Jul/13