Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-39478

Use a constant instead of !empty($CFG->originaldataroot)

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      You need PHP 5.4 to run this test.

      1. Install and enable your test environment (php admin/tool/behat/cli/init.php)
      2. Start your PHP 5.4 built-in server, no $CFG->behat_switchcompletely allowed here
      3. Check your wwwroot, you SHOULD see your normal moodle site
      4. Check localhost:8000 (or $CFG->behat_wwwroot is you specified something else) you SHOULD see your behat test site
      5. Disable your test environment (php admin/tool/behat/cli/util.php --disable)
      6. Check localhost:8000 (or $CFG->behat_wwwroot is you specified something else) you SHOULD see a message and be redirected to your wwwroot where you SHOULD see your normal moodle site
      7. Edit your config.php and add $CFG->behat_switchcompletely = true before the lib/setup.php require
      8. Check your wwwroot, you SHOULD see your normal moodle site
      9. Enable your behat test environment (php admin/tool/behat/cli/util.php --enable)
      10. Check your wwwroot, you SHOULD see your behat test site
      Show
      You need PHP 5.4 to run this test. Install and enable your test environment ( php admin/tool/behat/cli/init.php ) Start your PHP 5.4 built-in server, no $CFG->behat_switchcompletely allowed here Check your wwwroot, you SHOULD see your normal moodle site Check localhost:8000 (or $CFG->behat_wwwroot is you specified something else) you SHOULD see your behat test site Disable your test environment ( php admin/tool/behat/cli/util.php --disable ) Check localhost:8000 (or $CFG->behat_wwwroot is you specified something else) you SHOULD see a message and be redirected to your wwwroot where you SHOULD see your normal moodle site Edit your config.php and add $CFG->behat_switchcompletely = true before the lib/setup.php require Check your wwwroot, you SHOULD see your normal moodle site Enable your behat test environment ( php admin/tool/behat/cli/util.php --enable ) Check your wwwroot, you SHOULD see your behat test site
    • Affected Branches:
      MOODLE_25_STABLE
    • Fixed Branches:
      MOODLE_25_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-39478_master
    • Pull Master Diff URL:

      Description

      This should have been addressed from the beginning, but there were not many places where we were controlling if the behat test site is being used and BEHAT_RUNNING is similar, we need to create a constant with an identifier name according to what it does

        Attachments

          Issue Links

          Discovered while testing

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-39552 Make the behat section of setup.php re-entrant safe

          • Minor - Minor loss of function where workaround is possible
          • Closed
          Testing discovered

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-38041 Fail behat tests when exceptions or debugging() messages are thrown

          • Major - Major loss of function, incorrect output
          • Closed

            Activity

              People

              Assignee:
              dmonllao David Monllaó
              Reporter:
              dmonllao David Monllaó
              Integrator:
              Eloy Lafuente (stronk7) Eloy Lafuente (stronk7)
              Tester:
              Eloy Lafuente (stronk7) Eloy Lafuente (stronk7)
              Participants:
              Component watchers:
              Andrew Lyons, Dongsheng Cai, Huong Nguyen, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                14/May/13