Moodle
  1. Moodle
  2. MDL-39487

ID number of assignment grade item changes

    Details

    • Testing Instructions:
      Hide
      1. Create/edit and assignment and set the ID number to "A".
      2. Edit the grade item of the assignment (in Grades -> Categories and items -> Simple view). The ID number is "A".
      3. Edit a submission as a student or grade a submission as a teacher.
      4. Edit the assignment settings. Verify the ID number is still 'A'.
      5. Edit the grade item of the assignment. Verify the ID number is still 'A'.
      Show
      Create/edit and assignment and set the ID number to "A". Edit the grade item of the assignment (in Grades -> Categories and items -> Simple view). The ID number is "A". Edit a submission as a student or grade a submission as a teacher. Edit the assignment settings. Verify the ID number is still 'A'. Edit the grade item of the assignment. Verify the ID number is still 'A'.
    • Affected Branches:
      MOODLE_23_STABLE, MOODLE_24_STABLE, MOODLE_25_STABLE, MOODLE_26_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE, MOODLE_24_STABLE, MOODLE_25_STABLE
    • Pull from Repository:
    • Pull 2.4 Branch:
    • Pull Master Branch:
      MDL-39487_master
    • Rank:
      50154

      Description

      The ID number of assignment grades items is overwritten every time a student edits a submission or a teacher grades a submission. Only the ID number of the grade item changes, the ID number of the assignment does not.

      Steps to reproduce:

      1. Create/edit and assignment and set the ID number to "A".
      2. Edit the grade item of the assignment (in Grades -> Categories and items -> Simple view). The ID number is "A".
      3. Edit a submission as a student or grade a submission as a teacher.
      4. Edit the assignment settings. The ID number is still 'A'.
      5. Edit the grade item of the assignment. The ID number is set to a number.

      I've traced the bug to function gradebook_item_update of mod/assign/locallib.php. It updates the grade item, using the course module id as id number.

        Activity

        Hide
        Damyon Wiese added a comment -

        This issue was assigned to me automatically, however I will not be able to work on this issue in the immediate future. In order to create a truer sense of the state of this issue and to allow other developers to have chance to become involved, I am removing myself as the assignee of this issue.

        For more information, see http://docs.moodle.org/dev/Changes_to_issue_assignment

        Show
        Damyon Wiese added a comment - This issue was assigned to me automatically, however I will not be able to work on this issue in the immediate future. In order to create a truer sense of the state of this issue and to allow other developers to have chance to become involved, I am removing myself as the assignee of this issue. For more information, see http://docs.moodle.org/dev/Changes_to_issue_assignment
        Hide
        Damyon Wiese added a comment -

        Thanks Albert,

        This change looks perfect to me. Sending for integration.

        Show
        Damyon Wiese added a comment - Thanks Albert, This change looks perfect to me. Sending for integration.
        Hide
        Eloy Lafuente (stronk7) added a comment -

        Integrated (23, 24, 25 - by cherrypick - and master), thanks!

        Show
        Eloy Lafuente (stronk7) added a comment - Integrated (23, 24, 25 - by cherrypick - and master), thanks!
        Hide
        Andrew Davis added a comment -

        Works as described. Passing.

        Show
        Andrew Davis added a comment - Works as described. Passing.
        Hide
        Dan Poltawski added a comment -
        Feature: Thanks to our superb contributors
          In order to make Moodle better
          As an integrator
          I need to thank all our contributors
        
          Scenario: Dan thanks you all
            Given I log in as "dan"
            And I see "lots of fixed issues"
            When I follow "Close integrated issues"
            Then I should see "Lots of thanks to all our contributors"
        

        Your changes are upstream

        Show
        Dan Poltawski added a comment - Feature: Thanks to our superb contributors In order to make Moodle better As an integrator I need to thank all our contributors Scenario: Dan thanks you all Given I log in as "dan" And I see "lots of fixed issues" When I follow "Close integrated issues" Then I should see "Lots of thanks to all our contributors" Your changes are upstream

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: