Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-38856 META: Issues around Bootstrapbase and Clean theme
  3. MDL-39499

Two singlebuttons in a row sit on top of each other

          Details

          • Type: Sub-task
          • Status: Closed
          • Priority: Minor
          • Resolution: Fixed
          • Affects Version/s: 2.5
          • Fix Version/s: 2.5
          • Component/s: HTML and CSS
          • Labels:
          • Testing Instructions:
            Hide

            Change your theme to "Clean".

            Go to /admin/purgecaches.php

            The buttons that say "purge all caches" and "cancel" should be on the same row horizontally, not on top of each other vertically.

            Show
            Change your theme to "Clean". Go to /admin/purgecaches.php The buttons that say "purge all caches" and "cancel" should be on the same row horizontally, not on top of each other vertically.
          • Affected Branches:
            MOODLE_25_STABLE
          • Fixed Branches:
            MOODLE_25_STABLE
          • Pull from Repository:
          • Pull Master Branch:
            wip-MDL-39499-master
          • Pull Master Diff URL:

            Description

            For some dialogue boxes moodle puts two "singlebuttons" next to each other.

            Currently the sit on a row each. This change makes them sit next to each other as you would expect from OK/Cancel type dialogue buttons.

              Gliffy Diagrams

                Attachments

                  Issue Links

                  Discovered while testing

                  Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-39500 Review comments in .less files

                  • Minor - Minor loss of function where workaround is possible
                  • Closed

                    Activity

                    Ascending order - Click to sort in descending order
                    Hide
                    Permalink
                    andyjdavis Andrew Davis added a comment -

                    I've raised and linked an MDL to look at comments in .less files. I'm not quite sure how that works or if there's even a problem there. We can look at that in a separate issue.

                    As we're trying to get issues into integration quickly I've also gone ahead and fixed up the testing instructions. Bear in mind that the tester will be running the code on their own computer to verify the fix.

                    Putting this up for integration.

                    Show
                    andyjdavis Andrew Davis added a comment - I've raised and linked an MDL to look at comments in .less files. I'm not quite sure how that works or if there's even a problem there. We can look at that in a separate issue. As we're trying to get issues into integration quickly I've also gone ahead and fixed up the testing instructions. Bear in mind that the tester will be running the code on their own computer to verify the fix. Putting this up for integration.
                    Hide
                    Permalink
                    andyjdavis Andrew Davis added a comment -

                    Note for the integrators. If the comment style in the commit is incorrect, there are other commits in the file using the same style.

                    Show
                    andyjdavis Andrew Davis added a comment - Note for the integrators. If the comment style in the commit is incorrect, there are other commits in the file using the same style.
                    Hide
                    Permalink
                    samhemelryk Sam Hemelryk added a comment -

                    Thanks guys, this has been integrated now.

                    Show
                    samhemelryk Sam Hemelryk added a comment - Thanks guys, this has been integrated now.
                    Hide
                    Permalink
                    samhemelryk Sam Hemelryk added a comment -

                    Tested during integration review and passed.

                    Show
                    samhemelryk Sam Hemelryk added a comment - Tested during integration review and passed.
                    Hide
                    Permalink
                    stronk7 Eloy Lafuente (stronk7) added a comment -

                    Did you think this day was not going to arrive ever?

                    Your patience has been rewarded, yay, sent upstream, thanks!

                    Closing...ciao

                    Show
                    stronk7 Eloy Lafuente (stronk7) added a comment - Did you think this day was not going to arrive ever? Your patience has been rewarded, yay, sent upstream, thanks! Closing...ciao

                      People

                      • Votes:
                        0 Vote for this issue
                        Watchers:
                        3 Start watching this issue

                        Dates

                        • Created:
                          Updated:
                          Resolved:
                          Fix Release Date:
                          14/May/13