Moodle
  1. Moodle
  2. MDL-39508

Some standard CORE themes do not display SCORM navigation drop down properly

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.4.3
    • Fix Version/s: 2.5
    • Component/s: Themes
    • Labels:
    • Testing Instructions:
      Hide

      This should fix all CORE themes that use Canvas as parent theme, so test only those themes which are: arialist, binarius, boxxie, brick, formfactor, formal_white, fusion, leatherbound, magazine, nimble, nonzero, overlay, sky_high, serenity, splash:

      1. Login as a teacher.
      2. Update a SCORM activity and set 'Display course structure in player' to 'In a dropdown menu'.
      3. Check that the SCORM table of contents is displayed in a dropdown menu properly.
        MDLQA-5332 has screenshots of the issue.
      Show
      This should fix all CORE themes that use Canvas as parent theme, so test only those themes which are: arialist, binarius, boxxie, brick, formfactor, formal_white, fusion, leatherbound, magazine, nimble, nonzero, overlay, sky_high, serenity, splash: Login as a teacher. Update a SCORM activity and set 'Display course structure in player' to 'In a dropdown menu'. Check that the SCORM table of contents is displayed in a dropdown menu properly. MDLQA-5332 has screenshots of the issue.
    • Affected Branches:
      MOODLE_24_STABLE
    • Fixed Branches:
      MOODLE_25_STABLE
    • Pull Master Branch:
      MDL-39508_master

      Description

      1. Login as a teacher, update a SCORM activity and set 'Display course structure in player' under 'Display settings (Show more...)' to Hidden.
      2. Check that the SCORM table of contents is no longer displayed on the SCORM outline page.
      3. Update the SCORM activity and set 'Display course structure in player' to 'In a dropdown menu'.
      4. Check that the SCORM table of contents is displayed in a dropdown menu properly.
      MDLQA-5332 has screenshots of the issue.

        Gliffy Diagrams

          Issue Links

            Activity

            Hide
            Michael de Raadt added a comment -

            This issue was raised during a QA test, but through later discussion it was decided that this was not a significant enough issue to block a release.

            I've adjusted the priority accordingly and hopefully we will be able to get to this issue soon.

            Show
            Michael de Raadt added a comment - This issue was raised during a QA test, but through later discussion it was decided that this was not a significant enough issue to block a release. I've adjusted the priority accordingly and hopefully we will be able to get to this issue soon.
            Hide
            Mary Evans added a comment -

            Can anyone tell me if the same SCORM package works in ALL other Canvas based theme or is this JUST a leatherbound BUG?

            Also, so that I can jet a hold of the problem can I test it in the QA site? It would be easier fo me to find a fix if it was. Thanks

            Show
            Mary Evans added a comment - Can anyone tell me if the same SCORM package works in ALL other Canvas based theme or is this JUST a leatherbound BUG? Also, so that I can jet a hold of the problem can I test it in the QA site? It would be easier fo me to find a fix if it was. Thanks
            Hide
            Jasmin Klindzic added a comment -

            Mary, AL Rachels tested some other themes (and it works with them) while testing MDLQA-5332, you can check it out here (screenshots available): https://tracker.moodle.org/browse/MDLQA-5332

            Show
            Jasmin Klindzic added a comment - Mary, AL Rachels tested some other themes (and it works with them) while testing MDLQA-5332 , you can check it out here (screenshots available): https://tracker.moodle.org/browse/MDLQA-5332
            Hide
            Mary Evans added a comment -

            Test instructions are aimed as a SCORM Admin! not a Dummy like me! LOL

            Show
            Mary Evans added a comment - Test instructions are aimed as a SCORM Admin! not a Dummy like me! LOL
            Hide
            Mary Evans added a comment -

            OK...I think I have it fixed now...in my head at least!

            Thanks

            Show
            Mary Evans added a comment - OK...I think I have it fixed now...in my head at least! Thanks
            Hide
            Mary Evans added a comment -

            So I don't forget:
            The CSS path to this is as follows:

            html.yui3-js-enabled body#page-mod-scorm-player.format-weeks div#page div#page-content-wrapper.wrapper div#page-content div#region-main-box div#region-post-box div#region-main-wrap div#region-main div.region-content div div#scormpage div#tocbox div#scormtop div#scormnav.scorm-right div.singleselect form#tocmenu div select#single_select5187eddbe3ba31.select

            Leatherbound adds a 1em margin top and bottom to the single_select form element and so pushes it behind the SCORM player.

            Show
            Mary Evans added a comment - So I don't forget: The CSS path to this is as follows: html.yui3-js-enabled body#page-mod-scorm-player.format-weeks div#page div#page-content-wrapper.wrapper div#page-content div#region-main-box div#region-post-box div#region-main-wrap div#region-main div.region-content div div#scormpage div#tocbox div#scormtop div#scormnav.scorm-right div.singleselect form#tocmenu div select#single_select5187eddbe3ba31.select Leatherbound adds a 1em margin top and bottom to the single_select form element and so pushes it behind the SCORM player.
            Hide
            Mary Evans added a comment - - edited

            I'm finding that this is OK in Base theme, Afterburner and Anomaly, but has a problem with all the other standard themes that inherit a setting from Canvas theme for .singleselect that adds a 1em margin to that dropdown menu. So really the original test should have failed. I think that is what the thought was at the time. The fix needs to go into Canvas theme, which in turn will fix all the other themes.

            Show
            Mary Evans added a comment - - edited I'm finding that this is OK in Base theme, Afterburner and Anomaly, but has a problem with all the other standard themes that inherit a setting from Canvas theme for .singleselect that adds a 1em margin to that dropdown menu. So really the original test should have failed. I think that is what the thought was at the time. The fix needs to go into Canvas theme, which in turn will fix all the other themes.
            Hide
            Dan Poltawski added a comment -

            Integrated to master, thanks Mary

            Show
            Dan Poltawski added a comment - Integrated to master, thanks Mary
            Hide
            Ankit Agarwal added a comment -

            tested all themes mentioned in the instructions, they all show the drop down correctly now.
            Passing
            Thanks

            Show
            Ankit Agarwal added a comment - tested all themes mentioned in the instructions, they all show the drop down correctly now. Passing Thanks
            Hide
            David Monllaó added a comment -

            Passing according to Ankit's comments, probably he forgot pressing the button

            Show
            David Monllaó added a comment - Passing according to Ankit's comments, probably he forgot pressing the button
            Hide
            Mary Evans added a comment -

            Show
            Mary Evans added a comment -
            Hide
            Eloy Lafuente (stronk7) added a comment -

            Did you think this day was not going to arrive ever?

            Your patience has been rewarded, yay, sent upstream, thanks!

            Closing...ciao

            Show
            Eloy Lafuente (stronk7) added a comment - Did you think this day was not going to arrive ever? Your patience has been rewarded, yay, sent upstream, thanks! Closing...ciao

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: