Moodle
  1. Moodle
  2. MDL-39518

Switch all references from MOOCH to Moodle.net.

    Details

    • Type: Task Task
    • Status: Closed
    • Priority: Blocker Blocker
    • Resolution: Fixed
    • Affects Version/s: 2.2.9, 2.3.6, 2.4.3, 2.5
    • Fix Version/s: 2.3.7, 2.4.4
    • Component/s: Hub
    • Labels:
    • Testing Instructions:
      Hide

      Visit the site administration -> registration page. Verify that it says Moodle.net everywhere and not MOOCH.

      Visit the site administration -> server -> hubs page. Verify that it says Moodle.net everywhere and not MOOCH.

      Show
      Visit the site administration -> registration page. Verify that it says Moodle.net everywhere and not MOOCH. Visit the site administration -> server -> hubs page. Verify that it says Moodle.net everywhere and not MOOCH.
    • Affected Branches:
      MOODLE_22_STABLE, MOODLE_23_STABLE, MOODLE_24_STABLE, MOODLE_25_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE, MOODLE_24_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-39518-master

      Description

      Browse the code and switch all references from MOOCH to Moodle.net

        Gliffy Diagrams

          Issue Links

            Activity

            Hide
            Helen Foster added a comment -

            Just noting that I am changing all references to MOOCH in en lang strings to Moodle.net in the en_fix language pack, which is due to be merged with the en lang pack sometime this week.

            Show
            Helen Foster added a comment - Just noting that I am changing all references to MOOCH in en lang strings to Moodle.net in the en_fix language pack, which is due to be merged with the en lang pack sometime this week.
            Hide
            Helen Foster added a comment -

            Strings which I was unable to change because I couldn't find them in core_admin, core_hub or local_hub are:

            • 'Unregister from MOOCH'
            • 'You are now registered on the hub MOOCH.'
            • Under Hubs with which you are registered is listed 'Moodle.org (MOOCH)'
            Show
            Helen Foster added a comment - Strings which I was unable to change because I couldn't find them in core_admin, core_hub or local_hub are: 'Unregister from MOOCH' 'You are now registered on the hub MOOCH.' Under Hubs with which you are registered is listed 'Moodle.org (MOOCH)'
            Hide
            Helen Foster added a comment -

            MOOCH now changed to Moodle.net in http://docs.moodle.org/24/en and http://docs.moodle.org/25/en.

            Show
            Helen Foster added a comment - MOOCH now changed to Moodle.net in http://docs.moodle.org/24/en and http://docs.moodle.org/25/en .
            Hide
            Michael de Raadt added a comment -

            It looks like this has to happen for 2.5, so I'm bumping this to a blocker.

            Show
            Michael de Raadt added a comment - It looks like this has to happen for 2.5, so I'm bumping this to a blocker.
            Hide
            Jérôme Mouneyrac added a comment -

            Helen I haven't seen any lang changes these last days. From doing a quick search there are no Moodle.net strings in master yet. Can you find out when they should land? Note that I don't know about AMOS/lang/en_fix integration process. From reading http://docs.moodle.org/dev/Release_process#For_a_stable_release_on_an_existing_branch_XY_with_point_value_Z_.28eg._X.Y.Z.29 it has to be done manually. I'll ask David in the meanwhile.

            Show
            Jérôme Mouneyrac added a comment - Helen I haven't seen any lang changes these last days. From doing a quick search there are no Moodle.net strings in master yet. Can you find out when they should land? Note that I don't know about AMOS/lang/en_fix integration process. From reading http://docs.moodle.org/dev/Release_process#For_a_stable_release_on_an_existing_branch_XY_with_point_value_Z_.28eg._X.Y.Z.29 it has to be done manually. I'll ask David in the meanwhile.
            Hide
            Damyon Wiese added a comment -

            These 3 strings insert the name of the Hub:

            'Unregister from MOOCH'
            'You are now registered on the hub MOOCH.'
            Under Hubs with which you are registered is listed 'Moodle.org (MOOCH)'

            So changing the hub name should be enough to change those 3 strings.

            Re - en_fix - it was merged to stables on the 6th (MDL-38352) and the strings still say MOOCH - so I think we will have to change this directly (or remerge en_fix).

            Show
            Damyon Wiese added a comment - These 3 strings insert the name of the Hub: 'Unregister from MOOCH' 'You are now registered on the hub MOOCH.' Under Hubs with which you are registered is listed 'Moodle.org (MOOCH)' So changing the hub name should be enough to change those 3 strings. Re - en_fix - it was merged to stables on the 6th ( MDL-38352 ) and the strings still say MOOCH - so I think we will have to change this directly (or remerge en_fix).
            Hide
            Damyon Wiese added a comment -

            Pushing branches now...

            One thing is that I haven't changed HUB_MOODLEORGHUBURL (still http://hub.moodle.org). Without reading all the code I think it would be risky to change that.

            Show
            Damyon Wiese added a comment - Pushing branches now... One thing is that I haven't changed HUB_MOODLEORGHUBURL (still http://hub.moodle.org ). Without reading all the code I think it would be risky to change that.
            Hide
            Helen Foster added a comment -

            As you've noticed, en_fix is not yet merged. (MDL-38352 was for merging into 2.3.5 and 2.4.2.) David was working on it last night so I assume it will be completed soon.

            Show
            Helen Foster added a comment - As you've noticed, en_fix is not yet merged. ( MDL-38352 was for merging into 2.3.5 and 2.4.2.) David was working on it last night so I assume it will be completed soon.
            Hide
            Helen Foster added a comment -

            Jerome, just checking whether you've changed the text and image displayed when searching for a community course (as in attached screenshot)?

            Show
            Helen Foster added a comment - Jerome, just checking whether you've changed the text and image displayed when searching for a community course (as in attached screenshot)?
            Hide
            Frédéric Massart added a comment -

            Thanks Damyon, this looks good to me. I also think that updating the constant is trickier, it might require an upgrade script. Cheers!

            Show
            Frédéric Massart added a comment - Thanks Damyon, this looks good to me. I also think that updating the constant is trickier, it might require an upgrade script. Cheers!
            Hide
            Damyon Wiese added a comment -

            Thanks for the update Helen, I don't know if David has done this yet or not - if not this patch will be required for us to release the minor versions.

            I'll check this image too.

            (I also updated the wording for the 2.2 branch as it was a bit confusing between Moodle.org and Moodle.net).

            Show
            Damyon Wiese added a comment - Thanks for the update Helen, I don't know if David has done this yet or not - if not this patch will be required for us to release the minor versions. I'll check this image too. (I also updated the wording for the 2.2 branch as it was a bit confusing between Moodle.org and Moodle.net).
            Hide
            Damyon Wiese added a comment -

            The image seems to come from the hub itself - so if it's not updated already it can be done from there.

            Show
            Damyon Wiese added a comment - The image seems to come from the hub itself - so if it's not updated already it can be done from there.
            Hide
            Damyon Wiese added a comment -

            Also note en_fix was merged with master as part of MDL-38352.

            Show
            Damyon Wiese added a comment - Also note en_fix was merged with master as part of MDL-38352 .
            Hide
            Damyon Wiese added a comment -

            Chatting with Helen - I misread the git log (6th Mar - not 6th May!) so en_fix is still yet to be merged so most of these patches are not needed.

            There is still one change that will be needed to fix a string that isn't in the language file. I'll update the branches to only fix that.

            Show
            Damyon Wiese added a comment - Chatting with Helen - I misread the git log (6th Mar - not 6th May!) so en_fix is still yet to be merged so most of these patches are not needed. There is still one change that will be needed to fix a string that isn't in the language file. I'll update the branches to only fix that.
            Hide
            David Mudrak added a comment -

            FYI, en_fix will be prepared for integration on Monday morning (EU time). So it's really up to you to decide whether to provide the change via Git patch (and integrate it now) or wait till Monday and do it via en_fix.

            Show
            David Mudrak added a comment - FYI, en_fix will be prepared for integration on Monday morning (EU time). So it's really up to you to decide whether to provide the change via Git patch (and integrate it now) or wait till Monday and do it via en_fix.
            Hide
            David Mudrak added a comment -

            Also note, these are some strings mentioning MOOCH in the local_hub plugin. That one is considered as an add-on, thence must be fixed directly and not via en_fix.

            Show
            David Mudrak added a comment - Also note, these are some strings mentioning MOOCH in the local_hub plugin. That one is considered as an add-on, thence must be fixed directly and not via en_fix.
            Hide
            Eloy Lafuente (stronk7) added a comment -

            Why this change, sniff, sniff, I loved that name, more these days with all those MOOCs flying around.

            Show
            Eloy Lafuente (stronk7) added a comment - Why this change, sniff, sniff, I loved that name, more these days with all those MOOCs flying around.
            Hide
            Eloy Lafuente (stronk7) added a comment -

            Note that MOOCH is also one of the works autolinked by the filter_moodlelinks filter. And right now it transforms the occurrences (of "mooch" case-insesitive) to:

            <a title="Moodle.org Open Community Hub" href="http://hub.moodle.org">MOOCH</a>
            

            Can you create an issue with the expected new behavior, please and assign it to me? I'll be happy to perform the change.

            Ciao

            Show
            Eloy Lafuente (stronk7) added a comment - Note that MOOCH is also one of the works autolinked by the filter_moodlelinks filter. And right now it transforms the occurrences (of "mooch" case-insesitive) to: <a title="Moodle.org Open Community Hub" href="http://hub.moodle.org">MOOCH</a> Can you create an issue with the expected new behavior, please and assign it to me? I'll be happy to perform the change. Ciao
            Hide
            Eloy Lafuente (stronk7) added a comment -

            (adding the ui_change & docs_required labels)

            Show
            Eloy Lafuente (stronk7) added a comment - (adding the ui_change & docs_required labels)
            Hide
            Eloy Lafuente (stronk7) added a comment -

            Integrated (23, 24 and master), not really convinced, thanks!

            Show
            Eloy Lafuente (stronk7) added a comment - Integrated (23, 24 and master), not really convinced, thanks!
            Hide
            Eloy Lafuente (stronk7) added a comment -

            I'm still getting some MOOCHs both in the registration and hub pages... I assume that those will arrive as part of the en_fix changes, correct? For all branches, I hope.

            I don't think this is the best way to handle changes like this, really. Everything is like "floating", lol.

            Ciao

            Show
            Eloy Lafuente (stronk7) added a comment - I'm still getting some MOOCHs both in the registration and hub pages... I assume that those will arrive as part of the en_fix changes, correct? For all branches, I hope. I don't think this is the best way to handle changes like this, really. Everything is like "floating", lol. Ciao
            Hide
            Helen Foster added a comment -

            Removing docs_required label as 24 and 25 docs were updated on 6 May 2013 (as commented).

            I'm still getting some MOOCHs both in the registration and hub pages... I assume that those will arrive as part of the en_fix changes, correct? For all branches, I hope.

            Yes, with the en_fix changes and for all branches.

            Show
            Helen Foster added a comment - Removing docs_required label as 24 and 25 docs were updated on 6 May 2013 (as commented). I'm still getting some MOOCHs both in the registration and hub pages... I assume that those will arrive as part of the en_fix changes, correct? For all branches, I hope. Yes, with the en_fix changes and for all branches.
            Hide
            Helen Foster added a comment -

            As requested, filter_moodlelinks filter update reported as MDLSITE-2264.

            Show
            Helen Foster added a comment - As requested, filter_moodlelinks filter update reported as MDLSITE-2264 .
            Hide
            Eloy Lafuente (stronk7) added a comment -

            Passing based on Helen comments, thanks for that and creating the filter issue!

            PS: My comments above was about not liking the way we have ended mixing code changes and en_fix changes in the same issue. Both have different momentums and we should not mix them. Is like "trusting" something that still cannot be tested... just IMO, was my feeling while processing this issue.

            Show
            Eloy Lafuente (stronk7) added a comment - Passing based on Helen comments, thanks for that and creating the filter issue! PS: My comments above was about not liking the way we have ended mixing code changes and en_fix changes in the same issue. Both have different momentums and we should not mix them. Is like "trusting" something that still cannot be tested... just IMO, was my feeling while processing this issue.
            Hide
            Eloy Lafuente (stronk7) added a comment -

            Did you think this day was not going to arrive ever?

            Your patience has been rewarded, yay, sent upstream, thanks!

            Closing...ciao

            Show
            Eloy Lafuente (stronk7) added a comment - Did you think this day was not going to arrive ever? Your patience has been rewarded, yay, sent upstream, thanks! Closing...ciao

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                7 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: