Moodle
  1. Moodle
  2. MDL-39538

badges use deprecated function make_categories_list

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.5
    • Fix Version/s: 2.5
    • Component/s: Badges
    • Labels:
      None
    • Testing Instructions:
      Hide
      1. Create at least one course with enabled completion
      2. Enabled badges
      3. Create a badge
      4. Edit badge, click on Criteria
      5. Add a criteria based on course completion, make sure no warning is displayed and courses list is populated correctly
      Show
      Create at least one course with enabled completion Enabled badges Create a badge Edit badge, click on Criteria Add a criteria based on course completion, make sure no warning is displayed and courses list is populated correctly
    • Affected Branches:
      MOODLE_25_STABLE
    • Fixed Branches:
      MOODLE_25_STABLE
    • Pull Master Branch:
      wip-MDL-39538-master
    • Rank:
      50217

      Description

      badges/criteria/award_criteria_courseset.php uses deprecated function make_categories_list()

        Issue Links

          Activity

          Hide
          Dan Poltawski added a comment -

          This is fixed in MDL-39397

          Show
          Dan Poltawski added a comment - This is fixed in MDL-39397
          Hide
          Eloy Lafuente (stronk7) added a comment -

          I'm going ahead with this because MDL-39397 has been reopened, and given the dates we are... (will drop a note there).

          Show
          Eloy Lafuente (stronk7) added a comment - I'm going ahead with this because MDL-39397 has been reopened, and given the dates we are... (will drop a note there).
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Integrated, thanks!

          (I've added a tiny commit taking rid of unused $PAGE global in the same method)

          Show
          Eloy Lafuente (stronk7) added a comment - Integrated, thanks! (I've added a tiny commit taking rid of unused $PAGE global in the same method)
          Hide
          Eloy Lafuente (stronk7) added a comment -

          tested here with 2 cats and 3 courses, all ok. Passing.

          Show
          Eloy Lafuente (stronk7) added a comment - tested here with 2 cats and 3 courses, all ok. Passing.
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Did you think this day was not going to arrive ever?

          Your patience has been rewarded, yay, sent upstream, thanks!

          Closing...ciao

          Show
          Eloy Lafuente (stronk7) added a comment - Did you think this day was not going to arrive ever? Your patience has been rewarded, yay, sent upstream, thanks! Closing...ciao

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: