[MDL-39554] You should not be able to edit the session and request cache sharing. - Moodle Tracker

XML

Word

Printable

Testing Instructions:
Hide

Run unit tests.

Log in as an admin.

Browse to Settings > Plugins > Caching > Configuration.

Check that you cannot edit sharing for any request/session caches (in the definitions table).

Check that you all request/session caches have site identifier set as there sharing option (in the definitions table).
Show
Run unit tests. Log in as an admin. Browse to Settings > Plugins > Caching > Configuration. Check that you cannot edit sharing for any request/session caches (in the definitions table). Check that you all request/session caches have site identifier set as there sharing option (in the definitions table).
Affected Branches:
MOODLE_25_STABLE
Fixed Branches:
MOODLE_25_STABLE
Pull from Repository:
git://github.com/samhemelryk/moodle.git
Pull Master Branch:
wip-~~MDL-39554~~-m25
Pull Master Diff URL:
https://github.com/samhemelryk/moodle/compare/5df9bc3...wip-MDL-39554-m25

There's no point in allowing it really.

Two changes to be made:

Force the available sharing options for request and session caches to just siteid.
Remove the edit sharing link if there is only one option available.