Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-39568

Using marking guide, students do not see marks in the guide before grading

    Details

    • Testing Instructions:
      Hide

      Set an assignment to use the advanced grading method "marking guide"

      set up a marking guide with some criteria and check the boxes "show guide definition to students" and "show marks per criterion to students"

      login as a student and preview the marking guide - (look in navigation block for a link)

      Make sure the "maxgrade" is shown beside the criteria.

      Show
      Set an assignment to use the advanced grading method "marking guide" set up a marking guide with some criteria and check the boxes "show guide definition to students" and "show marks per criterion to students" login as a student and preview the marking guide - (look in navigation block for a link) Make sure the "maxgrade" is shown beside the criteria.
    • Affected Branches:
      MOODLE_24_STABLE, MOODLE_26_STABLE
    • Fixed Branches:
      MOODLE_25_STABLE, MOODLE_26_STABLE
    • Pull Master Branch:

      Description

      We have a marking guide, and the box is checked to Show marks per criterion to students. As a student, they do not see the marks, they just see the guide.
      They will however see the marks after the assignment has been graded.

      Shouldn't they see the marks before grading?
      What are we missing?

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

              Hide
              damyon Damyon Wiese added a comment -

              This issue was assigned to me automatically, however I will not be able to work on this issue in the immediate future. In order to create a truer sense of the state of this issue and to allow other developers to have chance to become involved, I am removing myself as the assignee of this issue.

              For more information, see http://docs.moodle.org/dev/Changes_to_issue_assignment

              Show
              damyon Damyon Wiese added a comment - This issue was assigned to me automatically, however I will not be able to work on this issue in the immediate future. In order to create a truer sense of the state of this issue and to allow other developers to have chance to become involved, I am removing myself as the assignee of this issue. For more information, see http://docs.moodle.org/dev/Changes_to_issue_assignment
              Hide
              damyon Damyon Wiese added a comment -

              I have just reassigned this issue to the correct component.

              Show
              damyon Damyon Wiese added a comment - I have just reassigned this issue to the correct component.
              Hide
              trevor_c Trevor Cunnnigham added a comment -

              Just ran into this at our institution on Moodle 2.4.7+. It seems the code is missing to display the maxscore, regardless of whether the option has been checked.

              The following file needs to be changed, around line 170:

              grade/grading/form/guide/renderer.php

                      } else if ($mode == gradingform_guide_controller::DISPLAY_PREVIEW_GRADED ||
                                 $mode == gradingform_guide_controller::DISPLAY_VIEW) {
                          $title .= $description;
                          
                          // fix MDL-39568
                          // display maxscore if showmarkspercriterionstudents has been enabled
                          // https://tracker.moodle.org/browse/MDL-39568
                          if (!empty($options['showmarkspercriterionstudents'])) {
                              $title .=  html_writer::tag('label', get_string('maxscore', 'gradingform_guide'),
                                  array('for'=>'{NAME}[criteria][{CRITERION-id}][maxscore]'));
                              $title .= $maxscore;
                          }
                          // end-fix MDL-39568
                      } else {
                          $title .= $description . $descriptionmarkers;
                      }

              Show
              trevor_c Trevor Cunnnigham added a comment - Just ran into this at our institution on Moodle 2.4.7+. It seems the code is missing to display the maxscore, regardless of whether the option has been checked. The following file needs to be changed, around line 170: grade/grading/form/guide/renderer.php } else if ($mode == gradingform_guide_controller::DISPLAY_PREVIEW_GRADED || $mode == gradingform_guide_controller::DISPLAY_VIEW) { $title .= $description; // fix MDL-39568 // display maxscore if showmarkspercriterionstudents has been enabled // https://tracker.moodle.org/browse/MDL-39568 if (!empty($options['showmarkspercriterionstudents'])) { $title .= html_writer::tag('label', get_string('maxscore', 'gradingform_guide'), array('for'=>'{NAME}[criteria][{CRITERION-id}][maxscore]')); $title .= $maxscore; } // end-fix MDL-39568 } else { $title .= $description . $descriptionmarkers; }
              Hide
              trevor_c Trevor Cunnnigham added a comment -

              Just prepping for an upgrade and this still appears to be an issue in Moodle 2.6.

              Show
              trevor_c Trevor Cunnnigham added a comment - Just prepping for an upgrade and this still appears to be an issue in Moodle 2.6.
              Hide
              mcwoods Michael Woods added a comment -

              A teacher just reported this bug to me today, and I was able to reproduce it. We are running 2.6.2+ (20140314). Thanks for the patch, Trevor.

              Show
              mcwoods Michael Woods added a comment - A teacher just reported this bug to me today, and I was able to reproduce it. We are running 2.6.2+ (20140314). Thanks for the patch, Trevor.
              Hide
              danmarsden Dan Marsden added a comment -

              Thanks for the patch Trevor! - it looks good to me so I have attributed a commit to you using the e-mail address on your tracker profile and now pushing it up for integration.

              Show
              danmarsden Dan Marsden added a comment - Thanks for the patch Trevor! - it looks good to me so I have attributed a commit to you using the e-mail address on your tracker profile and now pushing it up for integration.
              Hide
              cibot CiBoT added a comment -

              Moving this issue to current integration cycle, will be reviewed soon. Thanks for the hard work!

              Show
              cibot CiBoT added a comment - Moving this issue to current integration cycle, will be reviewed soon. Thanks for the hard work!
              Hide
              cibot CiBoT added a comment -

              Moving this issue to current integration cycle, will be reviewed soon. Thanks for the hard work!

              Show
              cibot CiBoT added a comment - Moving this issue to current integration cycle, will be reviewed soon. Thanks for the hard work!
              Hide
              marina Marina Glancy added a comment -

              Thanks Trevor and Dan, integrated in 2.5, 2.6 and master

              Show
              marina Marina Glancy added a comment - Thanks Trevor and Dan, integrated in 2.5, 2.6 and master
              Hide
              lameze Simey Lameze added a comment -

              Tested in integration_master, integration_26 and integration_25 and the Maximum Mark is showing in all those versions.

              Show
              lameze Simey Lameze added a comment - Tested in integration_master, integration_26 and integration_25 and the Maximum Mark is showing in all those versions.
              Hide
              marina Marina Glancy added a comment -

              Thanks for your awesome code, it is now part of Moodle. Don't forget to submit another issue next week (and peer review two).

              Show
              marina Marina Glancy added a comment - Thanks for your awesome code, it is now part of Moodle. Don't forget to submit another issue next week (and peer review two).

                People

                • Votes:
                  5 Vote for this issue
                  Watchers:
                  9 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:
                    Fix Release Date:
                    12/May/14