[MDL-39579] Tricky to set a type on elements within a named group inside repeated elements - Moodle Tracker

XML

Word

Printable

Affected Branches:
MOODLE_22_STABLE, MOODLE_23_STABLE, MOODLE_24_STABLE, MOODLE_25_STABLE
Fixed Branches:
MOODLE_25_STABLE
Pull from Repository:
git://github.com/FMCorz/moodle.git
Pull Master Branch:
~~MDL-39579~~-master-int
Pull Master Diff URL:
https://github.com/FMCorz/moodle/compare/dec909fcdd357344ebb9a22843e52474059fb884...MDL-39579-master-int
Testing Instructions:
Hide

Focus on groups within repeated elements

Run the Unit Tests

Play with attached file test_form_validation.php

Make sure the warnings displayed are expected

Make sure the expected warnings are displayed

Make sure the submitted values are cleaned properly

Search for groups in repeated elements

Make sure they work as expected
Show
Focus on groups within repeated elements Run the Unit Tests Play with attached file test_form_validation.php Make sure the warnings displayed are expected Make sure the expected warnings are displayed Make sure the submitted values are cleaned properly Search for groups in repeated elements Make sure they work as expected

The magic in $mform->repeat_elements() does not allow for the developer to set a type on an element within a (named?) group.

The following code doesn't work:

            $group = array(

                $mform->createElement('text', 'repeatedgroupel1', 'repeatedgroupel1'),

                $mform->createElement('text', 'repeatedgroupel2', 'repeatedgroupel2'));

            $repeat = $mform->createElement('group', 'mygroup', 'mygroup', $group);

            $this->repeat_elements(array($repeat), 2, array('mygroup[repeatedgroupel1]' => array('type' => PARAM_INT)),

                'repeteablegroup', 'add', 0);

blocks

MDL-39599 Fix setType in course module forms (should fix behat for most modules).

has been marked as being related by

MDL-39578 detectMissingSetType does not happen after definition_after_data()

is duplicated by

MDL-38709 Add support for element groups in detectMissingSetType()

will be (partly) resolved by

MDL-39650 Tricky to set a type on elements within a named group inside repeated elements (backport of MDL-39579)

Participants:: Adrian Greeve, Damyon Wiese, Dan Poltawski, Eloy Lafuente (stronk7), Frédéric Massart

Component watchers:: David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo