Moodle

It's possible for the calendar popup to change multiple date elements.

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 2.5
  • Fix Version/s: 2.5
  • Component/s: Forms Library
  • Labels:
    None
  • Testing Instructions:
    Hide

    There is no real way to test this because the behaviour of the pop-up has changed. Previously when you had multiple date elements enabled on a form, and clicked on a calendar image so the pop-up appeared you could then click on another element's calendar image and the first element's pop-up would disappear but another would not appear until you clicked the image again. Meaning you had to click twice for the date pop-up to appear for the second date element you selected. Now, when you click on any calendar image, any previously opened date selectors for other elements that were open will be closed and a new pop-up will appear.

    Test 1

    1. Go to Site administration ► Users ► Accounts ► Browse list of users.
    2. Click "Show more"
    3. Enable all the date fields.
    4. Change the dates and ensure the date only changes for the one you selected. Alternate between changing dates in the pop-up and the select boxes.

    Test 2

    1. Create a feedback activity.
    2. On the settings page enable all date fields.
    3. Change the dates and ensure the date only changes for the one you selected. Alternate between changing dates in the pop-up and the select boxes.

    Test 3

    1. Repeat the steps in MDL-26649

    Please test in at least ie, firefox and chrome.

    Show
    There is no real way to test this because the behaviour of the pop-up has changed. Previously when you had multiple date elements enabled on a form, and clicked on a calendar image so the pop-up appeared you could then click on another element's calendar image and the first element's pop-up would disappear but another would not appear until you clicked the image again. Meaning you had to click twice for the date pop-up to appear for the second date element you selected. Now, when you click on any calendar image, any previously opened date selectors for other elements that were open will be closed and a new pop-up will appear. Test 1 Go to Site administration ► Users ► Accounts ► Browse list of users. Click "Show more" Enable all the date fields. Change the dates and ensure the date only changes for the one you selected. Alternate between changing dates in the pop-up and the select boxes. Test 2 Create a feedback activity. On the settings page enable all date fields. Change the dates and ensure the date only changes for the one you selected. Alternate between changing dates in the pop-up and the select boxes. Test 3 Repeat the steps in MDL-26649 Please test in at least ie, firefox and chrome.
  • Affected Branches:
    MOODLE_25_STABLE
  • Fixed Branches:
    MOODLE_25_STABLE
  • Pull from Repository:
  • Pull Master Branch:
    MDL-39581_master
  • Pull Master Diff URL:

Description

  1. Go to Site administration ► Users ► Accounts ► Browse list of users
  2. Click "Show more"
  3. Enable all the date fields.
  4. Click on calender icon for the lowest date selector.
  5. Click on the icon for the one above that so that the calendar closes.
  6. Click on the icon again so the calendar pop ups.
  7. Repeat the last 2 steps until you have the calendar open on the top date selector.
  8. Change the date and notice all the select boxes change.

Issue Links

discovered while testing

Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-39463 Some usages of the date_selector do not use the optional parameter but use another checkbox meaning the calendar image is never disabled by the JS.

  • Major - Major loss of function, incorrect output
  • Closed - The issue is considered finished, the resolution is correct. Issues which are closed should not be reopened.
testing discovered

Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-39639 If the calendar is open and the date picker form element is disabled, the calendar does not close.

  • Minor - Minor loss of function where workaround is possible
  • Closed - The issue is considered finished, the resolution is correct. Issues which are closed should not be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Rajesh Taneja added a comment -

Thanks Mark Patch looks good to me.
Pushing it for integration.

Show
Rajesh Taneja added a comment - Thanks Mark Patch looks good to me. Pushing it for integration.
Hide
Permalink
Eloy Lafuente (stronk7) added a comment -

The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

TIA and ciao

Show
Eloy Lafuente (stronk7) added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
Hide
Permalink
Damyon Wiese added a comment -

Thanks Mark,

This has been integrated to master. I the user search page in chrome and the fix worked well.

Show
Damyon Wiese added a comment - Thanks Mark, This has been integrated to master. I the user search page in chrome and the fix worked well.
Hide
Permalink
David Monllaó added a comment -

It passes using IE9

Show
David Monllaó added a comment - It passes using IE9
Hide
Permalink
David Monllaó added a comment -

Using IE9 in Win7, the only thing I've noticed is that with the date selector enabled and the popup calendar opened, if I uncheck 'Enable' the popup calendar is still opened and I need an extra click to close it; if after unchecking 'Enable' I select a date using the popup calendar the date is updated in the disabled (disabled since I unchecked 'Enable') drop down menus.

Show
David Monllaó added a comment - Using IE9 in Win7, the only thing I've noticed is that with the date selector enabled and the popup calendar opened, if I uncheck 'Enable' the popup calendar is still opened and I need an extra click to close it; if after unchecking 'Enable' I select a date using the popup calendar the date is updated in the disabled (disabled since I unchecked 'Enable') drop down menus.
Hide
Permalink
Adrian Greeve added a comment -

Tested on firefox and Chrome, I get the same behaviour as David mentions, but I think that can be tackled in a separate issue if required.
Test passed.

Show
Adrian Greeve added a comment - Tested on firefox and Chrome, I get the same behaviour as David mentions, but I think that can be tackled in a separate issue if required. Test passed.
Hide
Permalink
Damyon Wiese added a comment -

Added an new issue for the reported behaviour.

Show
Damyon Wiese added a comment - Added an new issue for the reported behaviour.
Hide
Permalink
Eloy Lafuente (stronk7) added a comment -

Just In Time® for stable releases, thanks!

Closing as fixed, ciao

Show
Eloy Lafuente (stronk7) added a comment - Just In Time® for stable releases, thanks! Closing as fixed, ciao

People

Vote (0)
Watch (5)

Dates

  • Created:
    Updated:
    Resolved: